search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.98k stars 2.35k forks source link

Calls to chrome APIs should be moved out of Gemini and Binance components #10815

Open ryanml opened 4 years ago

ryanml commented 4 years ago

Currently, there are calls inside the Binance and Gemini components to their respective chrome APIs. This makes it difficult to mock methods for a storybook implementation. These should be moved to the NewTab component container for a better separation of concerns.

kjozwiak commented 4 years ago

Moving out of 1.13.x as per https://github.com/brave/brave-core/pull/6120#issuecomment-665292654. This will need another approach which will require a larger refactor. Won't make 1.13.x as the work hasn't been started.