[Desktop] Wrong code words are shown in `View Sync Code` after sync creation

[btlechowski]

Completely different code words are shown in View Sync Code compared to the ones used to create sync chain.

Steps to Reproduce

1. Clean install
2. Open brave://settings/braveSync/setup
3. Click Start a new sync chain
4. Click Computer
5. Copy the code words
6. Click OK
7. Click Manage your synced devices
8. Click View Sync Code

Actual result:

Different Code words are used Code words used to create sync chain: erode town stool cactus measure setup portion police soldier father hover modify acid coyote lens catch velvet oyster peanut stay fever crater sleep stick Code words in View Sync Code: adjust hour inside cat barely replace thunder popular text hip yard begin stumble miss retire between square pony vacant fat guide subway ethics isolate

Note: Page reload fixes the issue

Expected result:

Same Code words are used

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Brave	1.12.94 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
Revision	19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS	Ubuntu 18.04 LTS

Brave	1.13.36 Chromium: 84.0.4147.89 (Official Build) nightly (64-bit)
Revision	19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS	Ubuntu 18.04 LTS

cc @brave/legacy_qa @jsecretan @rebron @darkdh @AlexeyBarabash @yrliou @petemill

[btlechowski]

Another Test Case - Sync between two devices Both devices got wrong code words

Steps

1. Clean install DeviceA and DeviceB
2. On DeviceA open brave://settings/braveSync/setup
3. On DeviceA click Start a new sync chain
4. On DeviceA click Computer
5. On DeviceA copy the code words
6. On DeviceA click OK
7. On DeviceA Compare View Sync Code with copied ones
8. On DeviceB open brave://settings/braveSync/setup
9. On DeviceB click I have a sync Code
10. On DeviceB paste the code words
11. On DeviceB click Confirm
12. On DeviceB Compare View Sync Code with copied ones

Results Code words on both devices are different than the ones used to create sync chain

[btlechowski]

Verification passed on

Brave	1.12.105 Chromium: 84.0.4147.105 (Official Build) (64-bit)
Revision	a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS	Ubuntu 18.04 LTS

Verified test plan from https://github.com/brave/brave-core/pull/6182#issue-455400985.

Copied code words Code words from View Sync Code Code words after sync reset Code words from View Sync Code after sync reset

Verified test case from https://github.com/brave/brave-browser/issues/10857#issuecomment-662589445

---

Verification passed on

Brave | 1.12.107 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | Windows 10 OS Version 1903 (Build 18362.959)

• Verified test plan from https://github.com/brave/brave-core/pull/6182#issue-455400985.

Copied code words

Code words from View Sync Code

Code words after sync reset

Code words from View Sync Code after sync reset

• Verified the test case from https://github.com/brave/brave-browser/issues/10857#issuecomment-662589445

---

Verification PASSED on macOS 10.15.6 x64 using the following build:

Brave | 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | macOS Version 10.15.6 (Build 19G73)

Ensured that the STR/Cases outlined via https://github.com/brave/brave-browser/issues/10857#issue-663929194 worked as expected:

Code via Setup	Code under Manage

Ensured that the STR/Cases outlined via https://github.com/brave/brave-browser/issues/10857#issuecomment-662589445 worked as expected:

Code via Setup (macOS)	Code under Manage (macOS)

Code under Manage (Win 10 x64)