Allow for Private and Tor tabs to be themed

Brave-Matt commented 6 years ago

Description

Users should be able to customize the appearance of their private windows/tabs with themes or in the same way standard windows are. While this customization should be allowed, some restrictions should be placed on theme to avoid the user confusing a standard tab with a private tab should they use similar or identical themes.

Some solutions/thoughts:

Brave could create some number of predefined "Private themes" for users to choose from. This would ensure that the distinction between standard and private windows is preserved. This is opposed to allowing users set the private window theme to be any available theme. If this were allowed, it opens the potential for both private and standard windows to have the same (or similar) themes blurring that distinction. While that would likely fall under the "user error" category, our stance on keeping the users information/data private should carry over to this [privacy based] feature. It shows that we know that [sometimes silly] mistakes happen and Brave has done everything it can to prevent them.
Private windows should stay "dark" in tone overall, but adjust tint/shade as I have heard users mention (contrary to the norm) that it is sometimes hard to distinguish certain elements with dark mode implemented. Additionally, changing the color/brightness of UI elements within the private tab (or private tab theme) may be an easy way to initially address the dark/bright problem by ensuring that regardless of the central color theme, everything in Brave remains clear and easy to distinguish.

Steps to Reproduce

N/A

Actual result:

N/A

Expected result:

N/A

Reproduces how often:

N/A

Brave version (chrome://version info)

Dev build/Brave-Core

Reproducible on current release:

N/A

Website problems only:

N/A

Additional Information

Here is the report that pushed me to write the issue. I know that I have seen additional reports like this, I will update the post or add them to the thread as I dig them out: https://community.brave.com/t/is-there-an-option-to-modify-the-default-screen-color-in-incognito-mode/32067

eljuno commented 5 years ago

+1 from Community https://community.brave.com/t/color-theme-settings-in-private-window/48301?u=eljuno

AwakeningLightning commented 6 months ago

+1 from me lol

AdamBrezik commented 3 months ago

It seems weird to me that incognito window has a style of its own. It should be the same with a just an icon or a heading to distinguish it, nothing more. The whole wonderous mystique of di grand Purpurio thing seems a little cringe to me

LinuxLover9 commented 3 weeks ago

This issue is open since 2018! But still no progress? At least give the “Enable Incognito brand consistency in desktop” flag back, if that is the quickest way to restore functionality?

jayars commented 3 weeks ago

Installed Brave for the first time today. For me personally, the vibrant dark purple hurts my eyes.

Most of the sites I visit only have light mode. Looking back-and-forth between Brave's purple UI (tabs) and web pages causes actual pain to my eyes. Interestingly, I don't have this issue with Chrome's Incognito mode. I think it is because of Brave's high purple color saturation.

Incognito UI suggestions:

option to increase/decrease the saturation (ie, turn to complete gray)
option to increase/decrease the brightness (ie, better suit people's monitors, and sites they normally use)
(nice to have) option to change the hue (ie, allow people to personalize their incognito ui theme color)

AdamBrezik commented 3 weeks ago

Most of the sites I visit only have light mode.

I hate to give you a workaround for something I think it's wrong, but there are extensions that can pretty well invert site colors. One I tried also took the different visual contrast of the inverted colors into consideration and tweaked them a little.

Perhaps that could save your eyes from the vibrant evil in the meantime.

I myself just go fullscreen when I can.

7heMech commented 2 weeks ago

This issue is open since 2018! But still no progress? At least give the “Enable Incognito brand consistency in desktop” flag back, if that is the quickest way to restore functionality?

Sadly, I don't think the Brave team even cares.

AideeAmei commented 4 days ago

Another WA, make everything purple and you won't care...

brave / brave-browser