brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.71k stars 2.31k forks source link

[Desktop] Uniformity on Right-Click Title Bar Context Menu #11399

Open hennrynusasatria opened 4 years ago

hennrynusasatria commented 4 years ago

Hi All,

Just to let you know that Brave Browser also suffers from the below issue.

I usually use right-click on title bar to "Reopen closed tab" and calling "Task Manager", but I found that the appearance of this right-click title bar context menu does not follow light or dark theme, this even does not have the same uniform compared to the right-click on webpage (or right-click on the tab), please refer to the screenshots as attached.

It does not work on both Light Mode and Dark Mode (through the Settings on Windows 10).

I found that this improper behavior happens on Chrome, thus I believe that to fix this improper behavior, then it must be done from Chromium codebase.

Please refer to the following reports:

https://techcommunity.microsoft.com/t5/discussions/uniformity-on-right-click-title-bar-context-menu/m-p/1592037

https://bugs.chromium.org/p/chromium/issues/detail?id=1120285#c1

Please also refer to the following screen-cast:

Right-Click_Title_Bar_Context_Menu_Chrome_Browser.zip

Thank you.

rebron commented 4 years ago

Hi @hennrynusasatria. Thanks for the report. Can you follow the issue template and tell us what it is you're seeing and what you're expected result is. I'm having trouble parsing what you're asking for here. Not clear whether you want the same right click context menu across the board (which is something we wouldn't fix) or if there's a light/dark theme issue with the context menu.

hennrynusasatria commented 4 years ago

Hi @rebron

Thank you for the response.

Description

There's a Light/Dark Theme Issue with The Context Menu (Right-Click Context Menu of Title Bar)

Steps to Reproduce

  1. Right-click on title bar (not tabs).
  2. Check also on right-click on tabs and webpage.
  3. See that the context menu (right-click on title bar) does not have the appearance as on the context menu on tabs and webpage. It has different appearance/flavor, it has grey color (not light or dark).
  4. It does not work on both Light Mode and Dark Mode from the Settings of Windows 10 (or manual from inside the Brave Settings), it seems that it also does not respect the third-party theme.
  5. Please also check the screen-cast: Right-Click_Title_Bar_Context_Menu_Chrome_Browser.zip

Actual result:

I found that this happens on all Chromium based browsers (Google Chrome and Microsoft Edge Chromium), below are the examples:

Light_Right_Click_Menu_Window_on_Webpage_Edge

Light_Right_Click_Menu_Window_on_Title_Bar_Edge

Dark_Right_Click_Menu_Window_on_Webpage_Edge

Dark_Right_Click_Menu_Window_on_Title_Bar_Edge

Light_Right_Click_Menu_Window_on_Webpage_Chrome

Light_Right_Click_Menu_Window_on_Title_Bar_Chrome

Dark_Right_Click_Menu_Window_on_Webpage_Chrome

Dark_Right_Click_Menu_Window_on_Title_Bar_Chrome

Dark_Right_Click_Menu_Window_on_Title_Bar_File_Explorer

I believe that to fix this improper behavior, then it must be done from Chromium codebase.

Expected result:

"Right-Click Context Menu of Title Bar" must have the same appearance/flavor like other Context Menus on other part of the browser.

I believe that to fix this improper behavior, then it is better to be done on Chromium codebase, perhaps @brave-dev is willing to contribute back to Chromium codebase by fixing this improper behavior.

Please refer to the following reports:

https://techcommunity.microsoft.com/t5/discussions/uniformity-on-right-click-title-bar-context-menu/m-p/1592037

https://bugs.chromium.org/p/chromium/issues/detail?id=1120285#c1

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version 1.12.114 Chromium: 84.0.4147.135 (Official Build) (32-bit) Windows 10

Version/Channel Information:

Version 1.12.114 Chromium: 84.0.4147.135 (Official Build) (32-bit) Windows 10

Other Additional Information:

NonstickAtom785 commented 2 years ago

This does not appear to be an issue anymore. Issue can be closed.