[Android] Problem with Brave rewards location detection system

manikandancode commented 4 years ago

Description

Recently installed Windscribe VPN android app. After that brave added the "State level ad targeting option" with some us state selected in my Brave Rewards Ads settings page. (Previously there is no State level ad targeting option). After that completely removed Windscribe, Cleared the mobile and brave cache. Also tried Brave rewards ON and OFF. Brave ads ON and OFF. And restarted the mobile several times. But the "State level ad targeting option" with the us state (alabama in my case) still shows. Now my ip is a local ip. But still no luck.

Steps to reproduce

Brave already installed with Brave rewards enabled and working fine. My current location is not US and there is no "State level ad targeting option" in the Ads settings page.

Install Windscribe android app
Select US location and enable VPN
Restart Mobile and enable VPN
Open Brave browser and start browse.
Go Brave Rewards
In Ads section click view Details, then click the settings icon.
It added State level ad targeting option below Maximum number of ads displayed.
It automatically added the state based on the brave browser location detection system.
Now Disable Windscribe vpn.
1. Completely stop Windscribe from background and uninstall it.
2. Restart mobile
3. Check the Brave Rewards Ads Setting. It Still shows State level ad targeting option with previously selected US state
4. Stop brave from Background, Restart mobile, Open Brave. Try Brave rewards ON and OFF. Try Brave ads ON and OFF, Several mobile restart. But still "State level ad targeting option" with the us state on ads settings page.

Actual result

It still shows "State level ad targeting option" with us state list from the Ads settings page. WhatsApp Image 2020-08-24 at 8 43 30 PM

Expected result

It should remove "State level ad targeting option" with us state list from the Ads settings page.

Issue reproduces how often

Always

Version/Channel Information:

Can you reproduce this issue with the current Play Store version? Yes
Can you reproduce this issue with the current Play Store Beta version? Not Tested
Can you reproduce this issue with the current Play Store Nightly version? Not tested

Device details

Install type (ARM, x86):
Device type (Phone, Tablet, Phablet):Phone
Android version: 6.0.1

Brave version

Brave 1.12.113, Chromium 84.0.4147.125

Website problems only

Does the issue resolve itself when disabling Brave Shields? NO
Does the issue resolve itself when disabling Brave Rewards?NO
Is the issue reproducible on the latest version of Chrome? Not tested

Additional information

tmancey commented 4 years ago

@manikandancode Can you please select Auto-detect and let me know if this selects the correct state. Thank you

manikandancode commented 4 years ago

Currently i am in Asian country. Initially the Auto-detect option setting auto detect state as New York (plz check this) But after some time (in my case after 15 minutes) the option "State level ad targeting option" completely removed. thanks. But Brave should detect the correct location and remove the US "State level ad targeting option" automatically without selecting "Auto-detect" in "State level ad targeting option"

tmancey commented 4 years ago

If your IP address is detected as the USA, i.e. when using a VPN this option will be provided. If the IP address changes to a region outside of the USA this option will be removed

manikandancode commented 4 years ago

If your IP address is detected as the USA, i.e. when using a VPN this option will be provided. If the IP address changes to a region outside of the USA this option will be removed

It is not changing (or removing the US state option) when the IP address changes to a region outside of the USA automatically.

Here we need to trigger that (removing the US state option) manually by selecting "Auto-detect" in state option. If any other option in state list then nothing happen.

It should remove automatically when the IP address changes to a region outside of the USA.

Because for reverse (that is from outside of the USA to USA) it automatically adds that state option. So it should remove that option automatically from USA to outside of the USA without manually selecting each time Auto-detect in state option.

tmancey commented 4 years ago

@manikandancode Thank you for raising https://github.com/brave/brave-browser/issues/11421. We will triage the issue. Once again, thank you

brave / brave-browser