LaurenWags
commented
4 years ago Verification completed using builds below
Brave 1.17.28 Chromium: 86.0.4240.75 (Official Build) nightly (x86_64)
Revision c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS macOS Version 10.14.6 (Build 18G3020)General
- Confirmed Greaselion script no longer needs to be installed manually, just need to confirm that Brave Local Data Updater is version >=1.0.29
- Confirmed visiting non-verified publisher showed the generic Twitter favicon in panel
Standard URL
Note, per internal discussions, confirmed that if a custom favicon exists for the tip banners, this custom favicon will be used everywhere (panel, brave://rewards, etc). This is different than 1.16.x so I wanted to call it out. - Verified steps from https://github.com/brave/brave-core/pull/6671 on staging env - For a verified publisher: - Confirmed tip to https://www.twitter.com/emerick showed on Tips panel of brave://rewards as expected - Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected - Confirmed able to adjust monthly contribution amount from panel - Confirmed able to remove monthly contribution from panel and brave://rewards page - Confirmed panel, 1 time tip and recurring tip banners, and BAT logo all had verified checkmark - For a non-verified publisher: - Confirmed tip to https://www.twitter.com/brave showed on pending table - Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected - Confirmed able to adjust monthly contribution amount from panel - Confirmed able to remove monthly contribution from panel and brave://rewards page - Confirmed custom banner displays for 1 time and recurring tips:
Excluded URL
- Verified steps from https://github.com/brave/brave-core/pull/6671 on staging env - Confirmed https://twitter.com/settings shows Twitter as the publisher per the PR. Confirmed if I tip from panel on this page I tip to twitter.com (goes to pending list). - spot checked excluded URLs from https://github.com/brave/brave-site-specific-scripts/blob/master/scripts/brave_rewards/publisher/twitter/utils.ts#L89-L128 to confirm they also showed Twitter as the publisher
Activity
- Verified steps from https://github.com/brave/brave-core/pull/6671 on staging env (note, confirmed with Emerick that individual Twitter publishers are not added to AC table) - Confirmed only twitter.com is in the `activity_info` db table
History
- Verified steps from https://github.com/brave/brave-core/pull/6671 on prod env - Confirmed after navigating to various Twitter URLs in the same tab the panel displayed the expected publisher info. Used a mix of verified and non-verified publishers. - Used backward/forward navigation in the same tab and confirmed the panel showed the expected publisher info. - Mixed in clicking on individual tweets and opening tip banner from in-line tip button as well - Checked above both when logged in to Twitter and not logged in to TwitterTab Activation
- Verified steps from https://github.com/brave/brave-core/pull/6671 on prod env - Opened various Twitter URLs in multiples tabs and confirmed the panel displayed the expected publisher info. Used a mix of verified and non-verified publishers. - Switched between the various tabs and confirmed the panel showed the expected publisher info. - Mixed in clicking on individual tweets and opening tip banner from in-line tip button as well - Checked above both when logged in to Twitter and not logged in to TwitterTipping non-Twitter publishers
- Verified steps from https://github.com/brave/brave-core/pull/6671 on staging env - Confirmed able to tip each of the following other types of verified publishers: regular sites, GitHub, Twitch, Reddit, Twitter. Vimeo panel is currently broken (#11840) and there are various known issues (especially with Twitch) which will be addressed as each item is implemented via Greaselion. - Checked one time and recurring tipping for the various publisher types listed above. Regular site:
YouTube:
GitHub:
Reddit:
Twitch:
Vimeo(broken):
Recurring and 1 time tips:
Other Various Tests - Settings
- Confirmed content level tips checkbox for Twitter - Confirmed able to toggle this on/off - Encountered https://github.com/brave/brave-browser/issues/12090 while testing this - Confirmed in-line tip button is spaced appropriately while logged in and not logged in to TwitterBrave 1.17.29 Chromium: 86.0.4240.80 (Official Build) nightly (x86_64)
Revision 7ed88b53bda45a2d19efb4f8706dd6b6cad0d3af-refs/branch-heads/4240@{#1183}
OS macOS Version 10.14.6 (Build 18G3020)Other Various Tests - panel and banner messaging
- confirm non verified Twitter pubs show specific messaging on banners/panel
- confirm verified, KYC'd publishers do not show any messing on banners/panel
- Unable to confirm verified, non KYC'd YT publishers show different messaging on banners/panel due to a publisher not being of this type on staging env
Brave 1.17.34 Chromium: 86.0.4240.99 (Official Build) nightly (x86_64)
Revision 002668237e13d38aabd6d11c2d216dd22b736ff2-refs/branch-heads/4240@{#1229}
OS macOS Version 10.14.6 (Build 18G3020)Upgrade
- Install previous version (used 1.16.61 on Dev), enable rewards - have a few 1 time tips to verified publishers (some to twitter, some to other pub types also) - have a few pending 1 time tips to non-verified Twitter publishers - have a few recurring tips to verified publishers set up (some to Twitter, some to other pub types also) - have AC list populated with a mix of verified and non-verified sites - Upgrade to 1.17.x (version with Twitter Greaselion tipping) - confirm all data is preserved on brave://rewards - Confirm if you navigate to the various publishers and open the panel, the AC % is preserved (if publisher is part of AC list), the recurring tip amount is preserved (if set up). Confirm panel shows expected information (favicon if applicable, publisher name, etc). Confirm custom tip banner is available (if applicable). - For an existing recurring tip, confirm you are able to adjust the recurring tip amount for Twitter publisher from the panel - For an existing recurring tip, confirm you are able to delete a recurring tip for Twitter publisher Note - due to https://github.com/brave/brave-browser/issues/4557 verified twitter publishers will still show the generic twitter favicon after upgrade. This will be resolved when https://github.com/brave/brave-browser/issues/6059 is resolved. Encountered and logged https://github.com/brave/brave-browser/issues/12159 which pertains to GH tipping while testing (also applies to new profiles on Nightly as well as upgrades)Accessing twitter via a deep link
While not logged in to Twitter I found a link to a tweet in an article and clicked on it: https://www.buzzfeed.com/daniellaemanuel/best-pumpkin-carving?origin=web-hf
I was directed to Twitter in a new tab as expected. I opened the panel and confirmed the panel showed the expected twitter user's info:
Verification passed on
| Brave | 1.17.32 Chromium: 86.0.4240.80 (Official Build) nightly (64-bit) |
|---|---|
| Revision | 7ed88b53bda45a2d19efb4f8706dd6b6cad0d3af-refs/branch-heads/4240@{#1183} |
| OS | Ubuntu 18.04 LTS |
General
- Confirmed Greaselion script no longer needs to be installed manually, just need to confirm that Brave Local Data Updater is version >=1.0.29  - Confirmed visiting non-verified publisher showed the generic Twitter favicon in panel Standard URL
Note, per internal discussions, confirmed that if a custom favicon exists for the tip banners, this custom favicon will be used everywhere (panel, brave://rewards, etc). This is different than 1.16.x so I wanted to call it out. - Verified steps from https://github.com/brave/brave-core/pull/6671 on staging env - For a verified publisher: - Confirmed tip to https://www.twitter.com/emerick showed on Tips panel of brave://rewards as expected - Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected - Confirmed able to adjust monthly contribution amount from panel - Confirmed able to remove monthly contribution from panel and brave://rewards page - Confirmed panel, 1 time tip and recurring tip banners, and BAT logo all had verified checkmark - For a non-verified publisher: - Confirmed tip to https://www.twitter.com/brave showed on pending table - Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected - Confirmed able to adjust monthly contribution amount from panel - Confirmed able to remove monthly contribution from panel and brave://rewards page - Confirmed custom banner displays for 1 time and recurring tips:       Excluded URL
- Verified steps from https://github.com/brave/brave-core/pull/6671 on staging env - Confirmed https://twitter.com/settings shows Twitter as the publisher per the PR. Confirmed if I tip from panel on this page I tip to twitter.com (goes to pending list). - spot checked excluded URLs from https://github.com/brave/brave-site-specific-scripts/blob/master/scripts/brave_rewards/publisher/twitter/utils.ts#L89-L128 to confirm they also showed Twitter as the publisher   Activity
- Verified steps from https://github.com/brave/brave-core/pull/6671 on staging env (note, confirmed with Emerick that individual Twitter publishers are not added to AC table) - Confirmed only twitter.com is in the `activity_info` db table  History
- Verified steps from https://github.com/brave/brave-core/pull/6671 on prod env - Confirmed after navigating to various Twitter URLs in the same tab the panel displayed the expected publisher info. Used a mix of verified and non-verified publishers. - Used backward/forward navigation in the same tab and confirmed the panel showed the expected publisher info. - Mixed in clicking on individual tweets and opening tip banner from in-line tip button as well - Checked above both when logged in to Twitter and not logged in to TwitterTab Activation
- Verified steps from https://github.com/brave/brave-core/pull/6671 on prod env - Opened various Twitter URLs in multiples tabs and confirmed the panel displayed the expected publisher info. Used a mix of verified and non-verified publishers. - Switched between the various tabs and confirmed the panel showed the expected publisher info. - Mixed in clicking on individual tweets and opening tip banner from in-line tip button as well - Checked above both when logged in to Twitter and not logged in to TwitterTipping non-Twitter publishers
- Verified steps from https://github.com/brave/brave-core/pull/6671 on staging env - Confirmed able to tip each of the following other types of verified publishers: regular sites, GitHub, Twitch, Reddit, Twitter. Vimeo panel is currently broken (#11840) and there are various known issues (especially with Twitch) which will be addressed as each item is implemented via Greaselion. - Checked one time and recurring tipping for the various publisher types listed above. Regular site:  YouTube:  GitHub:  Reddit:  Twitch:  Vimeo(broken):  Recurring and 1 time tips:  Other Various Tests - Settings
- Confirmed content level tips checkbox for Twitter - Confirmed able to toggle this on/off - Encountered https://github.com/brave/brave-browser/issues/12090 while testing this - Confirmed in-line tip button is spaced appropriately while logged in and not logged in to TwitterOther Various Tests - panel and banner messaging
- confirm non verified Twitter pubs show specific messaging on banners/panel    - confirm verified, KYC'd publishers do not show any messing on banners/panel   Upgrade
- Install previous version (used 1.16.61 on Dev), enable rewards - have a few 1 time tips to verified publishers (some to twitter, some to other pub types also) - have a few pending 1 time tips to non-verified Twitter publishers - have a few recurring tips to verified publishers set up (some to Twitter, some to other pub types also) - have AC list populated with a mix of verified and non-verified sites - Upgrade to 1.17.x (version with Twitter Greaselion tipping) - confirm all data is preserved on brave://rewards - Confirm if you navigate to the various publishers and open the panel, the AC % is preserved (if publisher is part of AC list), the recurring tip amount is preserved (if set up). Confirm panel shows expected information (favicon if applicable, publisher name, etc). Confirm custom tip banner is available (if applicable). - For an existing recurring tip, confirm you are able to adjust the recurring tip amount for Twitter publisher from the panel - For an existing recurring tip, confirm you are able to delete a recurring tip for Twitter publisher Note - due to https://github.com/brave/brave-browser/issues/4557 verified twitter publishers will still show the generic twitter favicon after upgrade. This will be resolved when https://github.com/brave/brave-browser/issues/6059 is resolved.Accessing twitter via a deep link
The panel showed the expected twitter user's info: Verification passed on
Brave | 1.17.52 Chromium: 86.0.4240.111 (Official Build) dev (64-bit)
-- | --
Revision | b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS | Windows 10 OS Version 1903 (Build 18362.1139)
we should switch to GL for Twitter so that we can have faster turn around rate when something breaks.