brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.58k stars 2.28k forks source link

[Desktop] Web Extension Inconsistency. Simple / Mystery #11593

Open ImprovedTube opened 4 years ago

ImprovedTube commented 4 years ago

Description

A simple Extension feature wont work consistently for no apparent reason, as it works in Google Chrome in every OS
Our themes working in Brave are same to those that dont work. https://github.com/ImprovedTube/ImprovedTube/issues/521

Steps to Reproduce

Enable Improvedtube Youtube Themes: https://chrome.google.com/webstore/detail/improve-youtube-open-sour/bnomihfieiccainjcjblhegjgglakjdd Edit: Only Desert & Plain don't work. Thats the Mystery

Actual result: -

Expected result:

Themes all working in exactly the same way. (Night, Dawn, Sunset, Desert, Plain, Black. (Except 'Dark', which refers to Youtube's night mode )

Reproduces how often:

always

Brave version (brave://version info)

84.0.4147.89 - 84.0.4147.135

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

rebron commented 3 years ago

@ImprovedTube Are you still seeing this issue with 1.15.75 Chromium 86?

rebron commented 3 years ago

@ImprovedTube Looks like this is working except for maybe two of the styles? Please add some information on expected outcome, if you'd like us to take a look.

Screen Shot 2020-10-16 at 9 35 06 AM
ImprovedTube commented 3 years ago

thank you @rebron !
did you click all themes, desert, plain? happens in Opera too according to our user. "it doesn't seem to be fixed on my end" https://i.vgy.me/Iw9Jms.webm
"Tested on the latest versions of Opera GX and Brave, on Windows 10 Home. Also tested on Ubuntu 20.04 with Brave." ( https://github.com/ImprovedTube/YouTube/issues/521#issuecomment-711478382 )