[Desktop] macOS unfocused window minor UI polish issues

dndrsn commented 4 years ago

Description

On macOS, when a Brave window does not have focus, there are a couple minor UI issues:

the window "stoplight" buttons are almost imperceptible
the bookmark URL bar icon does not show the "unfocused" state consistent to the other icons next to it

Steps to Reproduce

Open a Brave browser window
Focus on another application or another Brave browser window with the previous window still visible

Actual result:

Notice that the stoplights have almost no contrast with the window chrome.
Also notice that the bookmark icon is not "dimmed" like the others

Expected result:

For the "stoplight" buttons something more like the OS default: or like Chrome:

For the bookmarks button, the same lower contrast styling as other buttons.

Reproduces how often:

Easily, always.

Brave version (brave://version info)

1.13.86 Chromium: 85.0.4183.102 (Official Build) (64-bit)

Version/Channel Information:

Can you reproduce this issue with the current release? Yes
Can you reproduce this issue with the beta channel? Unknown
Can you reproduce this issue with the nightly channel? Unknown

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields? N/A (no)
Does the issue resolve itself when disabling Brave Rewards? N/A (no)
Is the issue reproducible on the latest version of Chrome? N/A (no)

Miscellaneous Information:

rebron commented 4 years ago

@dndrsn What macOS version are you on? I think we're seeing this same issue on Catalina 10.15.7. I'm not seeing the same on Big Sur though.

dndrsn commented 4 years ago

@rebron I am currently using Catalina 10.15.7.

kjozwiak commented 4 years ago

@rebron I am currently using Catalina 10.15.7.

Seeing the same on my machine which is on Catalina 10.15.7 as well. Example:

It's really hard to see the buttons on Brave once it's backgrounded compared to the other applications. Sounds like it was possible fixed/addressed in Big Sur as per @rebron's above comment.

@LaurenWags when you have a few minutes, mind checking to see if you're seeing the same thing on Mojave?

LaurenWags commented 3 years ago

@kjozwiak reproduces on Mojave, dark theme looks better than light theme, but both have the Bookmark icon non-dimmed.

Light theme:

Dark theme:

Brave	1.16.68 Chromium: 86.0.4240.111 (Official Build) (x86_64)
Revision	b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS	macOS Version 10.14.6 (Build 18G6032)

brave / brave-browser