brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.89k stars 2.34k forks source link

Add reader more/option to distill page for sites not classified with speedreader #11994

Open rebron opened 4 years ago

rebron commented 4 years ago

Description

Speedreader targets specified top news sites and therefore doesn't provide the ability to distill any page. We should provide an option for users to "reader mode" any page. When a user visits a page, toggling on reader mode should transform the page into a more readable format.

Design

[placeholder]

Desktop Brave version:

n/a

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

bsclifton commented 4 years ago

+1 from Reddit via https://www.reddit.com/r/BATProject/comments/jcd18o/im_brian_clifton_vp_of_engineering_at_brave_ask/g92ej15/

demeralde commented 4 years ago

The speed reader mode doesn't even work for me. It doesn't transform the pages. I expected something decent like Firefox has. This is something I use all the time for reading content.

I also think the button for this should be displayed openly by default, like Firefox does. You shouldn't have to go to the advanced browser settings and manually enable it. Or at the very least, add it to the normal settings interface.

bsclifton commented 4 years ago

@dspacejs it only works for a few specific sites at the moment, unfortunately. I believe the allow-list we check against is found here: https://github.com/brave-experiments/SpeedReader/blob/master/data/SpeedReaderConfig.json

Is there a specific site you're visiting that you'd like to use Speedreader on? cc: @jonathansampson

kf6nux commented 3 years ago

I'm not sure if this is the right issue to comment on.

@bsclifton I think it's better to err on the side of over-offering distill/reader modes and allow folks to fall back if content is rendered poorly. Generally speaking (in Firefox), Reader mode makes nearly all sites better. Additionally, Reader mode can be thought of as an accessibility feature (many sites are rendered so poorly, some are unreadable without it).

If the Brave team needs to get some data on the scope of the potential impact, could it collect 4 pieces of telemetry? (reader offered by: Brave, Firefox, Both, Neither). That data can be collected in a privacy respecting way (as URLs could be omitted entirely). It could even be reduced to rounded percentages to omit unique site visits.

Subjectively, it feels like Brave doesn't offer me a Reader view nearly as often as FF, but data could prove me wrong.

FWIW, I love the idea of reader mode being the default view of pages where its supported.