brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.74k stars 2.32k forks source link

[Desktop] updated supported fiat currency for Bitcoin.com widget #12016

Closed rebron closed 4 years ago

rebron commented 4 years ago

Description

List of supported fiat currency should be the following:

AUD - Australian Dollar BGN - Bulgarian Lev CAD - Canadian Dollar CHF - Swiss Franc CNY - Chinese Yuan COP - Colombia Peso CZK - Czech Koruna DKK - Danish Krone DOP - Dominican Peso EGP - Egyptian Pound EUR - Euro GBP - Pound Sterling HKD - Hong Kong Dollar HRK - Croatian Kuna IDR - Indonesian Rupiah ILS - Israeli New Shekel JPY - Japanese Yen JOD - Jordanian Dollar KES - Kenyan Shilling KRW - South Korean Won KWD - Kuwaiti Dinar LKR - Sri Lankan Rupee MAD - Moroccan Dirham MXN - Mexican Peso MYR - Malaysian Ringgit NGN - Nigerian Naira NOK - Norwegian Krone NZD - New Zealand Dollar OMR - Omani Rial PEN - Peruvian Sol PKR - Pakistanee Rupee PLN - Polish Złoty RON - Romanian Leu RUB - Russian Ruble SEK - Swedish Krona SGD - Singapore Dollar THB - Thai Baht TRY - Turkish Lira TWD - Taiwan Dollar USD - US Dollar VND - Vietnamese Dong ZAR - South African Rand

per: https://support.moonpay.io/hc/en-gb/articles/360011931457-Which-fiat-currencies-are-supported-

Steps to Reproduce

  1. Go to New Tab page
  2. Go to Bitcoin.com cryptowidget
  3. Go to pull down menu in Enter Amount for currencies and observe list of currencies.

Actual result:

Capture Includes other currencies in that list and excludes others.

https://github.com/brave/brave-core/blob/7b754feee6cf1eaa4e593e116f12878b77717f42/components/brave_new_tab_ui/components/default/bitcoinDotCom/fiat.ts

Expected result:

List in description.

Reproduces how often:

Brave version (brave://version info)

Brave 1.15.71 Chromium: 86.0.4240.72 (Official Build) (64-bit)
Revision 581582174c512f44f44fd1aea340471f54b2365f-refs/branch-heads/4240@{#1134}
OS Windows 10 OS Version 2004 (Build 19041.508)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

kjozwiak commented 4 years ago

Moving into https://github.com/brave/brave-browser/milestone/135 as this is release/blocking.

srirambv commented 4 years ago

Verification passed on

Brave 1.15.72 Chromium: 86.0.4240.75 (Official Build) (64-bit)
Revision c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS Linux
Verified supported list of fiat currency is as per the list in issue description ![image](https://user-images.githubusercontent.com/17010094/95342230-1df7a500-08af-11eb-9f21-b5450ad31bd2.png)
HTML output ```html
AUD
Australian dollar
BGN
Bulgarian lev
CAD
Canadian dollar
CHF
Swiss franc
CNY
Chinese yuan
COP
Colombia peso
CZK
Czech Koruna
DKK
Danish krone
DOP
Dominican peso
EGP
Egyptian pound
EUR
Euro
GBP
Pound sterling
HKD
Hong Kong dollar
HRK
Croatian kuna
IDR
Indonesian rupiah
ILS
Israeli new shekel
JPY
Japanese yen
JOD
Jordanian dollar
KES
Kenyan shilling
KRW
South Korean won
KWD
Kuwaiti dinar
LKR
Sri Lankan rupee
MAD
Moroccan dirham
MXN
Mexican peso
MYR
Malaysian ringgit
NGN
Nigerian naira
NOK
Norwegian krone
NZD
New Zealand dollar
OMR
Omani rial
PEN
Peruvian sol
PKR
Pakistanee rupee
PLN
Polish złoty
RON
Romanian leu
RUB
Russian ruble
SEK
Swedish krona
SGD
Singapore dollar
THB
Thai baht
TRY
Turkish lira
TWD
Taiwan dollar
USD
United States dollar
VND
Vietnamese đồng
ZAR
South African rand
```

Verification passed on

Brave 1.15.72 Chromium: 86.0.4240.75 (Official Build) (64-bit)
Revision c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS Windows 10 OS Version 1809 (Build 17763.1490)
Verified supported list of fiat currency is as per the list in issue description ![image](https://user-images.githubusercontent.com/17010094/95343485-81ce9d80-08b0-11eb-9f66-f7e37fee0e2d.png)
HTML output ```html
AUD
Australian dollar
BGN
Bulgarian lev
CAD
Canadian dollar
CHF
Swiss franc
CNY
Chinese yuan
COP
Colombia peso
CZK
Czech Koruna
DKK
Danish krone
DOP
Dominican peso
EGP
Egyptian pound
EUR
Euro
GBP
Pound sterling
HKD
Hong Kong dollar
HRK
Croatian kuna
IDR
Indonesian rupiah
ILS
Israeli new shekel
JPY
Japanese yen
JOD
Jordanian dollar
KES
Kenyan shilling
KRW
South Korean won
KWD
Kuwaiti dinar
LKR
Sri Lankan rupee
MAD
Moroccan dirham
MXN
Mexican peso
MYR
Malaysian ringgit
NGN
Nigerian naira
NOK
Norwegian krone
NZD
New Zealand dollar
OMR
Omani rial
PEN
Peruvian sol
PKR
Pakistanee rupee
PLN
Polish złoty
RON
Romanian leu
RUB
Russian ruble
SEK
Swedish krona
SGD
Singapore dollar
THB
Thai baht
TRY
Turkish lira
TWD
Taiwan dollar
USD
United States dollar
VND
Vietnamese đồng
ZAR
South African rand
```

Verification passed on

Brave 1.15.72 Chromium: 86.0.4240.75 (Official Build) (x86_64)
Revision c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS macOS Version 10.15.7 (Build 19H2)
Verified supported list of fiat currency is as per the list in issue description ![image](https://user-images.githubusercontent.com/17010094/95344573-b131da00-08b1-11eb-9440-c4345b138946.png)
HTML output ```html
AUD
Australian dollar
BGN
Bulgarian lev
CAD
Canadian dollar
CHF
Swiss franc
CNY
Chinese yuan
COP
Colombia peso
CZK
Czech Koruna
DKK
Danish krone
DOP
Dominican peso
EGP
Egyptian pound
EUR
Euro
GBP
Pound sterling
HKD
Hong Kong dollar
HRK
Croatian kuna
IDR
Indonesian rupiah
ILS
Israeli new shekel
JPY
Japanese yen
JOD
Jordanian dollar
KES
Kenyan shilling
KRW
South Korean won
KWD
Kuwaiti dinar
LKR
Sri Lankan rupee
MAD
Moroccan dirham
MXN
Mexican peso
MYR
Malaysian ringgit
NGN
Nigerian naira
NOK
Norwegian krone
NZD
New Zealand dollar
OMR
Omani rial
PEN
Peruvian sol
PKR
Pakistanee rupee
PLN
Polish złoty
RON
Romanian leu
RUB
Russian ruble
SEK
Swedish krona
SGD
Singapore dollar
THB
Thai baht
TRY
Turkish lira
TWD
Taiwan dollar
USD
United States dollar
VND
Vietnamese đồng
ZAR
South African rand
```