Wallet Connect link seems to be broken in CryptoWallet after upgrade

Genysys commented 3 years ago

Description

After the last upgrade the wallet connect link seems to be broken. As opposed to opening the wallet, it navigates to a blank page.

Steps to reproduce

Go to uniswap https://app.uniswap.org/
Select Connect Wallet
Select Wallet Connect

Actual result

Navigates to a blank page

Expected result

Connects to Brave CryptoWallet

Issue reproduces how often

Version/Channel Information:

Can you reproduce this issue with the current Play Store version?

N/A

Can you reproduce this issue with the current Play Store Beta version?

N/A

Can you reproduce this issue with the current Play Store Nightly version?

N/A

Device details

Install type (ARM, x86):
Device type (Phone, Tablet, Phablet): Phone
Android version: Pixel 2

Brave version

Website problems only

Does the issue resolve itself when disabling Brave Shields?
Does the issue resolve itself when disabling Brave Rewards?
Is the issue reproducible on the latest version of Chrome?

Additional information

srirambv commented 3 years ago

There is no support for crypto wallet on Android yet or support for extensions.

kyleoliveiro commented 3 years ago

This used to work though. It was recently broken.

kyleoliveiro commented 3 years ago

To clarify:

Previously, having both Brave and Metamask installed on an Android phone, when clicking on a Wallet Connect link in Brave browser, it would open the Metamask app and prompt for permission to connect to the site.

Currenty, this no longer works. Instead, clicking on a Wallet Connect link now just opens a blank screen as described above by @Genysys.

ryanml commented 3 years ago

cc: @ryanbr - for any potential web compat issue here

ryanbr commented 3 years ago

Yeah, Seeing an intermittent blank page on load. Rolled out a possible fix.

https://github.com/easylist/easylist/commit/86b893c4c7f137e5cb63e4881195b355382c07dd

brave / brave-browser