brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.96k stars 2.35k forks source link

Default search engine shows wrong favicons #12116

Open Miyayes opened 4 years ago

Miyayes commented 4 years ago

Description

When using the default search engine in the omnibar, the favicon is incorrect. For example, a Bing search will show a Domino's Pizza favicon. See here for screenshot and report: https://www.reddit.com/r/brave_browser/comments/ja9psf/does_anyone_know_why_the_dominos_pizza_symbol/

See here for another similar report: https://www.reddit.com/r/brave_browser/comments/j86y5w/favicon_for_bing_as_default_search_engine_broken/

image

image

Expected result

Favicon should correspond to the correct website/search engine.

underling3311 commented 4 years ago

How do you have 216 BATS, how long did take you to get that?

bsclifton commented 4 years ago

Guessing this is related to OpenSearch - it might be showing what the last added entry was (instead of the default entry)

Miyayes commented 4 years ago

+1 https://www.reddit.com/r/brave_browser/comments/jf41vr/why_is_the_us_navys_symbol_in_my_address_bar/

Brave-Matt commented 4 years ago

+1 from Community: https://community.brave.com/t/a-icon-appearing-in-url-bar-when-typing/171315/13

christopherreay commented 3 years ago

I have the "very" high interest credit consumer goods company logo showing up whenever I am searching. it's violating my space quite a lot actually.

I switched to Google search engine, and the logo went to Google. switching back to duck duck go, the logo switched back to very

justinmcgrath commented 3 years ago

I don't know if it helps, but I had the same issue and the favicon for duckduckgo.com itself was wrong. "Settings-> Site settings -> All sites -> duckduckgo.com -> Clear & reset" fixed it temporarily. It's not a solution, but maybe that helps sort out the problem.

christopherreay commented 3 years ago

thanks :)

On Sun, 3 Jan 2021, 03:21 Justin McGrath, notifications@github.com wrote:

I don't know if it helps, but I had the same issue and the favicon for duckduckgo.com itself was wrong. "Settings-> Site settings -> All sites -> duckduckgo.com -> Clear & reset" fixed it temporarily. It's not a solution, but maybe that helps sort out the problem.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/brave/brave-browser/issues/12116#issuecomment-753561903, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB2PPVCN7WV3Q4XZP3AYSDSX7PEHANCNFSM4SPX7QHA .

christopherreay commented 3 years ago

So this is an issue that sites are able, somehow, to overwrite the favicon logo for duckduckgo.

Is this

  1. because duckduckgo are selling that (seems unlikely)
  2. because the "invading" site has somehow convinced the browser to use its favicon rather than the correct one (seems about equally unlikely)
  3. or because there is no actual favicon for duckduckgo and some random site ends up taking the place?

Any ideas? I want to stress Im very sensitive to have my life invaded by advertising I dont choose to see, and Very is a predatory organisation that is totally at odds with the culture of duckduckgo. I realise this is almost certainly random chance, but it should be reasonably easy to fix. Where we can fix things like this in the world, I think we should. Brave is on board with that as far as I can see :+1

ghost commented 3 years ago

I made one of the original posts on Reddit. Every few weeks the favicon changes. My most recent one on Bing.

I saw this post today on /r/chrome, so it could be an issue in Chromium.

Screenshot_20210116-091459