Launcher directory for Brave Apps has incorrect name on Linux

chrisx8 commented 4 years ago

Description

On Linux, the xdg desktop directory for shortcuts to Brave/Chromium Apps (brave://apps) is "Brave Browser Development Apps", while the equivalent Start Menu folder is named "Brave Apps."

Chromium always names the directory for Chromium Apps shortcuts as "Chromium Apps" on all desktop platforms. For this feature, Brave behaves like Chromium on Windows, but not on Linux.

Steps to Reproduce

Do the following using Brave on Linux

Open any website
Menu -> More tools -> Create shortcut...
Check "Open as window"

Actual result:

Content of ~/.local/share/desktop-directories/chrome-apps.directory, as generated by Brave:

[Desktop Entry]
Version=1.0
Type=Directory
Name=Brave Browser Development Apps
Icon=brave-browser

Expected result:

Expected content of ~/.local/share/desktop-directories/chrome-apps.directory:

[Desktop Entry]
Version=1.0
Type=Directory
Name=Brave Apps
Icon=brave-browser

Reproduces how often:

Easily reproducible when installing PWA or creating shortcut to website.

Brave version (brave://version info)

Brave version: Version 1.15.76 Chromium: 86.0.4240.111 (Official Build) unknown (64-bit) OS: Arch Linux Brave is installed using brave-bin on the AUR.

Version/Channel Information:

Can you reproduce this issue with the current release? Yes.
Can you reproduce this issue with the beta channel? Yes.
Can you reproduce this issue with the nightly channel? Yes.

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields? No. Issue is not relevant to Brave Shields.
Does the issue resolve itself when disabling Brave Rewards? No. Issue is not relevant to Brave Rewards.
Is the issue reproducible on the latest version of Chrome? No. This issue doesn't exist on Chromium (from Arch repo) or Google Chrome.

rebron commented 3 years ago

cc: @srirambv

ghost commented 11 months ago

Brave and Chrome are fighting over the chrome-apps.directory file on my (Manjaro/XFCE) machine. First the Name inside of it was Brave Browser Apps then after some updates, Chrome renamed it to Chrome Apps and then after I installed a PWA with Brave it got named Brave Browser Development Apps which was so hideously long that it triggered me to find all of the surrounding issues and subscribe to them.

Shouldn't Brave be using a brave-apps.directory file anyway?

brave / brave-browser