brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.73k stars 2.31k forks source link

"Automatically redirect .onion site" setting does not work in Guest windows #12644

Open LaurenWags opened 3 years ago

LaurenWags commented 3 years ago

Description

Found while testing https://github.com/brave/brave-browser/issues/806

If "Automatically redirect .onion site" is toggled on in settings and you visit brave.com in a normal or private window, a Tor window is opened and automatically navigated to the onion site for Brave. If you do this in a guest window, you get the "Open in Tor" option in the URL bar, you are not automatically navigated.

Steps to Reproduce

From https://github.com/brave/brave-core/pull/6762, Automatically redirect .onion site TC

  1. Go to brave://settings/extensions
  2. Toggle on "Automatically redirect .onion site"
  3. In a Normal or Private window navigate to brave.com
  4. https://brave5t5rjjg3s6k.onion will be opened in Tor window (if the tab from step 3 is not the only tab in the window, it will be closed)
  5. Close Tor Window.
  6. Open guest window
  7. Navigate to brave.com

Actual result:

Guest

Expected result:

Automatically navigated to brave onion site in Tor window.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.17.67 Chromium: 87.0.4280.49 (Official Build) unknown (x86_64)
Revision f77f85899646b42a1d3c8ff36794e00becab9171-refs/branch-heads/4280@{#1115}
OS macOS Version 10.14.6 (Build 18G6032)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

darkdh commented 3 years ago

The setting of guest window is different than regular profile, so the setting you just changed doesn't affect guest window. You can open settings page from guest window and we don't expose the auto redirect onion setting to guest window