brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.9k stars 2.34k forks source link

Yandex updates for Android #12862

Closed bsclifton closed 3 years ago

bsclifton commented 3 years ago

Description

Similar to https://github.com/brave/brave-browser/issues/12327 - but for Android.

  1. Yandex should show in onboarding if user is in the regions listed in https://github.com/brave/brave-browser/issues/12327. Desktop is doing this already - I believe on Android side we need to edit the code to use the pre-populated lists (or update the differing pre-populated lists)

  2. Images to use for onboarding can be found here: icons.zip

deeppandya commented 3 years ago

Screenshot_20201125-154721

LaurenWags commented 3 years ago

Verified passed on LG Nexus 5 with Android 5.1 running 1.18.69 Bravearm.apk

Verified test cases outlined under https://github.com/brave/brave-core/pull/7258#issuecomment-736967479 for the following languages:

  1. Armenian (Republic of Armenia)
  2. Russian (spoken in Republic of Belarus, Kyrgyz Republic, Republic of Kazakhstan, Russian Federation, Republic of Tajikistan, Turkmenistan, Republic of Uzbekistan)
Armenian Russian
Armenian Russian

Unable to confirm the above for the following as my device does not have these languages:

  1. Azerbaijani (Republic of Azerbaijan)
  2. Belarusian (Republic of Belarus)
  3. Kyrgyz (Kyrgyz Republic)
  4. Kazakh (Republic of Kazakhstan)
  5. Moldovan (Republic of Moldova)
  6. Tajiki (Republic of Tajikistan)
  7. Turkmen (Turkmenistan)
  8. Uzbek (Republic of Uzbekistan)