Update icons for macOS - Githubissues

rebron commented 3 years ago

Description

Update icons for macOS Big Sur similar to iOS/rounded square icons to be consistent with other apps on macOS

Actual result:

88846180-dcf65c80-d1aa-11ea-901b-67a113d40a5a

Expected result:

Icons should be a little larger than the previous round and have a white background.

Iconsets: In gdrive

Reproduces how often:

n/a

Brave version (brave://version info)

Target for 1.19.x

Version/Channel Information:

Can you reproduce this issue with the current release? yes
Can you reproduce this issue with the beta channel? yes
Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields? n/a
Does the issue resolve itself when disabling Brave Rewards? n/a
Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

First try with https://github.com/brave/brave-browser/issues/11002 but icons came out to small. Using this issue as follow-up.

simonhong commented 3 years ago

It would be good to have new icon for development build (grayed one) also.

karenkliu commented 3 years ago

@simonhong Designs added! I included the development build too.

stephendonner commented 3 years ago

This is looking good on macOS Big Sur (11.1 (20C69)), for the following icons:

Brave Beta

Brave	1.20.85 Chromium: 88.0.4324.96 (Official Build) beta (x86_64)
Revision	68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS	macOS Version 11.1 (Build 20C69)

Brave Dev

Brave	1.20.88 Chromium: 88.0.4324.96 (Official Build) dev (x86_64)
Revision	68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS	macOS Version 11.1 (Build 20C69)

Brave Nightly

Brave	1.20.90 Chromium: 88.0.4324.96 (Official Build) dev (x86_64)
Revision	68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS	macOS Version 11.1 (Build 20C69)

Still pending:

Looks like we'll need a Release Preview/Release Candidate to verify on the Release channel
Also need someone with a (self-built?) developer binary to show theirs, using Big Sur
Probably a good idea for someone with Catalina to post theirs, as they shouldn't have changed there

LaurenWags commented 3 years ago

@stephendonner your Brave Nightly is old (1.19.x) - best to try on the latest Nightly from https://github.com/brave/brave-browser/releases.

I noticed because your Nightly icon has a dark background whereas mine does not - and per the description each icon should have a white background. So, please give it another check on a updated Nightly. If you continue to have a dark background on your icon we'll want to follow up on that.

LaurenWags commented 3 years ago

Verified passed with the following versions using macOS x64 Catalina:

Brave | 1.20.100 Chromium: 88.0.4324.146 (Official Build) (x86_64)
-- | --
Revision | 406dc88511162d6598242f2c709be1414a042fb0-refs/branch-heads/4324@{#2088}
OS | macOS Version 10.15.7 (Build 19H15)

Brave | 1.21.44 Chromium: 88.0.4324.146 (Official Build) beta (x86_64)
-- | --
Revision | 406dc88511162d6598242f2c709be1414a042fb0-refs/branch-heads/4324@{#2088}
OS | macOS Version 10.15.7 (Build 19H15)

Brave | 1.21.45 Chromium: 88.0.4324.146 (Official Build) dev (x86_64)
-- | --
Revision | 406dc88511162d6598242f2c709be1414a042fb0-refs/branch-heads/4324@{#2088}
OS | macOS Version 10.15.7 (Build 19H15)

Brave | 1.22.2 Chromium: 88.0.4324.146 (Official Build) nightly (x86_64)
-- | --
Revision | 406dc88511162d6598242f2c709be1414a042fb0-refs/branch-heads/4324@{#2088}
OS | macOS Version 10.15.7 (Build 19H15)

Verified passed with the following versions using macOS arm64 Big Sur:

Brave   1.20.100 Chromium: 88.0.4324.146 (Official Build) (arm64)
Revision    406dc88511162d6598242f2c709be1414a042fb0-refs/branch-heads/4324@{#2088}
OS  macOS Version 11.2 (Build 20D64)

Brave   1.21.44 Chromium: 88.0.4324.146 (Official Build) beta (arm64)
Revision    406dc88511162d6598242f2c709be1414a042fb0-refs/branch-heads/4324@{#2088}
OS  macOS Version 11.2 (Build 20D64)

Brave   1.21.45 Chromium: 88.0.4324.146 (Official Build) dev (arm64)
Revision    406dc88511162d6598242f2c709be1414a042fb0-refs/branch-heads/4324@{#2088}
OS  macOS Version 11.2 (Build 20D64)

Brave   1.22.2 Chromium: 88.0.4324.146 (Official Build) nightly (arm64)
Revision    406dc88511162d6598242f2c709be1414a042fb0-refs/branch-heads/4324@{#2088}
OS  macOS Version 11.2 (Build 20D64)

Development build icon was confirmed for QA by @darkdh and @iefremov:

thaliaarchi commented 3 years ago

I appreciate that this follows the design changes introduced by Chrome, but is there a flag to disable this? It is incongruous with the other icons in my dock and the white space bugs me. There are many common non-square icons: Firefox, VS Code, Messages, and many non-aligned icons including Mail, Notes, and Pages.

zevrix commented 3 years ago

Please give us an option to restore the original icon.

Brave's original icon is a masterpiece. There's no need to change anything. The new icon just looks as a mistake.

If you really just have to follow this shape while keeping an impressive icon, then this would be much better:

brave-icon

tre-dev commented 3 years ago

I guess the look depends on the taste of the individual user, the icons next to it and possibly also the alignment of the dock. For me, the new version doesn't fit at all, it looks rather ugly tbh :/