search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
16.99k stars 2.21k forks source link

Implement p3a-internals page for ease of testing #13069

Open iefremov opened 3 years ago

iefremov commented 3 years ago

Often P3A users do not understand how to test whether their metric is properly recorded. Currenlty, the handiest way is to check brave::/local-state where p3a services saves its state. We can add a more descriptive "internals" page that would have a human-readable timestamp, list of all (even never observed) metrics, (less important) ability to observe and reset "sent status", timers, etc.

suraj10k commented 3 years ago

Can I work I this issue ?

bsclifton commented 3 years ago

@suraj10k sure thing! Please be aware it can be a big task, but there are some great examples to check out. You'll want to make a new internal page with a route like brave://p3a-internals

Start off by pulling down the source and building https://github.com/brave/brave-browser/blob/master/README.md

Once you get that up, you should be able to look at the source for any of the Chromium pages in brave://chrome-urls/. Once you get something up and running (even if you edit the Chromium source directly) we can help you convert that to a patch or override to clean things up

iefremov commented 3 years ago

@suraj10k you may start with something very similar to local_state_ui.cc and then expand it to be more P3A-specific and user-friendly

suraj10k commented 3 years ago

@suraj10k sure thing! Please be aware it can be a big task, but there are some great examples to check out. You'll want to make a new internal page with a route like brave://p3a-internals

Start off by pulling down the source and building https://github.com/brave/brave-browser/blob/master/README.md

Once you get that up, you should be able to look at the source for any of the Chromium pages in brave://chrome-urls/. Once you get something up and running (even if you edit the Chromium source directly) we can help you convert that to a patch or override to clean things up

hey , as im new to open source contributions i was hoping you could help me setup the environment , i have forked and cloned the project, but when i try to build it im getting issues , is there any other platform where i can contact you ?

mahir-anand commented 1 year ago

@suraj10k sure thing! Please be aware it can be a big task, but there are some great examples to check out. You'll want to make a new internal page with a route like brave://p3a-internals Start off by pulling down the source and building https://github.com/brave/brave-browser/blob/master/README.md Once you get that up, you should be able to look at the source for any of the Chromium pages in brave://chrome-urls/. Once you get something up and running (even if you edit the Chromium source directly) we can help you convert that to a patch or override to clean things up

hey , as im new to open source contributions i was hoping you could help me setup the environment , i have forked and cloned the project, but when i try to build it im getting issues , is there any other platform where i can contact you ?

Hey, I was wondering if you still need any help? I am not an expert but might be able to help you setup the environment.