brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.88k stars 2.34k forks source link

[Feature Request] Media Controls for Picture-In-Picture #13380

Open Mennaruuk opened 3 years ago

Mennaruuk commented 3 years ago

Description

Brave Browser can have a more powerful PIP experience by implementing media controls. The way it would work is that only when the PIP window is clicked/selected can media controls work. So, the right arrow button would past forward, maybe, five seconds. Left arrow button would move video backwards five seconds. Up arrow button would increase volume and down arrow button would decrease volume. This is the way it works in Firefox right now.

Steps to Reproduce

  1. Enter into PIP mode of any video.
  2. Click on the PIP window.
  3. Click on any of the arrow buttons to adjust volume and time as you please.

Actual result:

Neither volume nor time changes.

Expected result:

Volume should change when clicking up arrow or down arrow buttons. Time should change when clicking right arrow or left arrow buttons.

Reproduces how often:

Always.

Brave version (brave://version info)

1.18.77

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

Brave is awesome.

MidlajYH commented 1 year ago

Any update on this? 🤔