Closed moritzhaller closed 3 years ago
Verified using the test plan in https://github.com/brave/brave-core/pull/7533 with additional contextual details, from @moritzhaller and @tmancey (and thx to @btlechowski for pro-tips, too!)
Brave | 1.20.97 Chromium: 88.0.4324.96 (Official Build) dev (x86_64) |
---|---|
Revision | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784} |
Case 1: Default models enabled (Text Classification and Purchase Intent)
Used --args --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=6,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true,reconcile-interval=5
Case 2: Variant models enabled (Epsilon Greedy Bandit and Purchase Intent: --disable-features="TextClassification" --enable-features="EpsilonGreedyBandit"
)
Used --args --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=6,"*/brave_user_model/*"=6 --brave-ads-debug --disable-features="TextClassification" --enable-features="EpsilonGreedyBandit"
Case 3: Restart after one round of training and make sure state wasn't deleted in user Preferences JSON key epsilon_greedy_bandit_arms
In addition to the details below, I verified that the pulls
and values
data persisted between sessions/restarts of the browser, and were accurately reflected via brave://rewards
7-day History panel.
Used --args --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=6,"*/brave_user_model/*"=6 --brave-ads-debug --disable-features="TextClassification" --enable-features="EpsilonGreedyBandit"
Verification passed on
Brave | 1.20.97 Chromium: 88.0.4324.96 (Official Build) dev (64-bit) |
---|---|
Revision | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784} |
OS | Ubuntu 18.04 LTS |
Verified using the test plan in https://github.com/brave/brave-core/pull/7533
Default models enabled (Text Classification and Purchase Intent)
Variant models enabled (Epsilon Greedy Bandit and Purchase Intent: --disable-features="TextClassification" --enable-features="EpsilonGreedyBandit"
)
Used --args --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=6,"*/brave_user_model/*"=6 --brave-ads-debug --disable-features="TextClassification" --enable-features="EpsilonGreedyBandit"
Restart after one round of training and make sure state wasn't deleted in user Preferences JSON key epsilon_greedy_bandit_arms
In addition to the details below, I verified that the pulls
and values
data persisted between sessions/restarts of the browser, and were accurately reflected via brave://rewards
7-day History panel.
Verification passed on
Brave | 1.20.100 Chromium: 88.0.4324.146 (Official Build) (64-bit)
-- | --
Revision | 406dc88511162d6598242f2c709be1414a042fb0-refs/branch-heads/4324@{#2088}
OS | Windows 10 OS Version 2004 (Build 19041.746)
pulls
and values
data persisted between sessions/restarts of the browser, and were accurately reflected via brave://rewards 7-day History panel.Brave | 1.20.101 Chromium: 88.0.4324.152 (Official Build) (64-bit)
-- | --
Revision | 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS | Windows 10 OS Version 2004 (Build 19041.746)
Case 3: Restart after one round of training and make sure state wasn't deleted in user Preferences JSON key epsilon_greedy_bandit_arms
pull
0 value
1.0pull
1 value
1.0pull
1 value
0.0pull
value is 2
and value
is 0.5
2
and value is 1.0
2
and value is 0.0
Verification passed on OnePlus 6T with Android 10 running 1.20.102 x64 build
Case 1: Default models enabled (Text Classification and Purchase Intent)
Used --args --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=6,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true,reconcile-interval=5
Exploring epsilon greedy bandit segments: ...
or Exploiting epsilon greedy bandit segments: ...
Case 2: Variant models enabled
--enable-logging=stderr --vmodule="*/bat-native-ads/*"=9,"*/brave_ads/*"=9,"*/brave_user_model/*"=9,"*/bat_ads/*"=9 --brave-ads-staging --rewards=staging=true --disable-features="TextClassification" --enable-features="EpsilonGreedyBandit"
best bitcoin lending sites
and ensured purchase intent for Keywords are working as expected
Exploring epsilon greedy bandit segments: ...
or Exploiting epsilon greedy bandit segments: ...
Labelling as
Android
as per confirmation from @tmancey & @moritzhaller from today's meeting thatepsilon greedy bandit classifier
will also be onAndroid
. Also, https://github.com/brave/brave-browser/issues/12595 was labelled withOS/Android
as well.