brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.64k stars 2.3k forks source link

Stripe javascript SDK is getting blocked #13564

Open dorlandimort opened 3 years ago

dorlandimort commented 3 years ago

Description

Recently, I have received a lot of messages through customer support telling me that they cannot subscribe to my product using my webpage, after asking more questions the constant was always that those users that cannot subscribe are using Brave Browser.

Steps to Reproduce

  1. Navigate to any site that accepts payments through Stripe let's say the React Stripe Elements examples page
  2. Open the developer tools and you will see a lot of messages telling you that g.stripe was blocked.

Actual result:

Navigating to the React Stripe Elements examples page: Screen Shot 2021-01-13 at 16 28 55

Navigating to other sites that use Stripe, this for example Screen Shot 2021-01-13 at 16 42 51

Expected result:

It is expected to let Stripe's scripts work in order to be able to subscribe.

Reproduces how often:

Every time you try to subscribe inside a site that uses Stripe's Javascript SDK

Desktop Brave version:

Fresh install:

Android Device details:

Other Additional Information:

HunterMeyer commented 3 years ago

I'm seeing this as well.

Brave users are unable to purchase things from our website due to this issue.

ryanbr commented 3 years ago

I'm happy to test this, Easyprivacy (and thus Brave) is blocking the stripe events (and also some paypal trackers)

I expect some blocks on stripe.io (from 2018. https://github.com/easylist/easylist/commit/ebead33df9eb7fed8b5b2872a66ad419be158a79)

Here is my test, from a clean Brave profile: https://gif.fanboy.co.nz/gif/stripetest.gif

stripe-debug Further expanded: stripe-debug2

@dorlandimort @HunterMeyer

caniko commented 2 years ago

This is still an issue in 2022! image

ryanbr commented 2 years ago

Is there a example stripe action I can test this? @caniko https://stripe.dev/react-stripe-elements/ seems to be dead link. The orginal issue isn't quite the same as an "Aw Snap" issue in this case though

danielehrhardt commented 2 years ago

Is there a example stripe action I can test this? @caniko https://stripe.dev/react-stripe-elements/ seems to be dead link. The orginal issue isn't quite the same as an "Aw Snap" issue in this case though

Here you can check: https://convert-any.com/pricing

jbl31 commented 1 year ago

Is the Issue fixed? I still have the problem those days with last Brave version.. i desactivated Brave shield and other adblock suites, but still blocking stripe.

image
ryanbr commented 1 year ago

@jbl31 What exactly is the issue? We're not blocking stipe outright.

pneves001 commented 1 year ago

I can confirm that this is an issue. I'm getting the following error that goes away when I disable brave ad blocking. This only happens on the payment pages of my website.

POST https://m.stripe.com/6 net::ERR_BLOCKED_BY_CLIENT

jbl31 commented 1 year ago

@jbl31 What exactly is the issue? We're not blocking stipe outright.

Hello Ryan, thanks for taking the time to answer.

Here is further informations to reproduce the issue:

First, the Brave version is: Brave est à jour Version 1.48.171 Chromium: 110.0.5481.177 (Build officiel) (64 bits)

Second, if i try to go on a website using stripe paiement form, as an example: https://www.grainesnaturelles.com/

Try adding something to the basket from the Shop.

Then click on Basket, you should see this:

image

Then click on "Pay" or "Payer". The stripe form to enter card number should appear.

So, at this stage, the website should have loaded the jsstripe but it doesn't.

I tried on the "Private browser mode too".

I desactivated all Shield or Adblocks things.. (who aren't used in Private mode btw)

And its working on Firefox.

Maybe a problem with a Woocommerce cache extension used by this particular website?

But i also got the problem on other website using Stripe JS library..

For example: racknerd.com

i desactivated my Avast antivirus and shields also to make sure he wasn't blocking it.

Something is still blocking the loading of stripe.

Maybe not the Brave, but it is working on Firefox or Edge

EDIT: Now working on the normal brave version, but the form is still blocked on the Private mode browser. Strange.

ryanbr commented 1 year ago

Try testing in a clean brave profile, Brave beta. No extensions. Noticed 2 extension errors in your screenshot also (maybe related).

jbl31 commented 1 year ago

Try testing in a clean brave profile, Brave beta. No extensions. Noticed 2 extension errors in your screenshot also (maybe related).

image

Seems working, the form appears. So maybe an extension problem. thanks