brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.88k stars 2.34k forks source link

Filter out Olytics' tracking from URLs #13644

Closed fmarier closed 3 years ago

fmarier commented 3 years ago

Olytics uses the following query string parameters in URLs to track individual users:

Here's are some examples found in the wild:

stephendonner commented 3 years ago

Verified FIXED using the testplan from https://github.com/brave/brave-core/pull/7651, on:

Brave 1.21.44 Chromium: 88.0.4324.146 (Official Build) beta (x86_64)
Revision 406dc88511162d6598242f2c709be1414a042fb0-refs/branch-heads/4324@{#2088}
OS macOS Version 11.2 (Build 20D64)
1) Open `https://brave.com/?oly_anon_id=1234` and confirm that there is no `oly_anon_id parameter` in the URL bar.
![image](https://user-images.githubusercontent.com/387249/107296338-04659600-6a26-11eb-97d4-45f19c1b0739.png)
2) Open `https://brave.com/?oly_enc_id=1234` and confirm that there is no `oly_enc_id` parameter in the URL bar.
Screen Shot 2021-02-08 at 3 50 44 PM

Verification passed on

Brave 1.21.56 Chromium: 88.0.4324.152 (Official Build) dev (64-bit)
Revision 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS Ubuntu 18.04 LTS

Verified testplan from https://github.com/brave/brave-core/pull/7651

Open `https://brave.com/?oly_anon_id=1234` and confirm that there is no `oly_anon_id parameter` in the URL bar. ![image](https://user-images.githubusercontent.com/34715963/108085579-c4ca2a00-7075-11eb-9c84-0b2d43d00642.png)
Open `https://brave.com/?oly_enc_id=1234` and confirm that there is no `oly_enc_id` parameter in the URL bar. ![image](https://user-images.githubusercontent.com/34715963/108085656-dad7ea80-7075-11eb-8fee-28165c8d9e5a.png)

Verified the examples from the description


Verified passed with

Brave   1.21.59 Chromium: 88.0.4324.182 (Official Build) beta (64-bit)
Revision    73ee5087001dcef33047c4ed650471b225dd8caf-refs/branch-heads/4324@{#2202}
OS  Windows 10 OS Version 1909 (Build 18363.1256)
Open `https://brave.com/?WickedID=1234` and confirm that there is no `WickedID` parameter in the URL bar. Screen Shot 2021-02-18 at 3 21 25 PM
Open `https://brave.com/?oly_anon_id=1234` and confirm that there is no `oly_anon_id` parameter in the URL bar. Screen Shot 2021-02-18 at 3 22 26 PM
Open `https://brave.com/?oly_enc_id=1234` and confirm that there is no `oly_enc_id` parameter in the URL bar. Screen Shot 2021-02-18 at 3 23 29 PM

Verified the examples from the description as well.

srirambv commented 3 years ago

Verification passed on OnePlus 6T with Android 10 running 1.21.69 x64 build

Verified links from test plan brave/brave-core/pull/7651 https://brave.com/?WickedID=1234 | https://brave.com/?oly_anon_id=1234 | https://brave.com/?oly_enc_id=1234 -- | -- | -- ![image](https://user-images.githubusercontent.com/17010094/109315743-c13b5d80-7842-11eb-93a3-5c7d6da7c844.png) | ![image](https://user-images.githubusercontent.com/17010094/109315782-ce584c80-7842-11eb-937d-b44dc5943f09.png) | ![image](https://user-images.githubusercontent.com/17010094/109315839-e039ef80-7842-11eb-9efe-72f6904a6b55.png)
Links from issue description ![image](https://user-images.githubusercontent.com/17010094/109314740-a6b4b480-7841-11eb-909b-07520e462712.png) | ![image](https://user-images.githubusercontent.com/17010094/109314813-bd5b0b80-7841-11eb-9626-4510c5bf50ac.png) | ![image](https://user-images.githubusercontent.com/17010094/109315064-0612c480-7842-11eb-85b1-4f3f45480ede.png) | ![image](https://user-images.githubusercontent.com/17010094/109315144-1d51b200-7842-11eb-9ac7-b5cc7a4b9367.png) | ![image](https://user-images.githubusercontent.com/17010094/109315209-335f7280-7842-11eb-8d6f-e2eb412be644.png) -- | -- | -- | -- | --

Verification passed on Samsung Tab A with Android 10 running 1.21.69 x64 build

Verified links from test plan brave/brave-core/pull/7651 https://brave.com/?WickedID=1234 | https://brave.com/?oly_anon_id=1234 | https://brave.com/?oly_enc_id=1234 -- | -- | -- ![image](https://user-images.githubusercontent.com/17010094/109317733-e92bc080-7844-11eb-9f85-e0aab56dbde8.png) | ![image](https://user-images.githubusercontent.com/17010094/109317774-f8127300-7844-11eb-9055-a274b1e10aed.png) | ![image](https://user-images.githubusercontent.com/17010094/109317852-124c5100-7845-11eb-9a2c-1e48938b8bd7.png)
Links from issue description ![image](https://user-images.githubusercontent.com/17010094/109318039-49226700-7845-11eb-8756-2fe78869f8da.png) | ![image](https://user-images.githubusercontent.com/17010094/109318107-5b9ca080-7845-11eb-8a1f-d4dd76fb2d98.png) | ![image](https://user-images.githubusercontent.com/17010094/109318215-7a9b3280-7845-11eb-8d4c-b3152cfb085b.png) | ![image](https://user-images.githubusercontent.com/17010094/109318291-8e469900-7845-11eb-9325-59d8b1aa1664.png) | ![image](https://user-images.githubusercontent.com/17010094/109318360-9f8fa580-7845-11eb-831c-7a773ad72e64.png) -- | -- | -- | -- | --