brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.62k stars 2.29k forks source link

<noscript> ignored in HTML #13864

Open Semisol opened 3 years ago

Semisol commented 3 years ago

Description

<noscript> is ignored in HTML pages when a site is blocked from using JS.

Steps to Reproduce

  1. Disable JS for a site
  2. <noscript> is ignored

Actual result:

Nothing

Expected result:

To reload with a meta tag/show noscript content

Reproduces how often:

Easy to reproduce

Brave version (brave://version info)

Brave | 1.19.88 Chromium: 88.0.4324.96 (Official Build) (x86_64)
-- | --
Revision | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS | macOS Version 10.15 (Build 19A583)
JavaScript | V8 8.8.278.14
User Agent | Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.96 Safari/537.36
Command Line | /Applications/Brave Browser.app/Contents/MacOS/Brave Browser --enable-dom-distiller --disable-domain-reliability --no-pings --extension-content-verification=enforce_strict --extensions-install-verification=enforce --origin-trial-public-key=bYUKPJoPnCxeNvu72j4EmPuK7tr1PAC7SHh8ld9Mw3E=,fMS4mpO6buLQ/QMd+zJmxzty/VQ6B1EUZqoCU04zoRU= --sync-url=https://sync-v2.brave.com/v2 --lso-url=https://no-thanks.invalid --variations-server-url=https://variations.brave.com/seed --enable-features=AutoupgradeMixedContent,LegacyTLSEnforced,WebUIDarkMode,ReducedReferrerGranularity,PasswordImport,PrefetchPrivacyChanges --disable-features=SignedExchangeSubresourcePrefetch,TextFragmentAnchor,WebOTP,NotificationTriggers,PasswordCheck,NetworkTimeServiceQuerying,TabHoverCards,AutofillServerCommunication,IdleDetection,AutofillEnableAccountWalletStorage,PrivacySettingsRedesign,SafeBrowsingEnhancedProtection --flag-switches-begin --load-media-router-component-extension=0 --flag-switches-end
Executable Path | /Applications/Brave Browser.app/Contents/MacOS/Brave Browser
Profile Path | /Users/HIDDEN/Library/Application Support/BraveSoftware/Brave-Browser/Default

Version/Channel Information:

Miscellaneous Information:

<!DOCTYPE html>
<html lang="en">
<head>
    <meta charset="UTF-8">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <title>Document</title>
    <noscript>
        <meta http-equiv="refresh" content="0; url=https://example.com/">
    </noscript>
</head>
<body>

</body>
</html>

is my HTML document

Body example:

<!DOCTYPE html>
<html lang="en">
<head>
    <meta charset="UTF-8">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <title>Document</title>

</head>
<body>
    <noscript>
        Test
    </noscript>
</body>
</html>
diracdeltas commented 3 years ago

does the noscript test in https://terrillthompson.com/tests/noscript.html work for you?

Semisol commented 3 years ago

does the noscript test in terrillthompson.com/tests/noscript.html work for you?

Yes, also this issue was reproduced with localhost.

diracdeltas commented 3 years ago

all 3 cases work for me on MacOS (both localhost examples and the remote website). did you disable JS globally or just for a site? (via shields)

Semisol commented 3 years ago

site (preferences)