brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.04k stars 2.22k forks source link

No Picture In Picture button on playing videos #14467

Open SlowNicoFish opened 3 years ago

SlowNicoFish commented 3 years ago

Description

I would love a button on top of a playing video to easily go into PIP mode. Vivaldi and Firefox has this feature and I would like to have it in Brave as well. This feature would make it so much more convenient to get into Picture In Picture mode since i use it almost all of the time.

Steps to Reproduce

  1. Start a video

Actual result:

I see no button for PIP

Expected result:

A little button to pop a video out in PIP-mode

Reproduces how often:

Always

Brave version (brave://version info)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

rebron commented 3 years ago

@SlowNicoFish At the top right corner, there's a global media control UI that will let you get into PIP mode. Does that work for you?

See image below for the control.

Screen Shot 2021-03-05 at 4 14 57 PM
SlowNicoFish commented 3 years ago

It's not really optimal because it throws off the flow i have from other browser with that feature. Vivaldi and Firefox has that feature I think that it really adds to the experience.

rebron commented 3 years ago

An overlay button on the video to get into PIP mode. There is redundancy here since there is a way to get into PIP mode, just not as discoverable.

Screen Shot 2021-05-07 at 3 40 13 PM
Haravikk commented 2 years ago

@SlowNicoFish At the top right corner, there's a global media control UI that will let you get into PIP mode. Does that work for you?

Thanks for mentioning this! I wasn't aware of it at all; I think discoverability is a bit poor as it's not super obvious, despite being super useful.

In my case I'm used to right-clicking (or double right-clicking for sites like YouTube with custom right-click menus) on a video in other browsers to open it in Picture-in-Picture or Fullscreen.

At the very least it might be worth Brave adding PiP/Fullscreen options to the right-click menu for videos? It currently just seems to show the same menu as for anywhere else on the page.

SlowNicoFish commented 2 years ago

Now even Microsoft edge browser has implemented it. @Haravikk Yes, that would be a good solution, not great but good enough. The best would of course be a floating button

Mennaruuk commented 2 years ago

Yup. Edge, Firefox, and Vivaldi have this feature. Brave will be a more perfect browser with this button!

nonokh commented 1 year ago

Please add media scrubber like in Firefox. It makes absolute no sense to go back to tab just to seek 10 secs -/+

SlowNicoFish commented 10 months ago

Yes, the pip functionality needs to be much improved. Take a look at Firefox and Vivaldi for inspiration