search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.56k stars 2.28k forks source link

Moving Unstoppable Domains & ENS resolve settings into wallet settings #14516

Closed yrliou closed 1 year ago

yrliou commented 3 years ago

They're currently under Extensions, might makes more sense in wallet settings. https://github.com/brave/brave-core/pull/8125#discussion_r588818862

rebron commented 3 years ago

cc: @karenkliu

bbondy commented 3 years ago

@rebron @karenkliu How about a new DNS category after IPFS? Either that or under Wallet.

We currently have these 2 settings:

Screen Shot 2021-03-13 at 7 33 44 PM

We'll also likely have another setting for Handshake. And then also a 4th option which asks which provider (if any) to use for resolving non-ICANN TLDs.

karenkliu commented 3 years ago

@bbondy Maybe under Wallet? Have to be wary of being too granular and adding too many sections that don't have much content. Let's think about broader themes these could fit under.

bbondy commented 3 years ago

OK sounds good, I think it's a better fit than under extensions at least 👍

ShivanKaul commented 1 year ago

Let's make sure the ENS L2 resolution setting (in-dev) also gets migrated when this is worked on. We'll also need to update documentation (https://github.com/brave/brave-browser/wiki/ENS-offchain-lookup, or wherever that moves)

supermassive commented 1 year ago

Now we have four rows related to domain resolution in brave://settings/extensions image and this issue blocks sec review https://github.com/brave/security/issues/1099#issuecomment-1335733756

Can we choose a new location for them? 1) Move them to Wallet section. 2) 1 + rename Wallet to smth like Wallet and Web3 3) Move them to a new Web3 section.

@bbondy @bradleyrichter @aguscruiz @ShivanKaul

bbondy commented 1 year ago

I think we should have a web3 settings page and then have different sections, one for wallet, one for decentralized DNS, one for IPFS, etc.

bradleyrichter commented 1 year ago

Mockup for a merger image

ShivanKaul commented 1 year ago

+1

srirambv commented 1 year ago

Verification passed on

Brave 1.48.132 Chromium: 109.0.5414.87 (Official Build) beta (64-bit)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS Linux

https://user-images.githubusercontent.com/17010094/214093013-74f69ec2-63d4-4aa7-8093-bbdb4fe7503c.mp4

Verification passed on

Brave 1.48.132 Chromium: 109.0.5414.87 (Official Build) beta (64-bit)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS Windows 11 Version 22H2 (Build 22621.755)

https://user-images.githubusercontent.com/17010094/214093114-7fb2c35d-623d-4721-901d-9662fefd0128.mp4

Verification passed on

Brave 1.48.132 Chromium: 109.0.5414.87 (Official Build) beta (arm64)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS macOS Version 13.0 (Build 22A380)

https://user-images.githubusercontent.com/17010094/214093516-9515f3a2-8b9c-4d26-9e00-258a9621c646.mov