brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.77k stars 2.32k forks source link

WebRTC is not shown in shields on Tor tab as blocked #1453

Open LaurenWags opened 6 years ago

LaurenWags commented 6 years ago

Description

WebRTC is being blocked in a Tor window/tab (per https://github.com/brave/brave-browser/issues/1254) however, it is not being shown as blocked in shields as it was on b-l.

Steps to Reproduce

  1. Open https://diafygi.github.io/webrtc-ips/ in Tor Window
  2. Look at shields icon.

Actual result:

No badge with number of blocked items is displayed. Click on shields, verify all items are 0 regardless of whether shields are up or down: screen shot 2018-10-08 at 5 35 34 pm screen shot 2018-10-08 at 5 35 47 pm

Expected result:

Shields should show WebRTC blocked as they do on b-l for a Tor tab (regardless of whether shields are up or down): screen shot 2018-10-08 at 5 34 48 pm

screen shot 2018-10-08 at 5 35 02 pm

Reproduces how often:

easy

Brave version (chrome://version info)

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta(64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Mac OS X
Brave 0.56.2 Chromium: 70.0.3538.35 (Official Build) dev (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Mac OS X

Reproducible on current release:

Website problems only:

Additional Information

If you visit https://diafygi.github.io/webrtc-ips/ in a normal tab and block all fingerprinting, shields correctly shows 1 Fingerprinting method blocked.

tildelowengrimm commented 5 years ago

I think that the resolution here should be that the WebRTC blocks on Tor modes in particular should be exposed to shields so that we can put it in the UI.