The update button on Linux just closes the browser

wknapik commented 3 years ago

Description

I was on

Brave     1.21.73 Chromium: 89.0.4389.72 (Official Build) (64-bit)
Revision  3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}

installed from the brave-bin AUR package and I updated the package to 1.21.74, but didn't restart the browser. Today the "hamburger" button in the top-right corner turned into a green "Update" button. I wasn't expecting much from it, since built-in autoupdates rarely work on Linux in any piece of software, but I clicked it just to see what would happen and... it just closed my browser. I'm ok with this feature not working, but if it doesn't work, I'd rather not see it in the browser UI.

Steps to Reproduce

Install Brave on Linux
Wait for the "Update" button to appear in the top-right corner.
Press the button.

Actual result:

Browser is closed.

Expected result:

Browser is restarted with no loss of state (at least within reason).

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave     1.21.73 Chromium: 89.0.4389.72 (Official Build) (64-bit)
Revision  3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}

Version/Channel Information:

Can you reproduce this issue with the current release? ?
Can you reproduce this issue with the beta channel? ?
Can you reproduce this issue with the nightly channel? ?

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields? N/A
Does the issue resolve itself when disabling Brave Rewards? N/A
Is the issue reproducible on the latest version of Chrome? ?

Miscellaneous Information:

This is the first time I've seen this button, or at least the first time I noticed it.

wknapik commented 3 years ago

The green update button seems to only be displayed when a new version of the browser is installed and the running instance is not restarted.

Also, on Linux, the "About Brave" page doesn't show whether the version is the latest, the way it does on other platforms. Clicking on the version displayed leads to brave.com/latest.

NumDeP commented 3 years ago

Well technically you shouldn't be able to download the browser update via a button on the browser. Unless I'm mistaken but if you're a long time Linux user you should know that your typical download function is different to MacOS and Win10 when it comes to applications.

That being said, it is surprising that you're actually seeing an update notification in the Linux build, the irony being I requested the feature but not for the purposes of using the button to actually download but notify us to update the browser via native system - #12895

wknapik commented 3 years ago

Same behavior with the Relaunch button in About Brave.

Clicking the button just kills the browser.

On Linux the button is only shown if the package is updated on disk, but the browser has not been restarted yet.

wknapik commented 2 years ago

Still an issue as of 1.40.113

wknapik commented 2 years ago

Still an issue as of 1.43.93

wknapik commented 1 year ago

Still an issue as of 1.46.134

wknapik commented 1 year ago

Still an issue as of 1.50.119

wknapik commented 1 month ago

Still an issue as of 1.70.123

brave / brave-browser