Closed gmemstr closed 3 years ago
bsclifton
commented
3 years ago At this point, I think it would make more sense to remove the #ifdef brave_rewards_enabled guards and remove the config option (if it's in GN)
There isn't a situation where we build with rewards disabled. Maybe we used to? I'm not exactly sure why the old flag was created. It may have been used during the transition from the Muon (electron fork) to brave-core
gmemstr
commented
3 years ago I agree, there's probably no situation where you would want to disable Brave Rewards, given how core it is to the browser. The only instance I figure it would be useful would be for forks that don't want to (or can't?) leverage rewards (this was my personal goal, to maintain a private fork for myself since I really like a lot of the things Brave does).
Would be curious to know when it was added as well, generally very interested in exploring Brave's lore :)
bsclifton
commented
3 years ago Updated the issue title - thanks for reporting @gmemstr
As for lore - I believe it was indeed added as we moved from the Muon (our fork of Electron) code-base over to this new code-base (brave-core). The old rewards system was called Brave Payments and Rewards was likely disabled as we started to migrate over. Once enough of the functionality was complete, we flipped it back on. If you wanted to peek at the old original code-base, it's archived and available here:
https://github.com/brave/browser-laptop
With the overall move from browser-laptop (Muon) to brave-core:
we finished the minimal items needed for this migration we shared the first public build of our new code-base, brave-core on the Dev channel (now a deprecated release channel) in communities like Reddit:
https://www.reddit.com/r/BATProject/comments/9dkbpi/the_rewrite_of_brave_named_brave_core_is/
Shortly after (18 Oct 2018), we went live on brave.com/download with a release channel version- more info here: https://brave.com/new-brave-browser-release-available-for-general-download/
Description
I'm eager to build Brave myself and invest some time in learning the inner workings, and one of the first steps I'm trying is disabling Brave Rewards. From what I can tell, setting
brave_rewards_enabledtofalseshould be sufficient, but it appears to break builds.Some searching turns up https://github.com/brave/brave-core/pull/2462, which appears to help resolve this issue, but I'm assuming at this point there was some regression. I understand that it's not something Brave would necessarily encourage, but given it's a build flag I would expect it to behave properly.
Steps to Reproduce
brave_rewards_enabledtofalseincomponents/brave_rewards/browser/buildflags/buildflags.gninpm run buildActual result:
Expected result:
Brave builds successfully.
Reproduces how often:
Easily reproduced
Desktop Brave version:
Building from source, commit https://github.com/brave/brave-browser/commit/886ae728971d055998a11e94acde7cd6b3506c55
Brave 1.24.0 Chromium: 89.0.4389.90 (Developer Build) (64-bit) Revision 62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
Miscellaneous Information:
I've done some digging myself, attempting to surgically resolve each error, but it seems to cascade out of control. Given my relative inexperience in this area, I'm more than happy to dig into this more myself with some guidance.