Adjust macOS icon to Apple's guidelines

[aparkerdavid]

Description

It's a little too large, and the drop shadow is a little too deep. See:

No reason to eyeball-and-tweak this; Apple publishes a template for Big-Sur-style icons. It should be possible to just drop in the logo and get a pixel-perfect result. I'd be happy to do it myself, if I had access to the assets for the various alt-icons.

[bsclifton]

cc: @karenkliu @bradleyrichter

[rebron]

How we have the current logo is the size we want. Always happy to review proposals though.

[aparkerdavid]

Just to be clear: I'm not proposing that the Brave logo be resized relative to the squircle, I'm proposing that the squircle be resized and its drop shadow modified to match other Big-Sur-style icons.

The Brave icon on the left is the one currently in use, the one on the right is an alternate I made using the template provided by Apple. If the mismatch is intentional, I propose that it be reconsidered; it's pretty noticeable in a dock full of squircles, and looks a little sloppy.

Like I said, I'd be happy to do the grunt work and put in a PR, I would need the assets for the dev, beta, etc. alternate logos.

[rebron]

@karenkliu I'll defer to you on this one.

My personal dock is full of squircles.

[karenkliu]

The slightly larger icon and shadow was an intentional design choice.

Originally, we did use the Apple template for Big Sur icons. However, other apps, even ones that did the new squircle shape, didn't conform like we did - resulting in our app icon looking kinda puny in comparison. Take a look at Zoom, any of the Adobe app icons, any icon that didn't do the squircle shape, or even some Apple icons that didn't get the new treatment like Contacts and TextEdit. They are all bigger than the default Bir Sure app icon template provided by Apple. So after the first iteration where we followed the guidelines, in our second iteration we deviated from the guidelines on purpose to prevent our icon from looking too small in the dock relative to other icons.

[dchest]

Sorry for bringing this up again, but can you take another look at this issue? Now that many apps are updated to match Apple's HIG, maybe the icon can be brought back to the standard size? Additionally, the shadow is too large compared to native icons.

https://user-images.githubusercontent.com/52677/226204236-0333160d-e518-4a28-bfe7-40230168142c.mov

Contact and TextEdit are not really larger if you consider items that are inside the squircle:

[bradleyrichter]

@aguscruiz Now that we have Leo, we should be able to properly address this and roll out updates into releases as time permits.

[aguscruiz]

Fix incoming! 🫰

[LaurenWags]

@rebron @simonhong are these new icons or just resized? Assuming this would need to be checked on all channels (Nightly, Beta, Release)?

[simonhong]

@LaurenWags It's just resized a little bit and all channel's icons are changed..

[LaurenWags]

Thanks @simonhong.

Will do Nightly/Beta testing now and hold on the Release channel testing until we get an RC.

[aguscruiz]

@simonhong @LaurenWags is this already in Nightly? I can see the Nightly icon is perfect now, and the beta is slightly bigger

Nightly: 1.52.23 Beta: 1.47

[LaurenWags]

@aguscruiz definitely update your Beta please 😄

Yes - expected to be in version 1.51.x and higher. So Nightly and Beta should both have the changes. Release won't have them until early May.

I'm comparing Nightly now and will have my notes up shortly. Beta will follow and then we'll check Release once we have a Release Candidate (RC) build later this month.

Happy to have a designer's eye on this to confirm what I'm seeing, so please do share any findings!

[LaurenWags]

Verified on macOS x64/Intel:

Nightly Channel - PASSED

``` Brave | 1.51.68 Chromium: 112.0.5615.39 (Official Build) nightly (x86_64) -- | -- Revision | a0e7b9718a92bcd1cf33b7c95316caff3fc20714-refs/branch-heads/5615@{#753} OS | macOS Version 13.3.1 (Build 22E261) ``` Installed [1.51.67](https://github.com/brave/brave-browser/releases/tag/v1.51.67) and launched (version before this change). Grabbed screenshot of icon in macOS dock. Installed [1.51.68](https://github.com/brave/brave-browser/releases/tag/v1.51.68) and launched (version with this change). Grabbed screenshot of icon in macOS dock. Compared the icons per PR. 1.51.67 | 1.51.68 | 1.51.67 vs 1.51.68 --- | --- | --- | |

Beta Channel - PASSED

``` Brave | 1.51.85 Chromium: 112.0.5615.49 (Official Build) beta (x86_64) -- | -- Revision | bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936} OS | macOS Version 13.3.1 (Build 22E261) ``` Installed [1.50.107](https://github.com/brave/brave-browser/releases/tag/v1.50.107) and launched (version before this change). Grabbed screenshot of icon in macOS dock. Installed [1.51.85](https://github.com/brave/brave-browser/releases/tag/v1.51.85) and launched (version with this changed). Grabbed screenshot of icon in macOS dock. Compared the icons per PR. 1.50.107 | 1.51.85 | 1.50.107 vs 1.51.85 --- | --- | --- | |

Release Channel - PASSED

``` Brave | 1.51.106 Chromium: 113.0.5672.53 (Official Build) (x86_64) -- | -- Revision | 12f5dac35d12e8f4e72d7dd11df557ef93bc046f-refs/branch-heads/5672@{#703} OS | macOS Version 13.3.1 (Build 22E261) ``` Installed 1.50.121 and launched (version before this change). Grabbed screenshot of icon in macOS dock. Installed 1.51.106 and launched (version with this changed). Grabbed screenshot of icon in macOS dock. Compared the icons per PR. 1.50.121 | 1.51.106 | 1.50.121 vs 1.51.106 --- | --- | --- | |

---

Verified on macOS arm64/M1

Nightly Channel - PASSED

``` Brave 1.51.68 Chromium: 112.0.5615.39 (Official Build) nightly (arm64) Revision a0e7b9718a92bcd1cf33b7c95316caff3fc20714-refs/branch-heads/5615@{#753} OS macOS Version 13.3.1 (Build 22E261) ``` Installed [1.51.67](https://github.com/brave/brave-browser/releases/tag/v1.51.67) and launched (version before this change). Grabbed screenshot of icon in macOS dock. Installed [1.51.68](https://github.com/brave/brave-browser/releases/tag/v1.51.68) and launched (version with this change). Grabbed screenshot of icon in macOS dock. Compared the icons per PR. 1.51.67 | 1.51.68 | 1.51.67 vs 1.51.68 --- | --- | ---  |  | 

Beta Channel - PASSED

``` Brave 1.51.85 Chromium: 112.0.5615.49 (Official Build) beta (arm64) Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936} OS macOS Version 13.3.1 (Build 22E261) ``` Installed [1.50.107](https://github.com/brave/brave-browser/releases/tag/v1.50.107) and launched (version before this change). Grabbed screenshot of icon in macOS dock. Installed [1.51.85](https://github.com/brave/brave-browser/releases/tag/v1.51.85) and launched (version with this changed). Grabbed screenshot of icon in macOS dock. Compared the icons per PR. 1.50.107 | 1.51.85 | 1.50.107 vs 1.51.85 --- | --- | ---  |  | 

Release Channel - PASSED

``` Brave 1.51.106 Chromium: 113.0.5672.53 (Official Build) (arm64) Revision 12f5dac35d12e8f4e72d7dd11df557ef93bc046f-refs/branch-heads/5672@{#703} OS macOS Version 13.3.1 (Build 22E261) ``` Installed 1.50.121 and launched (version before this change). Grabbed screenshot of icon in macOS dock. Installed 1.51.106 and launched (version with this changed). Grabbed screenshot of icon in macOS dock. Compared the icons per PR. 1.50.121 | 1.51.106 | 1.50.121 vs 1.51.106 --- | --- | ---  |  | 

[aguscruiz]

Latest beta is perfect too!

[LaurenWags]

Awesome, thanks for the additional confirmation @aguscruiz, appreciate it 😄

[stephendonner]

Verification PASSED using

Brave	1.51.106 Chromium: 113.0.5672.53 (Official Build) (x86_64)
Revision	12f5dac35d12e8f4e72d7dd11df557ef93bc046f-refs/branch-heads/5672@{#703}
OS	macOS Version 11.7.6 (Build 20G1231)

Release channel - PASSED

Installed 1.50.121 and launched (version before this change). Grabbed screenshot of icon in macOS dock. Installed 1.51.106 and launched (version with this change). Grabbed screenshot of icon in macOS dock. Compared the icons per PR.

1.50.121	1.51.106	1.50.121 vs. 1.51.106

---

Verified PASSED using

Brave	1.51.106 Chromium: 113.0.5672.53 (Official Build) (arm64)
Revision	12f5dac35d12e8f4e72d7dd11df557ef93bc046f-refs/branch-heads/5672@{#703}
OS	macOS Version 11.7.6 (Build 20G1231)

Release channel - PASSED

Installed 1.50.121 and launched (version without this change). Grabbed screenshot of icon in macOS dock. Installed 1.51.106 and launched (version with this change). Grabbed screenshot of icon in macOS dock. Compared the icons per PR.

1.50.121	1.51.106	1.50.121 vs. 1.51.106