LaurenWags
commented
3 years ago @zenparsing @Miyayes is there a spec and test plan for this issue? marking as QA/Blocked until this is sorted.
Closed Miyayes closed 3 years ago
LaurenWags
commented
3 years ago @zenparsing @Miyayes is there a spec and test plan for this issue? marking as QA/Blocked until this is sorted.
Miyayes
commented
3 years ago Shared spec with the team. Let me know if anything else is needed!
GeetaSarvadnya
commented
3 years ago Verification passed on
Brave | 1.25.60 Chromium: 90.0.4430.212 (Official Build) beta (64-bit)
-- | --
Revision | e3cd97fc771b893b7fd1879196d1215b622c2bed-refs/branch-heads/4430@{#1429}
OS | Windows 10 OS Version 2004 (Build 19041.985)
Verified passed with
Brave 1.25.62 Chromium: 90.0.4430.212 (Official Build) beta (x86_64)
Revision e3cd97fc771b893b7fd1879196d1215b622c2bed-refs/branch-heads/4430@{#1429}
OS macOS Version 10.15.7 (Build 19H1030)Issues encountered while testing:
| 
| 
| 
| 
| 
| 
| 
| 
Confirmed user can enter a value for BAT
Confirmed USD value is shown for the entered BAT value
Confirmed value is truncated to 2 decimal places once focus leaves the field
Confirmed entered tipping amount is rounded down to closest multiple of 0.25
Confirmed able to switch between entering BAT and USD
Confirmed BAT value is shown for the entered USD value
Note - encountered #15908 here
Confirmed able to send or cancel custom tip
Example - entering BAT | Example - truncation | Example - switching | Example - confirmation
----- | ----- | ----- | -----
| 
| 
| 
Confirmed "minimum amount" messaging is shown when user attempt to tip less than .25 BAT
Confirmed insufficient balance messaging
Example - minimum | Example - insufficient
----- | -----
| 
| 
| 
| 
| 
| 
| 
Confirmed logs showed expected information
```
[23549:775:0518/125235.941547:VERBOSE1:contribution.cc(373)] Creating contribution for wallet type blinded (amount: 4.25, type: RewardsType::ONE_TIME_TIP)
[23549:775:0518/125235.947062:VERBOSE1:contribution.cc(90)] Queue timer set for 10 s
[23549:775:0518/125235.954857:VERBOSE5:ledger_impl.cc(144)]
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v1/suggestions
> Method: UrlMethod::POST
> Content: {"credentials":[{"publicKey":"6AphTv.............
> Content Type: application/json; charset=utf-8
[23549:775:0518/125236.220825:VERBOSE6:logging_util.cc(136)]
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v1/suggestions
> Result: Success
> HTTP Code: 200
> Body:
```
| 
| 
| 
| 
| 
| 
| 
Confirmed logs showed expected information
```
[24036:775:0518/133154.857589:VERBOSE1:contribution.cc(373)] Creating contribution for wallet type blinded (amount: 3.75, type: RewardsType::RECURRING_TIP)
[24036:775:0518/133154.869471:VERBOSE1:contribution.cc(90)] Queue timer set for 31 s
[24036:775:0518/133154.878949:VERBOSE5:ledger_impl.cc(144)]
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v1/suggestions
> Method: UrlMethod::POST
> Content: {"credentials":[{"publicKey":"6AphTvx................
> Content Type: application/json; charset=utf-8
[24036:775:0518/133155.225811:VERBOSE6:logging_util.cc(136)]
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v1/suggestions
> Result: Success
> HTTP Code: 200
> Body:
```
| 
| 
| 
| 
| 
| 
Confirmed logs showed expected information for tip and fee
```
[24218:775:0518/134217.802182:VERBOSE1:contribution.cc(373)] Creating contribution for wallet type uphold (amount: 2.25, type: RewardsType::ONE_TIME_TIP)
[24218:775:0518/134217.806751:VERBOSE1:contribution.cc(90)] Queue timer set for 22 s
[24218:775:0518/134217.809572:VERBOSE5:ledger_impl.cc(144)]
[ REQUEST ]
> URL: https://api-sandbox.uphold.com/v0/me/cards/............./transactions
> Method: UrlMethod::POST
> Content: {"denomination":{"amount":"2.137500","currency":"BAT"},"destination":"........","message":""}
> Content Type: application/json; charset=utf-8
[24218:775:0518/134217.983672:VERBOSE6:logging_util.cc(136)]
[ RESPONSE - OnRequest ]
> Url: https://api-sandbox.uphold.com/v0/me/cards/........./transactions
> Result: Success
> HTTP Code: 202
> Body: {"createdAt":"2021-05-18T17:42:17.941Z","denomination":{"amount":"2.1375","currency":"BAT".........
[ REQUEST ]
> URL: https://api-sandbox.uphold.com/v0/me/cards/....../transactions/......../commit
> Method: UrlMethod::POST
> Content Type: application/json; charset=utf-8
[24218:775:0518/134218.538789:VERBOSE6:logging_util.cc(136)]
[ RESPONSE - OnRequest ]
> Url: https://api-sandbox.uphold.com/v0/me/cards/....../transactions/........./commit
> Result: Success
> HTTP Code: 200
> Body: {"application":{"clientId":"4c2b6...........
[24218:775:0518/134218.539678:VERBOSE1:uphold.cc(247)] Uphold transfer fee timer set for 21 s
```
```
[ REQUEST ]
> URL: https://api-sandbox.uphold.com/v0/me/cards/......../transactions
> Method: UrlMethod::POST
> Content: {"denomination":{"amount":"0.112500","currency":"BAT"},"destination":"......","message":"5% transaction fee collected by Brave Software International"}
> Content Type: application/json; charset=utf-8
[24218:775:0518/134239.670132:VERBOSE6:logging_util.cc(136)]
[ RESPONSE - OnRequest ]
> Url: https://api-sandbox.uphold.com/v0/me/cards/........./transactions
> Result: Success
> HTTP Code: 202
> Body: {"createdAt":"2021-05-18T17:42:39.635Z","denomination":{"amount":"0.1125","currency":"BAT".......
[ REQUEST ]
> URL: https://api-sandbox.uphold.com/v0/me/cards/....../transactions/.........../commit
> Method: UrlMethod::POST
> Content Type: application/json; charset=utf-8
[24218:775:0518/134240.043865:VERBOSE6:logging_util.cc(136)]
[ RESPONSE - OnRequest ]
> Url: https://api-sandbox.uphold.com/v0/me/cards/....../transactions/............/commit
> Result: Success
> HTTP Code: 200
> Body: {"application":{"clientId":"4c2..........
```
| 
| 
| 
| 
| 
| 
| 
Confirmed logs showed expected information for tip and fee
```
[24896:775:0518/160200.399439:VERBOSE1:contribution.cc(373)] Creating contribution for wallet type uphold (amount: 1.75, type: RewardsType::RECURRING_TIP)
[24896:775:0518/160200.405157:VERBOSE1:contribution.cc(90)] Queue timer set for 27 s
[24896:775:0518/160200.408216:VERBOSE5:ledger_impl.cc(144)]
[ REQUEST ]
> URL: https://api-sandbox.uphold.com/v0/me/cards/......../transactions
> Method: UrlMethod::POST
> Content: {"denomination":{"amount":"1.662500","currency":"BAT"},"destination":"......","message":""}
> Content Type: application/json; charset=utf-8
[24896:775:0518/160200.533531:VERBOSE6:logging_util.cc(136)]
[ RESPONSE - OnRequest ]
> Url: https://api-sandbox.uphold.com/v0/me/cards/........./transactions
> Result: Success
> HTTP Code: 202
> Body: {"createdAt":"2021-05-18T20:02:00.495Z","denomination":{"amount":"1.6625","currency":"BAT".........
[24896:775:0518/160200.535006:VERBOSE5:ledger_impl.cc(144)]
[ REQUEST ]
> URL: https://api-sandbox.uphold.com/v0/me/cards/....../transactions/........./commit
> Method: UrlMethod::POST
> Content Type: application/json; charset=utf-8
[24896:775:0518/160200.871733:VERBOSE6:logging_util.cc(136)]
[ RESPONSE - OnRequest ]
> Url: https://api-sandbox.uphold.com/v0/me/cards/......./transactions/......./commit
> Result: Success
> HTTP Code: 200
> Body: {"application":{"clientId":"4c........
[24896:775:0518/160200.872756:VERBOSE1:uphold.cc(247)] Uphold transfer fee timer set for 65 s
```
```
[ REQUEST ]
> URL: https://api-sandbox.uphold.com/v0/me/cards/........./transactions
> Method: UrlMethod::POST
> Content: {"denomination":{"amount":"0.087500","currency":"BAT"},"destination":".......","message":"5% transaction fee collected by Brave Software International"}
> Content Type: application/json; charset=utf-8
[24896:775:0518/160306.301704:VERBOSE6:logging_util.cc(136)]
[ RESPONSE - OnRequest ]
> Url: https://api-sandbox.uphold.com/v0/me/cards/......../transactions
> Result: Success
> HTTP Code: 202
> Body: {"createdAt":"2021-05-18T20:03:06.112Z","denomination":{"amount":"0.0875","currency":"BAT".........
[ REQUEST ]
> URL: https://api-sandbox.uphold.com/v0/me/cards/....../transactions/........./commit
> Method: UrlMethod::POST
> Content Type: application/json; charset=utf-8
[24896:775:0518/160306.589948:VERBOSE6:logging_util.cc(136)]
[ RESPONSE - OnRequest ]
> Url: https://api-sandbox.uphold.com/v0/me/cards/....../transactions/........./commit
> Result: Success
> HTTP Code: 200
> Body: {"application":{"clientId":"4c2............
```
| 
| 
| 
| 
| 
| 
Confirmed logs showed expected information for tip and fee
```
[25190:775:0518/163237.876485:VERBOSE1:contribution.cc(373)] Creating contribution for wallet type bitflyer (amount: 4.25, type: RewardsType::ONE_TIME_TIP)
[25190:775:0518/163237.880859:VERBOSE1:contribution.cc(90)] Queue timer set for 4 s
[25190:775:0518/163237.882399:VERBOSE1:database_server_publisher_banner.cc(142)] Server publisher banner not found
[25190:775:0518/163237.884017:VERBOSE5:ledger_impl.cc(144)]
[ REQUEST ]
> URL: https://demo24kiuw4dcyncsy3qlud8u8.azurewebsites.net/api/link/v1/coin/withdraw-to-deposit-id/request
> Method: UrlMethod::POST
> Content: {"amount":"4.037500","currency_code":"BAT",..........
> Content Type: application/json; charset=utf-8
[25190:775:0518/163238.886171:VERBOSE6:logging_util.cc(136)]
[ RESPONSE - OnRequest ]
> Url: https://demo24kiuw4dcyncsy3qlud8u8.azurewebsites.net/api/link/v1/coin/withdraw-to-deposit-id/request
> Result: Success
> HTTP Code: 200
> Body: {...............
}
[25190:775:0518/163238.887081:VERBOSE1:bitflyer.cc(208)] Bitflyer transfer fee timer set for 1 s
```
```
[ REQUEST ]
> URL: https://demo24kiuw4dcyncsy3qlud8u8.azurewebsites.net/api/link/v1/coin/withdraw-to-deposit-id/request
> Method: UrlMethod::POST
> Content: {"amount":"0.212500","currency_code":"BAT".........
> Content Type: application/json; charset=utf-8
[25190:775:0518/163240.642929:VERBOSE6:logging_util.cc(136)]
[ RESPONSE - OnRequest ]
> Url: https://demo24kiuw4dcyncsy3qlud8u8.azurewebsites.net/api/link/v1/coin/withdraw-to-deposit-id/request
> Result: Success
> HTTP Code: 200
> Body: {............
}
```
| 
| 
| 
| 
| 
| 
| 
Confirmed logs showed expected information for tip and fee
```
[25361:775:0518/164457.521375:VERBOSE1:contribution.cc(373)] Creating contribution for wallet type bitflyer (amount: 3.75, type: RewardsType::RECURRING_TIP)
[25361:775:0518/164457.526511:VERBOSE1:contribution.cc(90)] Queue timer set for 36 s
[25361:775:0518/164457.528018:VERBOSE1:database_server_publisher_banner.cc(142)] Server publisher banner not found
[25361:775:0518/164457.529662:VERBOSE5:ledger_impl.cc(144)]
[ REQUEST ]
> URL: https://demo24kiuw4dcyncsy3qlud8u8.azurewebsites.net/api/link/v1/coin/withdraw-to-deposit-id/request
> Method: UrlMethod::POST
> Content: {"amount":"3.562500","currency_code":"BAT".............
> Content Type: application/json; charset=utf-8
[25361:775:0518/164458.599681:VERBOSE6:logging_util.cc(136)]
[ RESPONSE - OnRequest ]
> Url: https://demo24kiuw4dcyncsy3qlud8u8.azurewebsites.net/api/link/v1/coin/withdraw-to-deposit-id/request
> Result: Success
> HTTP Code: 200
> Body:............
}
[25361:775:0518/164458.600559:VERBOSE1:bitflyer.cc(208)] Bitflyer transfer fee timer set for 57 s
```
```
[ REQUEST ]
> URL: https://demo24kiuw4dcyncsy3qlud8u8.azurewebsites.net/api/link/v1/coin/withdraw-to-deposit-id/request
> Method: UrlMethod::POST
> Content: {"amount":"0.187500","currency_code":"BAT"...............
> Content Type: application/json; charset=utf-8
[25361:775:0518/164556.629199:VERBOSE1:ads_impl.cc(191)] Browser state changed to idle
[25361:775:0518/164556.660115:VERBOSE6:logging_util.cc(136)]
[ RESPONSE - OnRequest ]
> Url: https://demo24kiuw4dcyncsy3qlud8u8.azurewebsites.net/api/link/v1/coin/withdraw-to-deposit-id/request
> Result: Success
> HTTP Code: 200
> Body:.............
```
| 
| 
| 
| 
| 
`Reddit`
Tip banner | Banner success message | Tips brave://rewards | wallet summary | Monthly Statement | brave://rewards-internals
----- | ----- | ----- | ----- | ----- | -----
| 
| 
| 
| 
| 
`GitHub`
Tip banner | Banner success message | Tips brave://rewards | wallet summary | Monthly Statement | brave://rewards-internals
----- | ----- | ----- | ----- | ----- | -----
| 
| 
| 
| 
| 
Verification passed on
| Brave | 1.25.66 Chromium: 91.0.4472.70 (Official Build) (64-bit) |
|---|---|
| Revision | fe095368270a32c92959403754bf6fd357dd9953-refs/branch-heads/4472@{#1172} |
| OS | Ubuntu 18.04 LTS |
Issues encountered while testing:
srirambv
commented
3 years ago @deeppandya if am not wrong this is not yet available on Android. Can we have a new issue created for Android and remove the label from this one?
srirambv
commented
3 years ago Follow up issue https://github.com/brave/brave-browser/issues/16021 logged for Android and removing label from this one
Description
Custom tipping amounts allows users to manually specify how much they would like to tip a Creator. The custom tipping amount option will be in addition to the default suggested tipping amounts.
Please refer to full feature specification.