brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.53k stars 2.27k forks source link

Downloads from extensions fail #15366

Open Bitwolfies opened 3 years ago

Bitwolfies commented 3 years ago

Items exporting from extensions, such as tab session manager, or hls downloader, export as an unusable id.

Steps to Reproduce

  1. Use something like tab session manger, try to export, see that it comes out as a junk file.

Actual result:

https://user-images.githubusercontent.com/65789901/114611482-f3b7e300-9c55-11eb-8ecd-d4b9408a88da.png

Expected result:

For the proper file to export

Reproduces how often:

100%

Brave version (brave://version info)

1.23.71

jonathansampson commented 3 years ago

@Darkwolf1515 I assume that screenshot is from HLS Downloader. Is that correct?

The download/filename logic for Tab Session Manager is here: /src/background/export.js#L39-L57. I couldn't determine which HLS Downloader extension you are/were using. Can you link to the specific one?

I found the following:

Bitwolfies commented 3 years ago

https://chrome.google.com/webstore/detail/hls-downloader/apomkbibleomoihlhhdbeghnfioffbej

rebron commented 3 years ago

@Bitwolfies Looks like https://chrome.google.com/webstore/detail/hls-downloader/hkbifmjmkohpemgdkknlbgmnpocooogp is the only one available now.