brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.53k stars 2.27k forks source link

Google search OVERRIDES Private mode despite DuckDuckGo as default #15644

Open Javanmardi opened 3 years ago

Javanmardi commented 3 years ago

Description

I chose DuckDuckGo as my default search engine in Private mode and Private mode with Tor but notice when I mark a sentence and drag it into address bar it opens Google search. So it override my default search engine of choice. It happens in both Private and Tor mode. I must mention Google is my default search engine in normal mode. However the reason for private window is to have different sets of rules. Having Google pops-up is contradictory.

Steps to Reproduce

  1. Set Google search as default for Normal mode and DuckDuckGo for Private mode
  2. Open Private window with DuckDuckGo as default search engine
  3. Mark a word or sentence in any web page. Really anywhere within Private mode
  4. Drag and drop it into address bar and see Google opens as search engine.

Actual result:

Dragging and dropping items in Private mode must obey the default search engine for private mode. DuckDuckGo in my case. It opens Google search.

Expected result:

It private window Google should not be pops-up without being chosen as default. It must opens DuckDuckGo.

Reproduces how often:

Always!

Brave version (brave://version info)

Version 1.24.82 Chromium: 90.0.4430.93 (Official Build) (64-bit)

Version/Channel Information:

It happens in stable version and I am aware of every version in the last season. However my current version is Version 1.24.82 Chromium: 90.0.4430.93 (Official Build) (64-bit).

Other Additional Information:

Miscellaneous Information:

It happens in Windows 10 20H2 and I assume the same results happened in Ubuntu 20.04 LTS too.

lukemulks commented 3 years ago

Confirming that I'm able to reproduce the issue from the steps above:

Tested with Nightly channel, and am unable to reproduce the issue: Version 1.26.7 Chromium: 90.0.4430.93 (Official Build) nightly (64-bit)

Couple of notes that may prove useful:

srirambv commented 3 years ago

Regression of #1037