search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.53k stars 2.27k forks source link

Use ipns://<.crypto or .eth> by default when IPFS is setup #15749

Open bbondy opened 3 years ago

bbondy commented 3 years ago

For our Unstoppable Domains and ENS we're currently resolving to HTTP. We should prefer to resolve to IPFS first by simply loading ipns:// as the default protocol for them when IPFS is setup.

Screen Shot 2021-05-11 at 10 17 04 AM

go-ipfs will support this in 0.9.0 so we can wait for the RC1 to be released and then use an RC manually before we ship the update to implement this.

Note that we shouldn't use this ipns:// method when the option mentioned in this issue is set to Ethereum: https://github.com/brave/brave-browser/issues/15750

lidel commented 3 years ago
spylogsster commented 3 years ago

waiting for 0.9.0 for this https://github.com/brave/brave-browser/issues/15937

bbondy commented 3 years ago

Just checking on the status of this since 0.9.0 is shipped.

lidel commented 3 years ago

afaik this is ready to be picked up and worked on – go-ipfs 0.9+ already shipped to all users, so we can have ipns://*.eth in address bar and control which DoH endpoint is used for resolving them via DNS.Resolvers in $IPFS_PATH/config

gerbz commented 2 years ago

@bbondy Would love to see ENS domains defaulting to ipns:// which leaves the .eth name in the address bar. This also makes the .eth name accessible via javascript window.location.hostname.

You can use Vitalki's as an example as vitalik.eth's ENS Content record is set with an ipfs:// key. esteroids uses an ipns:// key in their esteroids.eth ENS Content record and it appears to behave the same way as Vitalik's in Brave.

Brave Settings -> Method to resolve IPFS resources -> Local IPFS Node:

Brave Settings -> Method to resolve IPFS resources -> Gateway:

@lidel and @makoto may have some input/insights on this as well.