brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.86k stars 2.33k forks source link

Consider pulling in some options from Chromium's Accessibility settings page #15844

Open stephendonner opened 3 years ago

stephendonner commented 3 years ago

Description

Consider pulling in some options from Chromium's Accessibility settings page; filed this issue after speaking briefly to @rebron.

Steps to Reproduce

  1. load chrome://settings/accessibility in Chrome/Chromium
  2. note the available Accessibility options
  3. load brave://settings/ in Brave
  4. note the lack of available Accessibility options

Actual result:

We are missing the following:

Screen Shot 2021-05-13 at 1 18 37 PM

Live Caption -- as well as a few others -- are available, instead, as feature flags:

Screen Shot 2021-05-13 at 1 16 51 PM

Expected result:

image

Pull in everything except "Live Caption" (for now) and "Add accessibility features". Move 'Pressing Tab on a webpage highlights links as well as form fields' from 'Appearance' section to the new Accessibility section

Live Caption and associated settings downloads files from Google, so not sure if we want that, and if so, if we want to proxy that?

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.26.18 Chromium: 91.0.4472.38 (Official Build) nightly (x86_64)
Revision 8155e7afab5d695cf0e028f4d77203287523cda9-refs/branch-heads/4472_35@{#6}
OS macOS Version 11.3.1 (Build 20E241)

Version/Channel Information:

Assets

Figma: https://www.figma.com/file/tLXWGCpNoiJxDZDdpfordj/?node-id=793%3A20267

karenkliu commented 3 years ago

@rebron Designs added!

farline99 commented 1 year ago

I hate this buttons highlight so much........

Rogue-Git-Dev commented 1 month ago

To this day the accessibility section is not existent in Brave's settings. This must change. Brave must incorporate more accessibility in the very least to have feature parity with Chromium.