search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.24k stars 2.23k forks source link

Implement Enable Crash Reporting from brave://crashes #1596

Open srirambv opened 5 years ago

srirambv commented 5 years ago

Description

We should implement a switch on brave://crashes to easily enable crash reporting since we ask users to get crash id's from there.

Designs

Add a toggle to enable automatic crash reporting on brave://crashes. This toggle should be linked to same setting in brave://setting. Implement Brave branding and design system components on this page to de-Chromify it.

image

Assets

Figma: https://www.figma.com/file/aJu3WGDztEWNZgwQTD9yx2/?node-id=343%3A18344

srirambv commented 5 years ago

cc: @bsclifton

bsclifton commented 3 years ago

Having a toggle for enabling/disabling crash reporting directly on brave://crashes would be cool and would lead to more reports (which should help us triage / fix crashes)

cc: @karenkliu @rebron

karenkliu commented 3 years ago

Sure, we should be able to easily add a toggle on that page which we be linked to the crash reporting toggle in brave://settings. It should look the same and use the same text:

Screen Shot 2021-05-06 at 12 04 36 PM

FYI, we also have this issue open https://github.com/brave/brave-browser/issues/1841 to ask users if they want to toggle this setting on after experiencing a crash and link to the toggle in settings too. This is a more proactive approach that would encourage more users to opt into automatic crash reporting so we can fix issues faster.

Something that would help brave://crashes look more Brave is to follow our branding and styling - use the Poppins font, icons from our icon library, checkboxes and buttons from our design system. The page should look something like this: 😃 image