Rename the laptop-updates.brave.com endpoint

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.

https://brave.com

Mozilla Public License 2.0

17.89k stars 2.34k forks source link

Rename the laptop-updates.brave.com endpoint #16374

Closed fmarier closed 3 weeks ago

fmarier commented 3 years ago

Historically, that endpoint was used for browser updates (in the Muon days). Then the stats / referral ping was added to it as a secondary use.

Now that Muon updates are no longer sent to these old clients, this endpoint is primarily for stats. We should rename it so that the name reflects the nature of the traffic.

Historical uses:

Muon browser updates (brave-core uses updates.bravesoftware.com and updates-cdn.bravesoftware.com)
crash reporting (now using backtrace.io)
list of sites to send a deprecated X-Brave-Partner header to
webcompat feedback form submissions (now on webcompat.brave.com)

Current uses:

usage pings on all platforms (includes referral code for the first 90 days if any)
referral pings when applicable (at first run, and then intermittently until 30 days later when it stops)
feedback submissions from Android users who rate the app

fmarier commented 3 years ago

Here's a concrete suggestion:

metrics.brave.com for usage pings, referral pings, and installation events
feedback.brave.com for webcompat and android feedback

~Leave partner headers on laptop-updates for now and work towards removing that mechanism entirely.~

fmarier commented 3 years ago

Leave partner headers on laptop-updates for now and work towards removing that mechanism entirely.

@diracdeltas has a better interim solution for this: remove the /promo/custom-headers endpoint and have this list be hard-coded into brave-core until we can remove it entirely. We're not supposed to be adding to it and so it doesn't need to be updatable outside of the regular release trains. I filed https://github.com/brave/brave-browser/issues/16455 for this.

fmarier commented 3 years ago

As part of using the new hostnames, we should add metrics.brave.com to https://github.com/brave/brave-core/blob/90859949913c21320e646f2d4f92609a0a401d64/chromium_src/net/tools/transport_security_state_generator/input_file_parsers.cc#L409 and feedback.brave.com to https://github.com/brave/brave-core/blob/90859949913c21320e646f2d4f92609a0a401d64/chromium_src/net/tools/transport_security_state_generator/input_file_parsers.cc#L423 so that they are pinned in some way.

fmarier commented 2 years ago

metrics.brave.com and feedback.brave.com were added in https://github.com/brave/devops/pull/6699.

DJAndries commented 1 month ago

LaurenWags commented 2 days ago

@DJAndries @fmarier due to the way promo codes are done on macOS, we wouldn't be able to verify part of the test plan on macOS until after this is released. Any concerns with just verifying the promo code part of the test plan on the other platforms (Windows, Android, and iOS)?

Also, @DJAndries is data for these endpoints starting to come through for Nightly/Beta (even if it's not much yet)?

cc @kjozwiak

DJAndries commented 2 days ago

due to the way promo codes are done on macOS, we wouldn't be able to verify part of the test plan on macOS until after this is released. Any concerns with just verifying the promo code part of the test plan on the other platforms (Windows, Android, and iOS)?

Yes, I think that's fine.

Also, @DJAndries is data for these endpoints starting to come through for Nightly/Beta (even if it's not much yet)?

yes

LaurenWags commented 1 day ago

perfect, thanks for the confirmations @DJAndries.

@brave/qa-team per the above discussion, when verifying the test plan from https://github.com/brave/brave-core/pull/25920#issue-2577673308 on macOS and Linux the referral promo check can be skipped. Full test plan should be verified on Windows, Android, and iOS.