search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.01k stars 2.22k forks source link

move private window with Tor new tab page support links inline to avoid CAPTCHAs #1647

Open kjozwiak opened 5 years ago

kjozwiak commented 5 years ago

Description

Support links within the Tor window are being opened in new tabs and not inline as per https://github.com/brave/brave-browser/issues/1507. Because they're being opened in new tabs, you'll run into a lot of CAPTCHA checks. I've personally one through at least 20 CAPTCHA checks and haven't passed once. Every time I get the ✅, another CAPTCHA is loaded after the page is refreshed.

Steps to Reproduce

  1. launch 0.55.16 Chromium: 70.0.3538.54
  2. open a new Tor window
  3. under brave://newtab, click on the "Learn more" link which will load https://support.brave.com/hc/en-us/articles/360018121491 in a new tab

Actual result:

torissue

Expected result:

Should be opening inline as per https://github.com/brave/brave-browser/issues/1507 rather than new tabs.

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.16 Chromium: 70.0.3538.54 (Official Build) (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X

Reproducible on current release:

I'm not 100% certain as we still haven't received beta & dev builds that have the new brave://newtab changes but I'm assuming it's going to be the same issue across the different channels.

N/A

Additional Information

CCing @rebron

GeetaSarvadnya commented 5 years ago

Issue is reproducible on Windows.

Brave 0.55.16 Chromium: 70.0.3538.54 (Official Build) (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Windows
rebron commented 5 years ago

Didn't die via captcha, was able to get through on first pass, not a great experience to have to go through a captcha for a learn more link. Got a separate issue where article page isn't styled. Probably a good idea to move content inline.

screen shot 2018-10-16 at 11 04 32 pm
tildelowengrimm commented 5 years ago

CAPTCHAs are a bad look. Since we know that the links on the Tor new tab page are going to be opened in Tor, let's move them back to an inline overlay (no network) while we work to make sure the knowledge-base is accessible over Tor without any additional work needed from the user.

cezaraugusto commented 4 years ago

FWIW opening links in the same tab don't run away from CAPTCHA. The best solution is to inline their content in a modal like what Tom said or use some other content block. Removing my assignment for now since this needs product/design spec first.