brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.96k stars 2.35k forks source link

Allow users to disable the QR code generator feature #17127

Open Tonev opened 3 years ago

Tonev commented 3 years ago

Description

The feature is most likely useful for a lot of users but at the same time there is another big group of users that doesn't use, or simply doesn't need the feature in their daily browsing. An option to disable the feature will allow users to keep their browser's UI cleaner and will provide a way to disable a feature they don't need at the time.

Steps to Reproduce

  1. Navigate to any website (e.g. brave.com).
  2. Click inside the address bar.
  3. An action icon shows up in the address bar. When clicked a bubble with QR code shows up.

Actual result:

There is no way to disable the feature as of the moment.

Expected result:

Hopefully an option that allows users to enable/disable the feature whenever they like.

Reproduces how often:

Easily

Brave version (brave://version info)

Brave | 1.26.77 Chromium: 91.0.4472.164 (Official Build) (64-bit) -- | -- Revision | 541163496c9982c98f61819bab7cf2183ea8180f-refs/branch-heads/4472@{#1569} OS | Windows 7 Service Pack 1 (Build 7601) JavaScript | V8 9.1.269.39 User Agent | Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.164 Safari/537.36 Command Line | "C:\Program Files\BraveSoftware\Brave-Browser\Application\brave.exe" --enable-dom-distiller --disable-domain-reliability --no-pings --origin-trial-public-key=bYUKPJoPnCxeNvu72j4EmPuK7tr1PAC7SHh8ld9Mw3E=,fMS4mpO6buLQ/QMd+zJmxzty/VQ6B1EUZqoCU04zoRU= --sync-url=https://sync-v2.brave.com/v2 --lso-url=https://no-thanks.invalid --variations-server-url=https://variations.brave.com/seed --enable-features=WebUIDarkMode,ReducedReferrerGranularity,PasswordImport,PrefetchPrivacyChanges,WinrtGeolocationImplementation,SafetyTip,AutoupgradeMixedContent,LegacyTLSEnforced --disable-features=AutofillServerCommunication,HandwritingRecognitionWebPlatformApi,FledgeInterestGroups,InterestCohortFeaturePolicy,TextFragmentAnchor,EnableProfilePickerOnStartup,FlocIdComputedEventLogging,HandwritingRecognitionWebPlatformApiFinch,AutofillEnableAccountWalletStorage,FledgeInterestGroupAPI,TrustTokens,DirectSockets,IdleDetection,NotificationTriggers,WebOTP,NetworkTimeServiceQuerying,SubresourceWebBundles,SignedExchangePrefetchCacheForNavigations,SignedExchangeSubresourcePrefetch,InterestCohortAPIOriginTrial,FirstPartySets,FederatedLearningOfCohorts,LiveCaption,LangClientHintHeader --flag-switches-begin --enable-features=WebUIDarkMode,ReducedReferrerGranularity,PasswordImport,PrefetchPrivacyChanges,WinrtGeolocationImplementation,SafetyTip,AutoupgradeMixedContent,LegacyTLSEnforced,EphemeralStorage --flag-switches-end Executable Path | C:\Program Files\BraveSoftware\Brave-Browser\Application\brave.exe Profile Path | C:\Users\User\AppData\Local\BraveSoftware\Brave-Browser\User Data\Default Variations | AdRewardsStudy:NextPaymentDayEphemeralStorageStudy:EnabledNativeCosmeticFilteringStudy:EnabledPermissionLifetimeReleaseStudy:Enabled

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

bsclifton commented 3 years ago

cc: @rebron (see notes from @Tonev under Misc Info; maybe we can add to meta issue)

Tonev commented 3 years ago

Ready-to-use patch by Ahrotahn from Ungoogled Chromium.

https://github.com/Eloston/ungoogled-chromium/pull/1591

smaragdus commented 2 years ago

Any news about this? This Create QR Code for this page that stays on top of the useful context menu items of extensions drives me crazy!

sergeevabc commented 10 months ago

Aggrrhh, remove it at last!

PhuriousGeorge commented 5 months ago

I just came looking for this as well. I now have to scroll to get to options in my context menu. Linking related request #16711

qmqz commented 3 months ago

any updates on this?

mirbaagheri commented 2 months ago

Why is this feature not added? Where is democracy?