Remove Cloud print from Brave

[srirambv]

Description

Remove Cloud print from Brave

Steps to Reproduce

1. Launch clean profile
2. Visit brave://net-internals and click on Modules
3. Cloud Print is listed as a module which we don't use
4. Cloud print is also listed in clear browsing data modal

Actual result:

Expected result:

Should not list any option that we don't support out-of-the-box

Reproduces how often:

Easy

Brave version (brave://version info)

Brave	0.55.18 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision	9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS	Linux

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds?
• Does it reproduce on browser-laptop?

Website problems only:

• Does the issue resolve itself when disabling Brave Shields?
• Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @diracdeltas @jumde @bbondy @tomlowenthal

[tildelowengrimm]

Nice catch. 👌🏻

[bbondy]

This extension can be blocked here just like the Chromium PDF Viewer one: browser/extensions/brave_extension_provider.cc

bool IsBlacklisted(const extensions::Extension* extension) {
  // This is a hardcoded list of extensions to block.
  // Typically instead you can just use the brave/go-updater to list
  // a blacklisted extension that you want to block for existing clients.
  static std::vector<std::string> blacklisted_extensions({
    // Used for tests, corresponds to brave/test/data/should-be-blocked-extension.
    "mlklomjnahgiddgfdgjhibinlfibfffc",
    // Chromium PDF Viewer.
    "mhjfbmdgcfjbbpaeojofohoefgiehjai"
  });
  return std::find(blacklisted_extensions.begin(), blacklisted_extensions.end(),
      extension->id()) != blacklisted_extensions.end();
}

[capouch]

Would it be possible for someone in the loop to provide a pointer to what's going on with this? I'm pretty inured to cloud printing, and see that there is a reference in the UI to "Brave Cloud" in the print dialog, but it doesn't do anything that I could find.

If there is going to be an analog to Google's product, or an alternative way to do print from the cloud, I'd sure be obliged to have my consciousness raised. I asked a question on the community forum but it's just sitting there. Otherwise it is a productivity threat may drive me back to Chrome.

[jumde]

Cloud print has been disabled in brave: https://github.com/brave/brave-core/commit/05b501c0d00309d403b755eccf69f52972cb0f6a - @srirambv is there anything else that needs to be done for this issue

[srirambv]

@jumde Cloud print is still shown on hosted data in clear data modal. This is on current release build

[spylogsster]

@srirambv looks fixed?

[srirambv]

@spylogsster yes it does look fixed. Any idea what fixed this one?