search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.88k stars 2.34k forks source link

Brave News Inline ads are shown when `User Activity` threshold is not reached #17303

Closed btlechowski closed 3 years ago

btlechowski commented 3 years ago

User Activity is used to determine if user is active or not. For Notification ads, ad will not be shown when User Activity threshold is not reached

For Brave News Inline ads is shown when User Activity threshold is not reached. User is not paid for viewing the ad. Ad is blocked for 1h

Steps to Reproduce

  1. Trigger inline content ad but do not reach User Activity threshold

Actual result:

For Brave News Inline ads is shown User is not paid for viewing the ad Ad is blocked for 1h

Expected result:

Ad is not shown

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.29.42 Chromium: 92.0.4515.115 (Official Build) nightly (64-bit)
Revision 48cb2f4029b84b003719740a6cf9ca73f374a857-refs/branch-heads/4515_105@{#4}
OS Linux

cc @tmancey @jsecretan @rebron @brave/legacy_qa

btlechowski commented 3 years ago

Verification passed on

Brave 1.28.104 Chromium: 92.0.4515.131 (Official Build) (64-bit)
Revision 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS Ubuntu 18.04 LTS

Verified test plan from https://github.com/brave/brave-browser/issues/17303

Verified ads are not shown when User Activity threshold is not reached:

[10190:10190:0809/181857.245351:VERBOSE2:permission_rule_util.cc(23)] User was inactive
[10190:10190:0809/181857.245597:VERBOSE1:inline_content_ad_serving.cc(64)] Inline content ad not served: Not allowed due to permission rules
[10190:10190:0809/181857.359229:VERBOSE2:permission_rule_util.cc(23)] User was inactive
[10190:10190:0809/181857.365123:VERBOSE1:inline_content_ad_serving.cc(64)] Inline content ad not served: Not allowed due to permission rules

Verified ads are shown and user is paid for viewing them when User Activity threshold is reached

[10190:10190:0809/182023.716745:VERBOSE1:inline_content_ad_serving.cc(83)] Found 4 eligible ads
[10190:10190:0809/182023.716861:VERBOSE1:inline_content_ad_serving.cc(108)] Serving inline content ad:
  uuid: 37190acf-5c56-4683-8b38-f2aa9b90afde
  creativeInstanceId: bf46745c-4fc6-4c30-ad0d-517eecb2137e
  creativeSetId: 1ab4f8ae-4a3e-47a7-a6fe-9ab662ad17cf
  campaignId: 28dbd338-aaf8-44c0-b3d9-01df58ce2c04
  advertiserId: 401acfad-2cbb-4bfc-b522-ceae781f3045
  segment: untargeted
  title: Make your gear more Brave with the latest Brave and BAT stickers
  description: Brave Swag Store
  imageUrl: https://pcdn.bravesoftware.com/brave-ads/edcbe1bf-35a8-580a-abf7-c2a05875c205.webp.pad
  dimensions: 900x750
  ctaText: See more
  targetUrl: https://store.brave.com/#/collections/stickers
[10190:10190:0809/182023.718737:VERBOSE3:inline_content_ad_event_served.cc(24)] Served inline content ad with uuid 37190acf-5c56-4683-8b38-f2aa9b90afde and creative instance id bf46745c-4fc6-4c30-ad0d-517eecb2137e
[10190:10190:0809/182023.734425:VERBOSE1:inline_content_ad_event_served.cc(32)] Successfully logged inline content ad served event
[10190:10190:0809/182028.945702:VERBOSE3:inline_content_ad_event_viewed.cc(25)] Viewed inline content ad with uuid 37190acf-5c56-4683-8b38-f2aa9b90afde and creative instance id bf46745c-4fc6-4c30-ad0d-517eecb2137e
[10190:10190:0809/182028.945982:VERBOSE1:confirmations.cc(90)] Confirming view ad for creative instance id bf46745c-4fc6-4c30-ad0d-517eecb2137e
[10190:10190:0809/182028.947844:VERBOSE1:redeem_unblinded_token.cc(50)] Redeem unblinded token
[10190:10190:0809/182028.947912:VERBOSE1:redeem_unblinded_token.cc(64)] CreateConfirmation
[10190:10190:0809/182028.947935:VERBOSE2:redeem_unblinded_token.cc(65)] POST /v1/confirmation/{confirmation_id}/{credential}
[10190:10190:0809/182028.947966:VERBOSE5:redeem_unblinded_token.cc(69)] URL Request:
  URL: https://ads-serve.brave.com/v1/confirmation/8819bdd7-847d-46a8-910b-d78984c8e559/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwiS0lJaHFtR0I3NjA3TE5Jbm9mKy9sY29iOVRqdzh5RURCUXBwWlFvOG9YND1cIixcImJ1aWxkQ2hhbm5lbFwiOlwicmVsZWFzZVwiLFwiY291bnRyeUNvZGVcIjpcIlVTXCIsXCJjcmVhdGl2ZUluc3RhbmNlSWRcIjpcImJmNDY3NDVjLTRmYzYtNGMzMC1hZDBkLTUxN2VlY2IyMTM3ZVwiLFwicGF5bG9hZFwiOnt9LFwicGxhdGZvcm1cIjpcImxpbnV4XCIsXCJzdHVkaWVzXCI6W10sXCJ0eXBlXCI6XCJ2aWV3XCJ9Iiwic2lnbmF0dXJlIjoiU1p3SzY5MmJqUzJCMVk2aTI3TVVmUFZZUEk5RGR0WE1DKy8wYm52WW43TlR4eUJPck8xbDhVVjBRZnRMVVRidFFzY2YzY09VVFVIeWpLVHJrczFvaUE9PSIsInQiOiIwMGVoK2hYbnRhUHIzNkY2SVoveDhUNmhSZVJiS1I2eDdtZ0NJL21DU2pjS0RES3BnVFBHQnZtY0lWQ0h0WVNDb1ZjV1U0c1dyNW41ekU5TXRMSFhWZz09In0=
  Content: {"blindedPaymentToken":"KIIhqmGB7607LNInof+/lcob9Tjw8yEDBQppZQo8oX4=","buildChannel":"release","countryCode":"US","creativeInstanceId":"bf46745c-4fc6-4c30-ad0d-517eecb2137e","payload":{},"platform":"linux","studies":[],"type":"view"}
  Content Type: application/json
  Method: POST
[10190:10190:0809/182028.971185:VERBOSE6:inline_content_ad_event_viewed.cc(33)] Successfully logged inline content ad viewed event
[10190:10190:0809/182029.296403:VERBOSE1:redeem_unblinded_token.cc(82)] OnCreateConfirmation
[10190:10190:0809/182029.296473:VERBOSE6:redeem_unblinded_token.cc(84)] URL Response:
  URL: https://ads-serve.brave.com/v1/confirmation/8819bdd7-847d-46a8-910b-d78984c8e559/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwiS0lJaHFtR0I3NjA3TE5Jbm9mKy9sY29iOVRqdzh5RURCUXBwWlFvOG9YND1cIixcImJ1aWxkQ2hhbm5lbFwiOlwicmVsZWFzZVwiLFwiY291bnRyeUNvZGVcIjpcIlVTXCIsXCJjcmVhdGl2ZUluc3RhbmNlSWRcIjpcImJmNDY3NDVjLTRmYzYtNGMzMC1hZDBkLTUxN2VlY2IyMTM3ZVwiLFwicGF5bG9hZFwiOnt9LFwicGxhdGZvcm1cIjpcImxpbnV4XCIsXCJzdHVkaWVzXCI6W10sXCJ0eXBlXCI6XCJ2aWV3XCJ9Iiwic2lnbmF0dXJlIjoiU1p3SzY5MmJqUzJCMVk2aTI3TVVmUFZZUEk5RGR0WE1DKy8wYm52WW43TlR4eUJPck8xbDhVVjBRZnRMVVRidFFzY2YzY09VVFVIeWpLVHJrczFvaUE9PSIsInQiOiIwMGVoK2hYbnRhUHIzNkY2SVoveDhUNmhSZVJiS1I2eDdtZ0NJL21DU2pjS0RES3BnVFBHQnZtY0lWQ0h0WVNDb1ZjV1U0c1dyNW41ekU5TXRMSFhWZz09In0=
  Response Status Code: 201
  Response: {"id":"8819bdd7-847d-46a8-910b-d78984c8e559","payload":{},"createdAt":"2021-08-09T16:20:29.129Z","type":"view","modifiedAt":"2021-08-09T16:20:29.129Z","creativeInstanceId":"bf46745c-4fc6-4c30-ad0d-517eecb2137e"}
[10190:10190:0809/182029.296561:VERBOSE1:redeem_unblinded_token.cc(112)] FetchPaymentToken
[10190:10190:0809/182029.296609:VERBOSE2:redeem_unblinded_token.cc(113)] GET /v1/confirmation/{confirmation_id}/paymentToken
[10190:10190:0809/182029.296645:VERBOSE5:redeem_unblinded_token.cc(117)] URL Request:
  URL: https://ads-serve.brave.com/v1/confirmation/8819bdd7-847d-46a8-910b-d78984c8e559/paymentToken
  Method: GET
[10190:10190:0809/182029.512081:VERBOSE1:redeem_unblinded_token.cc(128)] OnFetchPaymentToken
[10190:10190:0809/182029.512128:VERBOSE6:redeem_unblinded_token.cc(130)] URL Response:
  URL: https://ads-serve.brave.com/v1/confirmation/8819bdd7-847d-46a8-910b-d78984c8e559/paymentToken
  Response Status Code: 200
  Response: {"id":"8819bdd7-847d-46a8-910b-d78984c8e559","createdAt":"2021-08-09T16:20:29.129Z","type":"view","modifiedAt":"2021-08-09T16:20:29.184Z","creativeInstanceId":"bf46745c-4fc6-4c30-ad0d-517eecb2137e","paymentToken":{"publicKey":"oOJO/xLaCXGW6yhpeIfM4K1X2ln7sgdjTCTCHe8BugE=","batchProof":"SfTAxHC4wFx8unullp6O0JTZu9Ys5yZR72m1Vhakigg34q9ftSxAZjHnWpKn8Nfvce3px84cAGb0jqCvA2rMAw==","signedTokens":["kOsnQdM1P+i0IQ3n9UrtJh1/7yserkNDtVl1LwQAKig="]}}
[10190:10190:0809/182029.512184:VERBOSE1:confirmations.cc(250)] Successfully redeemed unblinded token with confirmation id 8819bdd7-847d-46a8-910b-d78984c8e559, creative instance id bf46745c-4fc6-4c30-ad0d-517eecb2137e and view
[10190:10190:0809/182029.512310:VERBOSE1:confirmations.cc(273)] Added 1 unblinded payment token with an estimated redemption value of 0.01 BAT, you now have 1 unblinded payment tokens