brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.86k stars 2.33k forks source link

Gray notice not showing in Tipping `dropdown panel` in certain cross-custodial cases, but shows in Tipping `banner` #17362

Closed Miyayes closed 3 years ago

Miyayes commented 3 years ago

Description

In some cross-custodial cases, the gray notice is not showing in the Tipping dropdown panel. Occurs in the Uphold-verified-user to Gemini-creator case, and also in bitFlyer-verified-user case with Gemini-creator. (See comments below as well.)

Test Plan

Specified here: https://github.com/brave/brave-core/pull/9679

Steps to reproduce:

  1. Verify user profile with Uphold
  2. Navigate to a site/channel that is Gemini-verified (e.g., batcommunity.org)
  3. Observe that the tipping dropdown panel does not show gray notice telling the user that the channel is not configured to receive tips from their wallet (due to cross-custodian)
  4. Observe that the notice does appear in the Tipping banner itself

image

Solution

Show the gray notice in this case.

cc: @LaurenWags

LaurenWags commented 3 years ago
Brave   1.29.51 Chromium: 92.0.4515.131 (Official Build) beta (x86_64)
Revision    6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS  macOS Version 11.5.1 (Build 20G80)

Does not reproduce when Gemini verified with the following publisher types:

Unverified:

Example Example
unverified1 unverified2

Connected:

Example Example
connected1 connected2

Uphold Verified:

Example Example
uphold1 uphold2

bitFlyer Verified:

Example Example
bf1 bf2
LaurenWags commented 3 years ago
Brave   1.29.51 Chromium: 92.0.4515.131 (Official Build) beta (x86_64)
Revision    6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS  macOS Version 11.5.1 (Build 20G80)

Does reproduce when bitFlyer verified with the following publisher type:

Gemini Verified:

Example Example
スクリーンショット 2021-08-05 11 46 47 スクリーンショット 2021-08-05 11 46 55

Does not reproduce with bitFlyer verified with the following publisher types:

Unverified:

Example Example
スクリーンショット 2021-08-05 11 45 46 スクリーンショット 2021-08-05 11 45 52

Connected:

Example Example
スクリーンショット 2021-08-05 11 46 02 スクリーンショット 2021-08-05 11 46 10

Uphold Verified:

Example Example
スクリーンショット 2021-08-05 11 46 22 スクリーンショット 2021-08-05 11 46 30
LaurenWags commented 3 years ago

Verification passed with

Brave | 1.29.61 Chromium: 92.0.4515.131 (Official Build) beta (x86_64)
-- | --
Revision | 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS | macOS Version 10.15.7 (Build 19H1323)

Anon User Wallet

Anon (not KYC'd) wallet screenshots **`Unverified Creator`**: Example | Example ----- | ----- Screen Shot 2021-08-17 at 10 04 02 AM | Screen Shot 2021-08-17 at 10 04 08 AM **`Connected (Verified, not KYC'd) Creator`**: Example | Example ----- | ----- Screen Shot 2021-08-17 at 10 06 16 AM | Screen Shot 2021-08-17 at 10 06 38 AM **`Uphold Verified Creator`**: Example | Example ----- | ----- Screen Shot 2021-08-17 at 10 08 27 AM | Screen Shot 2021-08-17 at 10 08 53 AM **`bitFlyer Verified Creator`**: Example | Example ----- | ----- Screen Shot 2021-08-17 at 10 10 10 AM | Screen Shot 2021-08-17 at 10 10 30 AM **`Gemini Verified Creator`**: Example | Example ----- | ----- Screen Shot 2021-08-17 at 10 11 48 AM | Screen Shot 2021-08-17 at 10 11 58 AM

Uphold KYC'd User Wallet

Uphold KYC'd wallet screenshots **`Unverified Creator`**: Example | Example ----- | ----- Screen Shot 2021-08-17 at 11 18 47 AM | Screen Shot 2021-08-17 at 11 18 55 AM **`Connected (Verified, not KYC'd) Creator`**: Example | Example ----- | ----- Screen Shot 2021-08-17 at 11 19 14 AM | Screen Shot 2021-08-17 at 11 19 22 AM **`Uphold Verified Creator`**: Example | Example ----- | ----- Screen Shot 2021-08-17 at 11 19 33 AM | Screen Shot 2021-08-17 at 11 19 39 AM **`bitFlyer Verified Creator`**: Example | Example ----- | ----- Screen Shot 2021-08-17 at 11 19 55 AM | Screen Shot 2021-08-17 at 11 20 01 AM **`Gemini Verified Creator`**: Example | Example ----- | ----- Screen Shot 2021-08-17 at 11 20 16 AM | Screen Shot 2021-08-17 at 11 20 25 AM

bitFlyer KYC'd User Wallet

bitFlyer KYC'd wallet screenshots **`Unverified Creator`**: Example | Example ----- | ----- スクリーンショット 2021-08-17 11 39 47 | スクリーンショット 2021-08-17 11 39 54 **`Connected (Verified, not KYC'd) Creator`**: Example | Example ----- | ----- スクリーンショット 2021-08-17 11 40 07 | スクリーンショット 2021-08-17 11 40 13 **`Uphold Verified Creator`**: Example | Example ----- | ----- スクリーンショット 2021-08-17 11 40 25 | スクリーンショット 2021-08-17 11 40 33 **`bitFlyer Verified Creator`**: Example | Example ----- | ----- スクリーンショット 2021-08-17 11 40 49 | スクリーンショット 2021-08-17 11 40 56 **`Gemini Verified Creator`**: Example | Example ----- | ----- スクリーンショット 2021-08-17 11 41 10 | スクリーンショット 2021-08-17 11 41 18

Gemini KYC'd User Wallet

Gemini KYC'd wallet screenshots **`Unverified Creator`**: Example | Example ----- | ----- Screen Shot 2021-08-17 at 11 47 26 AM | Screen Shot 2021-08-17 at 11 47 33 AM **`Connected (Verified, not KYC'd) Creator`**: Example | Example ----- | ----- Screen Shot 2021-08-17 at 11 47 43 AM | Screen Shot 2021-08-17 at 11 47 51 AM **`Uphold Verified Creator`**: Example | Example ----- | ----- Screen Shot 2021-08-17 at 11 48 08 AM | Screen Shot 2021-08-17 at 11 48 15 AM **`bitFlyer Verified Creator`**: Example | Example ----- | ----- Screen Shot 2021-08-17 at 11 48 33 AM | Screen Shot 2021-08-17 at 11 48 40 AM **`Gemini Verified Creator`**: Example | Example ----- | ----- Screen Shot 2021-08-17 at 11 48 56 AM | Screen Shot 2021-08-17 at 11 49 03 AM