brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.58k stars 2.28k forks source link

Brave Talk promo tooltip isn't shown for the existing user after the upgrade to 1.28.x #17420

Open GeetaSarvadnya opened 3 years ago

GeetaSarvadnya commented 3 years ago

Description

Found while testing https://github.com/brave/brave-browser/issues/16312

Brave Talk promo tooltip isn't shown for the existing user even when the user has not interacted with NTP brave talk in the older versions

Attention will also be drawn to the icon with a promo tooltip that points to it. The promo tooltip shows to: Existing users - as soon as the user updates Brave to a supported version. If the user does not interact with it, it shows on the new tab page for a total view time of 4 seconds spread across new tab pages. New users - 3 days after install. If the user does not interact with it, it shows on the new tab page for a total view time of 4 seconds spread across new tab pages.

Steps to Reproduce

  1. Open any older profile of brave 1.27.x where the user has not interacted with NTP brave talk
  2. Upgrade the profile to 1.28.105
  3. Confirmed Brave talk study is enabled in brave://versions
  4. Brave talk promo tooltip isn't shown in a new NTP/existing new tab page

(launched brave using brave.exe --variations-server-url=https://variations.bravesoftware.com/seed in 1.28.105)

Actual result:

Brave Talk promo tooltip isn't shown for the existing user even when the user has not interacted with NTP brave talk in the older version image

Expected result:

As per the expected result mentioned in the description, the brave talk promo should be shown in NTP for the existing user as soon as they upgrade the profile to the supported region

image

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.28.105 Chromium: 92.0.4515.131 (Official Build) (64-bit)
Revision 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS Windows 10 OS Version 2009 (Build 19043.1110)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

cc: @brave/legacy_qa @rebron @petemill

stephendonner commented 3 years ago

@rebron @mattmcalister this might make for a good follow-up candidate, to help drive more adoption/pickup 👍