brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.77k stars 2.32k forks source link

Changing site-specific fingerprinting blocking setting to strict mode prevents switching to standard mode #17447

Open dentistformyeye opened 3 years ago

dentistformyeye commented 3 years ago

Description

After changing the site-specific fingerprinting setting in Brave Shields to strict mode, attempting to set the fingerprinting setting to standard mode fails; the setting stays on strict mode. This might be related to #15288. (Changing the setting to "Allow all fingerprinting" works, but changing the setting to standard blocking afterward still causes the setting to switch to strict mode.)

Steps to reproduce

  1. Go to https://brave.com/
  2. Tap the Brave Shields icon, Advanced controls, and Block Fingerprinting. Tap "Fingerprinting blocked (strict, may break sites)". Tap Done.
  3. Repeat step 2, but choose "Fingerprinting blocked (standard)" instead of the strict option.

Actual result

The fingerprinting setting is still set to the strict option.

Expected result

The fingerprinting setting is set to the standard option.

Issue reproduces how often

Easily reproduced

Version/Channel Information:

Device details

Brave version

1.27.111 (Chromium: 92.0.4515.131)

Website problems only

Additional information

Tonev commented 3 years ago

Reproduced the issue on my end as well.

Users can still use Standard fingerprinting protection but for that they'll have to clear Site settings, which will reset global Brave Shields settings along with all site-specific Brave Shields settings. Once Site settings have been cleared, setting Standard fingerprinting protection on a global level will result in Standard fingerprinting protection for all websites. That's if users have made any site-specific Brave Shields changes, otherwise global Brave Shields settings are still applied properly.