search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.76k stars 2.32k forks source link

Fix icons for Bookmark Bar Folders #17463

Closed SmokeyNerd closed 3 years ago

SmokeyNerd commented 3 years ago

Test plan

See https://github.com/brave/brave-core/pull/10037

Description

Update bookmark folder icon to increase legibility and align better to user preferences.

Original description:

I am a web developer, and I manage different clients in my bookmark folders.

  • The new update, changed all the bookmark folder icons to be: image|33x26
  • This has made it a little more bland and hard to separate the folders at a glance
  • Since the icon are the same color as the text now, everything kind of blends together
  • This wasn't the case prior, when a very visible yellow folder separated them

CURRENT: image|243x27

OLD: image|244x28

Design

MacOS + Linux image image

Windows image image

Assets

Figma: https://www.figma.com/file/sS3l8tqUFxt54MEiBTalUI/?node-id=9%3A5824

pHROZEN-gHOST commented 3 years ago

Thanks for the great news. On Saturday, September 11, 2021, 04:53:07 a.m. EDT, Brian Clifton @.***> wrote:

Code is merged; next Nightly will feature the icons. We're planning to uplift to release channel - so this will be in our next release

Thanks for the feedback all 😄

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

GeetaSarvadnya commented 3 years ago

Verification passed on

Brave | 1.29.80 Chromium: 93.0.4577.63 (Official Build) (64-bit)
-- | --
Revision | ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS | Windows 10 OS Version 2009 (Build 19043.1165)

Clean profile

Regular window Light theme Regular window Dark theme
image image
Private window Light theme Private window Dark theme
image image
Tor window Light theme Tor window Dark theme
image image

Upgrade profile

Install 1.29.79 have some bookmarks in the bookmarks bar and upgrade the profile to 1.29.80 and confirmed that the bookmarks folder icons are reverted back to Yellow

1.29.79 1.29.80
image image

Verification passed on

Brave 1.29.80 Chromium: 93.0.4577.63 (Official Build) (64-bit)
Revision ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS Ubuntu 18.04 LTS
Regular window Light theme Regular window Dark theme
image image
Private window Light theme Private window Dark theme
image image
Tor window Light theme Tor window Dark theme
image image

also verified upgrade profiles

Verification PASSED on macOS 11.5.2 x64 using the following build:

Brave | 1.29.80 Chromium: 93.0.4577.63 (Official Build) (x86_64)
--- | ---
Revision | ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS | macOS Version 11.5.2 (Build 20G95)

Clean profile

Regular window Light theme Regular window Dark theme
Screen Shot 2021-09-13 at 12 57 39 PM Screen Shot 2021-09-13 at 1 00 00 PM
Private window Light theme Private window Dark theme
Screen Shot 2021-09-13 at 12 58 51 PM Screen Shot 2021-09-13 at 12 59 15 PM
Tor window Light theme Tor window Dark theme
Screen Shot 2021-09-13 at 12 59 41 PM Screen Shot 2021-09-13 at 1 25 15 PM

Upgrade profile

Install 1.29.79 have some bookmarks in the bookmarks bar and upgrade the profile to 1.29.80 and confirmed that the bookmarks folder icons are reverted back to Yellow

1.29.79 1.29.80
Screen Shot 2021-09-13 at 1 05 14 PM Screen Shot 2021-09-13 at 1 06 23 PM
pHROZEN-gHOST commented 3 years ago

I hope this is released soon.

kjozwiak commented 3 years ago

I hope this is released soon.

Planning on getting this out sometime today 👍 QA us running through verification's/reduced manual passes, You can follow the progress via https://github.com/brave/brave-browser/milestone/234.

timchan96 commented 3 years ago

Honestly, I like the old icon. It subtle yet noticeable and blends in with the dark theme. perhaps, you can make it an option?

pHROZEN-gHOST commented 3 years ago

I have it now. Thanks to everyone involved in reversing this mess!!!!!! On Monday, September 13, 2021, 12:51:44 p.m. EDT, Kamil Jozwiak @.***> wrote:

I hope this is released soon.

Planning on getting this out sometime today 👍 QA us running through verification's/reduced manual passes, You can follow the progress via https://github.com/brave/brave-browser/milestone/234.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

paragkatoch commented 3 years ago

I totally agree with @timchan96, the previous folder icon blend completely with my theme. Can you add a setting for the previous folder icon theme?

leventh commented 3 years ago

Test plan

See brave/brave-core#10037

Description

Update bookmark folder icon to increase legibility and align better to user preferences.

Original description:

I am a web developer, and I manage different clients in my bookmark folders.

  • The new update, changed all the bookmark folder icons to be: image|33x26
  • This has made it a little more bland and hard to separate the folders at a glance
  • Since the icon are the same color as the text now, everything kind of blends together
  • This wasn't the case prior, when a very visible yellow folder separated them

CURRENT: image|243x27

OLD: image|244x28

Design

MacOS + Linux image image

Windows image image

Assets

Figma: https://www.figma.com/file/sS3l8tqUFxt54MEiBTalUI/?node-id=9%3A5824

I think it looks pretty good, especially on macOSX

challo202 commented 3 years ago

thanks for reverting these icons back to yellow. As a researcher, I must have, literally, thousands of bookmarks. The yellow icons are a life saver for me. Now, can you do blue, pink, purple, . . . . ;)

Vizorous commented 3 years ago

Is this change reversible? Any options for it? I sorta loved the white icons.

SingerGuy commented 3 years ago

Is this change reversible? Any options for it? I sorta loved the white icons.

Sorry, the tribe has spoken. ;)

831Digital commented 3 years ago

THANK YOU FOR REVERTING TO YELLOW!!!!!!!!!!!!!!!!!!

challo202 commented 3 years ago

If my icons had been white perhaps I wouldn't have minded. They were not white. They were clear and not even noticeable. from a "tribe" member . . .

On Tue, Sep 14, 2021 at 1:52 PM SingerGuy @.***> wrote:

Is this change reversible? Any options for it? I sorta loved the white icons.

Sorry, the tribe has spoken. ;)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/brave/brave-browser/issues/17463#issuecomment-919503893, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVNYA6JMTSY376VGNPKSVQ3UB6YZXANCNFSM5CBXDWVQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

InternetDownloader commented 3 years ago

Long time Brave user here, long time Brave lover Part of the "Yellow Folder Tribe"...

I noticed the icons are not only yellow again, but they're beautiful! 😍 Way to go!

thebigMoose commented 3 years ago

Thank you the new icons look good and fulfill their purpose. Please try to restrain change for change sake going forward.

On Tue, Sep 14, 2021 at 7:16 PM Joseph Delphi @.***> wrote:

Long time Brave user here (and long time Brave lover!). Part of the "Yellow Folder Tribe"

I noticed the icons are not only yellow again, but they're beautiful! 😍 Way to go!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/brave/brave-browser/issues/17463#issuecomment-919576860, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHMFSJ2VCVC6VDA4RRBN7MLUB7JTRANCNFSM5CBXDWVQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

ahmed1smael commented 3 years ago

unpopular opinion, I want the grey folders back :) either way works for me but is it now an option that I can change ?

zevrix commented 2 years ago

OK folks - we got the icons (@karenkliu updated in the top post). Here's what they look like:

why macOS icons are still gray?? please don't follow Apple's lead of introducing constant new ugly changes to their UI. please restore yellow icons on Mac - thanks!

zevrix commented 2 years ago

thanks for reverting these icons back to yellow. As a researcher, I must have, literally, thousands of bookmarks. The yellow icons are a life saver for me. Now, can you do blue, pink, purple, . . . . ;)

hmm... the icons are still gray here on Mac. we need yellow icons back!

karabiber commented 1 year ago

I am a Mac user just b/c of the ugly bookmark icons, I switched to Firefox. Please fix.

davidmreid commented 1 year ago

Hi Metehan, Mine started working again all of sudden without any help from me. Go figure! -David

---------------------------David @.*** 

On Monday, January 30, 2023 at 01:10:02 PM PST, Metehan Karabiber ***@***.***> wrote:

I am a Mac user just b/c of the ugly bookmark icons, I switched to Firefox. Please fix.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>