Show Chain icon in confirmation bubble

spylogsster commented 2 years ago

Description

Api call wallet_addEthereumChain can pass network icon urls, we need to show it in the confirmation bubble

Steps to Reproduce

example of call:
{
  "id": 1,
  "jsonrpc": "2.0",
  "method": "wallet_addEthereumChain",
  "params": [
    {
      "chainId": "0x64",
      "chainName": "xDAI Chain",
      "rpcUrls": ["https://dai.poa.network"],
      "iconUrls": [
        "https://xdaichain.com/fake/example/url/xdai.svg",
        "https://xdaichain.com/fake/example/url/xdai.png"
      ],
      "nativeCurrency": {
        "name": "xDAI",
        "symbol": "xDAI",
        "decimals": 18
      }
    }
  ]
}

Actual result:

Icon is not shown

Expected result:

Icon is shown in bubble

Reproduces how often:

Desktop Brave version:

Android Device details:

Install type (ARM, x86):
Device type (Phone, Tablet, Phablet):
Android version:

Version/Channel Information:

Can you reproduce this issue with the current release?
Can you reproduce this issue with the beta channel?
Can you reproduce this issue with the nightly channel?

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields?
Does the issue resolve itself when disabling Brave Rewards?
Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

bbondy commented 2 years ago

Moving out of MVP