Remove Dapp detection infobar, lazy loading setting & infobar, and more - Githubissues

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.

https://brave.com

Mozilla Public License 2.0

17.54k stars 2.27k forks source link

Remove Dapp detection infobar, lazy loading setting & infobar, and more #17762

Closed bbondy closed 2 years ago

bbondy commented 3 years ago

Dapp detection is no longer needed, remove the infobar
Remove the setting for always loading Crypto Wallets on startup
Always actively load the Crypto Wallets extension so long as it is set as the Dapp provider
Otherwise lazily load Crytpo Wallets the first time the user visits brave://wallet when the native wallet flag is off

bbondy commented 3 years ago

cc @jamesmudgett

bbondy commented 2 years ago

Closing as a dupe of the better spec'ed out issue https://github.com/brave/brave-browser/issues/18213

srirambv commented 2 years ago

Brave	1.32.81 Chromium: 95.0.4638.54 (Official Build) beta (64-bit)
Revision	`d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}`
OS	:ballot_box_with_check: Linux	:ballot_box_with_check: Windows 11 Version 21H2 (Build 22000.194)	:ballot_box_with_check: macOS Version 11.5.2 (Build 20G95)

Verified Dapp detection doesn't show any info bar Verified there is no setting for always loading Crypto Wallets on startup Verified Crytpo Wallets extension loads when it is set as default Dapp provider Verified Crytpo Wallets extension is lazy loaded when native wallet flag is off or set as default Dapp provider Additional verification notes can be found here