search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.74k stars 2.32k forks source link

Site settings don't get saved #17859

Closed japaweiss closed 3 years ago

japaweiss commented 3 years ago

Since the update site settings don't get saved. Logs me out of feedly, have to set pocket viewing options again, brave search every time shows this "Search results quality and coverage vary by country We are working hard to improve them all. Thanks for trusting us."

Other users reported it here: https://www.reddit.com/r/brave_browser/comments/ph1vgl/site_settings_doesnt_get_saved/

Tonev commented 3 years ago

Latest update: 14:50, 5th of September

Possibly related to https://github.com/brave/brave-core/pull/9940. The fix is part of the upcoming release, I believe we're hours away from it.

@goodov is there any possibility that this issue is related to the ephemeral storage changes you introduced in 1.29?

Brave Community feedback:

goodov commented 3 years ago

It looks like something is going on with localStorage after some time. I'm trying to reproduce this locally, but haven't got any result yet. It doesn't look like it's cookie related. The change that touched localStorage and possibly the culprit is this: https://github.com/brave/brave-core/pull/9402

Tonev commented 3 years ago

Thank you for taking a look @goodov! I asked users in Brave Community for more details or/and steps to reproduce, will let you know if I get an answer, hopefully that will be of help to you.

Tonev commented 3 years ago

@goodov

It looks like Discord is the best website to check as multiple users are reporting issues with it.

Please, take a look at the following thread for more details: https://community.brave.com/t/discord-logging-out-automatically/277284

The issue is not exclusive to Discord as other users are reporting issues with other websites over here: https://community.brave.com/t/settings-for-some-websites-not-saving-with-this-version-of-brave/278452

ItzMeRajat from Brave Community sent me a video recording demonstrating the issue. I won't publish the video because it contains sensitive personal information. Instead, I'll provide written explanation of the issue:

  1. Log in Discord via https://discord.com/login.
  2. Close the tab.
  3. Go back to Discord via https://discord.com/channels/@me.

Actual result:

User is logged out.

Expected result:

User should be able to continue without re-logging.

goodov commented 3 years ago

@Tonev Can you share some additional info if possible please?

  1. How many tabs are opened at the moment the issue appears? It might be that the video shows aftermath of the event, but it's more important to know the tabs count the moment it breaks.
  2. What extensions are installed?
  3. If possible, can someone test this behavior on a clean profile? Does it breaks the same way after approximately same time?
Tonev commented 3 years ago

@goodov

I received user's permission to upload the recording after I removed the sensitive information.

https://user-images.githubusercontent.com/20608253/132041423-2ce34e4e-a8ba-4dff-8875-42ecb9683beb.mp4

Used extensions: https://aws1.discourse-cdn.com/brave/original/3X/0/f/0f975afe4c9f82a1b9ba23dc66d9a6b53a70fc2b.png

As per https://community.brave.com/t/settings-for-some-websites-not-saving-with-this-version-of-brave/278452?u=rethanis

I’ve tried resetting to default Brave settings, disabling all extensions, turning off Brave shields, but none of this fixed it. I also tested other browsers and none of them are having any issues.

goodov commented 3 years ago

Thank you. As it's not quite clear what is the root cause of the problem right now, the temporary solution is to disable "Enable Ephemeral Storage" feature on brave://flags page while we're debugging the issue.

Tonev commented 3 years ago

@goodov

Just to let you know, I updated my last comment by including user's extensions. Also, he confirmed that disabling brave://flags/#brave-ephemeral-storage resolved the issue with Discord.

I told other users to disable brave://flags/#brave-ephemeral-storage as well. I'm particularly interested in the outcome of https://community.brave.com/t/settings-for-some-websites-not-saving-with-this-version-of-brave/278452 as thread's author is having issues with the same website as @japaweiss.

Will keep you updated should users report additional details that could be of help. Good luck in debugging the issue :smiley:

goodov commented 3 years ago

@Tonev Thank you! To narrow the search scope it would be great to test if the issue appears on a clean browser install. To simplify things the clean install can be tested using beta or nightly versions so our users can keep their usual daily browser intact.

Tonev commented 3 years ago

@goodov

Rajat quickly tested Discord using Brave Nightly 1.31.10 and confirmed he didn't experience any issues.

I asked other users to give Brave Beta or Brave Nightly a try, will let you know if there are any results.

cakeslice commented 3 years ago

@goodov I had the same issue on 1.29.76 but updated to 1.29.77 and now it's working

(My issue was localStorage being wiped on tab close, not on refresh)

EDIT: After a while it seems the problem is back again

Tonev commented 3 years ago

@cakeslice

Are you able to reproduce the issue in Beta or Nightly ?

Also, did you disable brave://flags/#brave-ephemeral-storage as suggested by @goodov? I got a confirmation by a few users that disabling brave://flags/#brave-ephemeral-storage resolved their Discord issues.

Almost 5 hour so far after updating and disabling the “brave://flags/#brave-ephemeral-storage” suggested, and discord havent logged me off yet. Normally it would break in less than 2 hours, so I think the solution is working good. Thanks for the help.

japaweiss commented 3 years ago

Feedly and pocket worked today without any problems. Version 1.29.76

Tonev commented 3 years ago

@japaweiss

Do you mean 1.29.77 as there was an update a few hours ago?

japaweiss commented 3 years ago

Nope. Still on .76

Tonev commented 3 years ago

@goodov

Untitled2 Untitled

cakeslice commented 3 years ago

@cakeslice

Are you able to reproduce the issue in Beta or Nightly ?

Also, did you disable brave://flags/#brave-ephemeral-storage as suggested by @goodov? I got a confirmation by a few users that disabling brave://flags/#brave-ephemeral-storage resolved their Discord issues.

Almost 5 hour so far after updating and disabling the “brave://flags/#brave-ephemeral-storage” suggested, and discord havent logged me off yet. Normally it would break in less than 2 hours, so I think the solution is working good. Thanks for the help.

I didn't disable brave://flags/#brave-ephemeral-storage before. But I've been trying it for hours and so far it's working okay, no issues, I guess it really is related to this setting.

japaweiss commented 3 years ago

and logged out of feedly and settings of pocket reset again. Still on .76

Tonev commented 3 years ago

Latest update: 08:50, 6th of September

@japaweiss

Disable brave://flags/#brave-ephemeral-storage.

@goodov

Another thread in Brave Community: https://community.brave.com/t/randomly-lost-login-sessions-for-some-websites/279626

Pay attention especially to the following:

Additional Information: Noted that I try with Brave beta and got the same issue randomly.

I begin to think that the issue is random and that it doesn't affect all Brave users. The troublesome part is finding out why some Brave users are affected by brave://flags/#brave-ephemeral-storage while others aren't. I for one haven't faced similar issues so far.

As per https://community.brave.com/t/settings-for-some-websites-not-saving-with-this-version-of-brave/278452/17?u=rethanis

Steps to reproduce the issue:

As @Synozeer mentioned, it just happens randomly. I log in to a website and I’m supposed to stay logged in but when I open a new tab and open the same website, the website opens logged out asking me for credentials again. Also If i log in to the website and later again visit the website, its logged out.

As per https://community.brave.com/t/settings-for-some-websites-not-saving-with-this-version-of-brave/278452/20?u=rethanis

Before updating my brave browser 1.29.76 to 1.29.77 I tried to reproduce the issue but couldn’t do it the issue was suddenly gone. Then I tried creating a new profile and tried to reproduce the issue and failed again. Then I updated my brave browser to 1.29.77 and tried the above procedures again and failed to recreate the issue. Couldn’t reproduce the issue on Brave Beta v 1.30.57 Chromium: 93.0.4577.58 and Brave Nightly v1.31.22 Chromium: 93.0.4577.63 as well. Didn’t try disabling brave://flags/#brave-ephemeral-storage since I couldn’t recreate the issue.

As per https://community.brave.com/t/settings-for-some-websites-not-saving-with-this-version-of-brave/278452/28?u=rethanis

The issue is back :/. Looks like Brave Community and Google account(youtube, drive, gmail all google services work fine) are the only ones not affected by this

Edit: disabling brave://flags/#brave-ephemeral-storage works for all sites

Tonev commented 3 years ago

Latest update: 09:07, 6th of September

@goodov

It looks like users are also having issues with clearing their browsing data.

As per https://community.brave.com/t/discord-logging-out-automatically/277284:

I would try the following, just to make sure the issue isn’t related to browsing data:

  1. Open Discord.
  2. Click on the padlock icon in the address bar.
  3. Site settings → Clear data.
  4. Open brave://settings/clearBrowserData via the address bar.
  5. Time range → All time.
  6. Cached images and files → Clear data.

I followed the above steps. But clearing the site date should log me out, right? It’s not logging out.

As per https://community.brave.com/t/settings-for-some-websites-not-saving-with-this-version-of-brave/278452:

Just noticed something really weird. That day when I encountered the issue and you suggested clearing Cookies and other site data , Cached images and files , Site and Shields Settings which I did without logging out of my accounts(accounts that are always logged in on my browser like discord, tutanota, protonmail etc) which were accessible or inaccessible(due to the bug). Right now I opened discord and I directly got signed in without entering my credentials. I was confused for a moment as to how I got signed in. To confirm it I went on opening all those websites which always stay logged in on my Brave using my bookmarks tab and all of them logged in directly and no its not my password manager as it is locked plus has autofill/auto sign in disabled. Does that mean that those site settings, cookies etc were never cleared at the first place? This is weird

The issue isn’t present on my test profile neither my Brave Nightly v1.31.22 Chromium: 93.0.4577.63. I was able to recreate it on Brave Beta v1.30.57 Chromium: 93.0.4577.58.

Steps to reproduce: I opened discord, logged in to my account cleared all site settings, cache, cookies etc by selecting “All Time”, closed the browser, reopened the browser and went back to discord again.

As per https://community.brave.com/t/login-and-cookie-problems/279752:

And on android, cookies are not getting cleared for some sites. Eg for android., I went to clear browsing history, and there cleared cookies. After sometime, I will go there again to clear history and the browser ask whether to clear the old cookies again which I already did. After that the cookies are still not cleared and again it asks to clear the same cookies. Started happening 3 weeks ago on android, and 1 week before on desktop (the new update which contained gemini).

I got a confirmation that disabling the flag allows users to clear their browsing data.

As per https://community.brave.com/t/settings-for-some-websites-not-saving-with-this-version-of-brave/278452/33?u=rethanis:

https://aws1.discourse-cdn.com/brave/original/3X/b/b/bb533278fe42055edd1ee9c2f923f5fcfc3da451.png yes everything clears but cached images and files and site and sheild settings stay at “less than 1MB” and “2 sites” regardless of how many times i clear everything as shown above. I selected time range as “All time”.

n2o commented 3 years ago

UPDATE We are now unsure if the error still exists. We toggled the Ephemeral Storage to disabled, restarted Brave, checked (worked fine), changed back to Default settings on Ephemeral Storage, restarted, still works. We can't tell you what exactly "fixed" it. I send you a message when the error appears again.

We're having the same issue on the latest Brave Version on two developer notebooks:

  1. MacBook Pro (15 Zoll, 2019), macOS 11.5.2 (20G95) Version 1.29.77 Chromium: 93.0.4577.63 (Offizieller Build) (x86_64).
  2. MacBook Pro 2021 M1 Version 1.29.76, Version 93.0.4577.63 (Offizieller Build) (arm64)

After updating the (1) M1 Mac to 1.29.77, the dev says the localstorage is again available.

When I disable the flag brave://flags/#brave-ephemeral-storage it works as expected.

How to reproduce this:

  1. Go to https://schnaq.com
  2. Change your nickname on the top right (we save it in the localstorage)
  3. Close the tab
  4. Open https://schnaq.com again
  5. You're now again Anonymous, and the chosen nickname should be reset.

With disabled Ephemeral Storage on machine (2) it works again as expected.

Tonev commented 3 years ago

Latest update: 08:40, 7th of September

@n2o

UPDATE We are now unsure if the error still exists. We toggled the Ephemeral Storage to disabled, restarted Brave, checked (worked fine), changed back to Default settings on Ephemeral Storage, restarted, still works. We can't tell you what exactly "fixed" it. I send you a message when the error appears again.

I got multiple reports that the issue disappears when the flag is enabled but unfortunately it would return sooner or later and users will have to disable the flag.

Concrete examples:

bsclifton commented 3 years ago

Thanks for the assistance @Tonev 😄

@goodov has a fix and we're assessing it now (creating test plan that proves the fix works, testing that, seeing if this is a problem on Android too, etc).

This is marked as a P1 - so we'll be chatting in a bit (as part of the assessment) about releasing a hotfix. Thanks for your patience folks 😄

Tonev commented 3 years ago

Happy to help, @bsclifton.

@goodov has a fix and we're assessing it now (creating test plan that proves the fix works, testing that, seeing if this is a problem on Android too, etc).

Since the issue was reported here, I've been updating my comments here all the time so they're all up to date.

If you think the Brave Community threads could be used as a base to write a test plan upon, check the following comment: https://github.com/brave/brave-browser/issues/17859#issuecomment-912506097.

I don't know if the issue is present on Android too, but since I got a confirmation that disabling the flag resolves the issue with clearing browsing data (https://github.com/brave/brave-browser/issues/17859#issuecomment-913115562), a user in Brave Community reported such an issue on Android - https://community.brave.com/t/login-and-cookie-problems/279752, which could mean the flag is problematic on Android too.

Anyway, best of luck pushing a fix and thanks for everyone's work :wink:

kjozwiak commented 3 years ago

Unfortunately this seems difficult to reproduce as mentioned above several times. It seems like some users can reproduce the issue after a few hours and certain users can't. I personally ran through a few cases and couldn't reproduce the issue using 1.29.77 Chromium: 93.0.4577.63. However, @brave/legacy_qa will run through the following cases to ensure that https://github.com/brave/brave-core/pull/9629 hasn't regressed anything obvious. We'll also run through https://github.com/brave/brave-browser/issues/17325#issuecomment-914409319.

Test Case #1 - YT Settings

Test Case #1 - Discord

Test Case #1 - Feedly

@brave/legacy_qa run through the above several times to make sure the above is still working and nothing obvious regressed.

kjozwiak commented 3 years ago

Closing the issue and moving it into https://github.com/brave/brave-browser/milestone/232.

epilif3sotnas commented 3 years ago

Despite of this issue had been closed, I think that this might help. In my case happen after some time to use the browser and after I open at least 6 tabs. This happen on youtube and also on discord.

#issuecomment-914832612 @kjozwiak

Version 1.29.77 Chromium: 93.0.4577.63 (Official Build) (64-bit) Linux Ubuntu 21.04 x86_64

nanedi commented 3 years ago

Despite of this issue had been closed, I think that this might help. In my case happen after some time to use the browser and after I open at least 6 tabs. This happen on youtube and also on discord. #issuecomment-914832612 @kjozwiak

Version 1.29.77 Chromium: 93.0.4577.63 (Official Build) (64-bit)

Youtube, tutanota.com, startmail.com and more also.

GeetaSarvadnya commented 3 years ago

Verification is passed on

Brave | 1.29.79 Chromium: 93.0.4577.63 (Official Build) (64-bit)
-- | --
Revision | ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS | Windows 10 OS Version 2009 (Build 19043.1165)
Additional cases
Case 1_Enable Ephemeral Storage flag and verify site settings 1. Clean profile 1.29.79 2. Enable `Enable Ephemeral Storage` flags in brave://flags 3. Open a new tab and launch https://schnaq.com/ 4. Change the nickname (top right corner of the site) 5. Save the nickname 6. Close the tab https://schnaq.com/ 7. Reopen the tab and ensure the nickname is retained 8. Restart the browser and ensure the nickname is retained (Verified the steps 1-8 without enabling `Enable Ephemeral Storage` also) Example | Example ----------|--------- ![image](https://user-images.githubusercontent.com/38657976/132509047-21f522ea-0805-4dcf-92e9-9e168e1f4cb3.png) | ![image](https://user-images.githubusercontent.com/38657976/132509156-514f9603-aeb5-4f20-98cb-bd50240ebbac.png)
Case 2_Login gmail, view emails and verify site settings 1. Clean profile 1.29.79 2. Open a new tab and log into `gmail.com` 3. Close the tab `gmail.com` 4. Open `gmail.com` and ensured Gmail account is logged in 5. Restart the browser 6. Ensured Gmail account is logged in 7. Navigate to inbox and view some emails and close the `gmail.com` tab 8. Reopen gmail.com and ensured Gmail account is logged in 9. Restart the browser 10. Ensured Gmail account is logged in
Case 3_View twitch videos, change settings and verify site settings retain 1. Clean profile 1.29.79 2. Open a new tab and visit Twitch.com 3. Change the settings for `Quality` to 160 p 4. Close the https://www.twitch.tv/esl_csgo 5. Reopen https://www.twitch.tv/esl_csgo in a new tab 6. Ensured settings changed in step 3 are retained 7. Restart the browser 8. Ensured settings changed in step 3 are retained
Case 4_Clear cookies and site data verify site settings retain 1. Clean profile 1.29.79 2. Log into gmail.com 3. Click on lock icon and open site settings and clear the data 4. Open brave://settings/clearBrowserData and clear the data 5. Reload the gmail.com 6. Site data is cleared and gmail.com is logged out as expected

Verified passed with

Brave | 1.29.79 Chromium: 93.0.4577.63 (Official Build) (x86_64)
-- | --
Revision | ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS | macOS Version 10.15.7 (Build 19H1323)

Verification passed on

Brave 1.29.79 Chromium: 93.0.4577.63 (Official Build) (64-bit)
Revision ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS Ubuntu 18.04 LTS
srirambv commented 3 years ago

Verification passed on Oppo Reno 5 with Android 11 running 1.29.79 x64 build

Tonev commented 3 years ago

Might be a good idea to correct the mistake in the ticket's title so the release notes are fetched correctly :smile:

https://github.com/brave/brave-browser/issues/17946

CC: @LaurenWags

kjozwiak commented 3 years ago

Might be a good idea to correct the mistake in the ticket's title so the release notes are fetched correctly 😄

17946

CC: @LaurenWags

We usually translate each issue to something that people can understand either way. We usually don't use the title as the release notes. For example, for this issue, we used the following:

 - Fixed issue where site settings were not being retained in certain cases. ([#17859](https://github.com/brave/brave-browser/issues/17859))

Example of the release notes:

kjozwiak commented 3 years ago

Just a heads up, we just released https://github.com/brave/brave-browser/releases/tag/v1.29.79 on all platforms which should fix the issue that users were experiencing. If you're still experiencing the issue while using 1.29.79 Chromium: 93.0.4577.63, please let me know 👍

Tonev commented 3 years ago

@goodov @kjozwiak

Please, take a look when possible: https://community.brave.com/t/settings-for-some-websites-not-saving-with-this-version-of-brave/278452/41?u=rethanis

goodov commented 3 years ago

I'm not sure if it's the same issue for harrythunder, it might be something cookie related. Let's wait for other users to confirm whether the issue reappears for them or not.

Tonev commented 3 years ago

What bothers me in user's report is that the user claims disabling ephemeral storage resolves the issue. It could be temporarily, though, I'll keep you updated.