GeetaSarvadnya
commented
2 years ago Verification PASSED on
Brave | 1.38.75 Chromium: 100.0.4896.60 (Official Build) beta (64-bit)
-- | --
Revision | 6a5d10861ce8de5fce22564658033b43cb7de047-refs/branch-heads/4896@{#875}
OS | Windows 10 Version 21H2 (Build 19044.1586)
- Logged https://github.com/brave/brave-browser/issues/22275
- Logged https://github.com/brave/brave-browser/issues/22276
- Logged https://github.com/brave/brave-browser/issues/22281
- Logged https://github.com/brave/brave-browser/issues/22284
- Logged https://github.com/brave/brave-browser/issues/22415
- Logged https://github.com/brave/brave-browser/issues/22422
1. Clean profile
Compare v1 and v2 local site shield settings count
Case 1: Adblocking_Local site shiled settings_PASSED
- Confirmed shield v2 is set to enabled by default Brave://flags | website v2 shield -----|------  |  **Case 1:** - Clean profile 1.38.x - Open a website and click on shield make note of trackers and ad block count - Go to brave://flags and enable the v1 shield - Reload the already opened cnn.com - Make sure the v1 and v2 shield trackers count is the same on the shield badges - Click on each shield and ensure the trackers' count is the same on the shields panel **`Trackers count on the v1 shield panel`** | **`Trackers count on the v2 shield panel`** ----|-----  |  **Case 2:** - Change the adblocking settings to "Aggressive" - Make sure the v1 and v2 shield trackers count is the same on the shield badges - Click on each shield and ensure the trackers count is the same on the shields panel **`Trackers count on the v1 shield panel`** | **`Trackers count on the v2 shield panel`** ----|-----  |  **Case 3:** - Change the adblocking settings to "Allow" - Make sure the v1 and v2 shield trackers count is removed from the shield badges - Click on each shield and ensure the trackers are allowed on both the shields and the trackers count is `0` on both shields **`Trackers count on the v1 shield panel`** | **`Trackers count on the v2 shield panel`** ----|-----  | Case 2: Fingerprintblocking_Local site shiled settings_PASSED
- Confirmed that `Block fingerprint` is selected by default Case 1: `Aggressively block fingerprinting` - Clean profile 1.38.x - Enable v1 shield via brave://flags - Open the cnn.com website - Click on the shield v2, expand the advanced view - Select the `Aggressively block fingerprinting` option - Ensure that the tracker's count is refreshed in the shield - Confirmed that trackers count in v1 and v2 shield is same v2 | v1 -- | --  |  Case 2: `Allow fingerprinting` - Clean profile 1.38.x - Enable v1 shield via brave://flags - Open the cnn.com website - Click on the shield v2, expand the advanced view - Select the `Aggressively block fingerprinting` option - Ensure that the tracker's count is refreshed in the shield - Confirmed that trackers count in v1 and v2 shield is same v2 | v1 -- | --  |  Case 3: `Block fingerprinting` - Clean profile 1.38.x - Enable v1 shield via brave://flags - Open the cnn.com website - Click on the shield v2, expand the advanced view - Ensured block fingerprint is selected by default in fingerprint dropdown - Ensure that the tracker's count is refreshed in the shield - Confirmed that trackers count in v1 and v2 shield is same v2 | v1 -- | --  | Case 3: Block cookies_Local site shiled settings_PASSED
Case 1: - Clean profile 1.38.x - Enable v1 shield via brave://flags - Open the cnn.com website - Click on the shield v2, expand the advanced view - Ensured block cross-site cookies are selected by default in the block cookies dropdown - Ensure that the tracker's count is refreshed in the shield - Confirmed that trackers count in v1 and v2 shield is same v2 | v1 -- | --  |  Case 2: - Clean profile 1.38.x - Enable v1 shield via brave://flags - Open the cnn.com website - Click on the shield v2, expand the advanced view - Ensured `block all cookies` are selected by default in the block cookies dropdown - Ensure that the tracker's count is refreshed in the shield - Confirmed that trackers count in v1 and v2 shield is same v2 | v1 -- | --  |  Case 3: - Clean profile 1.38.x - Enable v1 shield via brave://flags - Open the cnn.com website - Click on the shield v2, expand the advanced view - Ensured `Allow all cookies` are selected by default in the block cookies dropdown - Ensure that the tracker's count is refreshed in the shield - Confirmed that trackers count in v1 and v2 shield is same v2 | v1 -- | --  | Case 4: Upgrade connection to HTTPS_Local site shiled settings_PASSED
Case 1: - Clean profile 1.38.x - Open any site, click on the shield and expand the advanced view and ensured the HTTPS upgrade switch is ON by default - Go to brave://flags and enable the v1 shield - Open http://https-everywhere.badssl.com/ - Make sure HTTPS upgrade is working as expected, encountered https://github.com/brave/brave-browser/issues/22503 v2 | v1 -- | --  |  Case 2: - Clean profile 1.38.x - Open any site, click on the shield and expand the advanced view and disable the HTTPS upgrade switch - Go to brave://flags and enable the v1 shield - Open http://https-everywhere.badssl.com/ - Make sure HTTPS upgrade should not happen as HTTPS upgrade toggle is OFF v2 | v1 -- | --  | Case 5: Block scripts_Local site shiled settings_PASSED
- Clean profile 1.38.x - Enable v1 shield via brave://flags - Open the cnn.com website - Click on the shield v2, expand the advanced view - Turn `Block scripts` to ON - Ensure that the scripts are blocked on the cnn.com and blocked java scripts count is shown on the shield - Ensure that the click on blocked scripts count lists all the java scripts which are blocked on cnn.com - Confirmed that trackers count in v1 and v2 shield is same v2 | v1 -- | --  | Compare v1 and v2 Global shield settings count
Case 1: Adblocking_Global site shiled settings_PASSED
Case 1: - Clean profile 1.38.x - Open global shield settings and change the default AdBlock settings to "Aggressive" - Open a website and click on the shield and expand the "advanced view" and ensured "Aggressive" is selected in the AdBlock dropdown - Go to brave://flags and enable the v1 shield - Reload the website - Make sure the v1 and v2 shield trackers count is the same on the shield badges - Click on each shield and ensure the trackers' count is the same on the shields panel v2 | v1 | List of trackers ----|-----|----  |  |  Case 2: - Clean profile 1.38.x - Open global shield settings and change the default AdBlock settings to "Disabled" - Open a website and click on the shield and expand the "advanced view" and ensured "Allow" is selected in the AdBlock dropdown - Go to brave://flags and enable the v1 shield - Reload the website - Make sure the v1 and v2 shield trackers count is the same on the shield badges - Click on each shield and ensure the trackers' count is the same on the shields panel v2 | v1 ----|-----  | Case 2: Fingerprintblocking_Global site shiled settings_PASSED
Case 1: - Clean profile 1.38.x - Open global shield settings and change the default AdBlock settings to "Strict, may break sites" - Open a website and click on the shield and expand the "advanced view" and ensured "Aggressively block fingerprinting" is selected in the Fingerprinting dropdown - Go to brave://flags and enable the v1 shield - Reload the website - Make sure the v1 and v2 shield trackers count is the same on the shield badges - Click on each shield and ensure the trackers' count is the same on the shields panel v2 | v1 | List of trackers ----|-----|----  |  |  Case 2: - Clean profile 1.38.x - Open global shield settings and change the default AdBlock settings to "Disabled" - Open a website and click on the shield and expand the "advanced view" and ensured "Allow fingerprinting" is selected in the Fingerprinting dropdown - Go to brave://flags and enable the v1 shield - Reload the website - Make sure the v1 and v2 shield trackers count is the same on the shield badges - Click on each shield and ensure the trackers' count is the same on the shields panel v2 | v1 ----|-----  | Case 3: Block cookies_Global site shiled settings_PASSED
Case 1: - Clean profile 1.38.x - Open global shield settings and change the default AdBlock settings to "All" - Open a website and click on the shield and expand the "advanced view" and ensured "Block all cookies" is selected in the Block cookies dropdown - Go to brave://flags and enable the v1 shield - Reload the website - Make sure the v1 and v2 shield trackers count is the same on the shield badges - Click on each shield and ensure the trackers' count is the same on the shields panel v2 | v1 | List of trackers ----|-----|----  | |  Case 2: - Clean profile 1.38.x - Open global shield settings and change the default AdBlock settings to "Disabled" - Open a website and click on the shield and expand the "advanced view" and ensured "Allow all cookies" is selected in the Block cookies dropdown - Go to brave://flags and enable the v1 shield - Reload the website - Make sure the v1 and v2 shield trackers count is the same on the shield badges - Click on each shield and ensure the trackers' count is the same on the shields panel v2 | v1 ----|-----  | Case 4: Upgrade connection to HTTPS_Global site shiled settings_PASSED
Case 1: - Clean profile 1.38.x - Open global shield settings and make sure upgrade to HTTPS switch is enabled - Open a website and click on the shield and expand the "advanced view" and ensured "upgrade to HTTPS " is enabled - Go to brave://flags and enable the v1 shield - Open http://https-everywhere.badssl.com/ - Make sure HTTPS upgrade is working as expected, encountered https://github.com/brave/brave-browser/issues/22503 Case 2: - Clean profile 1.38.x - Open global shield settings and disable upgrade to HTTPS switch - Open a website and click on the shield and expand the "advanced view" and ensured "upgrade to HTTPS " is disabled - Go to brave://flags and enable the v1 shield - Open http://https-everywhere.badssl.com/ - Make sure HTTPS upgrade should NOT happen (even though the HTTPS component is up-to-date in brave://components) as HTTPS upgrade global switch is OFFCase 5: Block scripts_Global site shiled settings_PASSED
Case 1: - Clean profile 1.38.x - Open global shield settings and enable block scripts toggle - Open a twiiter.com website and ensure scripts are blocked and the website doesn't load - Go to brave://flags and enable the v1 shield - Reload the website - Make sure the v1 and v2 shield trackers count is the same on the shield badges - Click on each shield and ensure the trackers' count is the same on the shields panel Example | Example -- | ---  |  v2 | v1 | List of javascript blocked ----|-----|----  |  |  Case 2: - Clean profile 1.38.x - Open global shield settings and disable block scripts toggle - Open a twiiter.com website and expand the advanced view and ensured the "Block scripts" toggle is disabled - Go to brave://flags and enable the v1 shield - Reload the website and ensure the website loads and there are no scripts blocked - Make sure the v1 and v2 shield trackers count is the same on the shield badges - Click on each shield and ensure the trackers' count is the same on the shields panel Example | Example -- | ---  |  v2 | v1 ----|-----  | 2. Upgrade profile
Local site shield settings
Case 1: Adblocking_Local site shiled settings_PASSED
Case1: Default settings upgrade - Install `1.37.x` open the cnn.com website and ensured ads and trackers are blocked for enn.com and the tracker's count is shown in the shield - Upgrade the profile to `1.38.105` - Enable v1 shield via brave://flags - Reload the cnn.com website - Ensure that the trackers and ads are blocked the same as in 1.37.x - Confirmed that the default AdBlock setting "trackers and Adblock (standard)" is retained after the upgrade - Confirmed that adblocking settings can be altered in an upgraded profile - Confirmed that changed settings are retained after the browser restart 1.37.x | 1.38.x -- | --  |  Case 2: Change Adblocking to "Allow" and then upgrade - Install `1.37.x` open the cnn.com website and select the adblocking settings to "Allow" - Upgrade the profile to `1.38.105` - Enable v1 shield via brave://flags - Reload the cnn.com website - Ensure that the trackers and ads are allowed the same as in 1.37.x - Confirmed that the changed AdBlock setting "Allow" is retained after the upgrade - Confirmed that adblocking settings can be altered in an upgraded profile - Confirmed that changed settings are retained after the browser restart 1.37.x | 1.38.x -- | --  |  Case 3: Change Adblocking to "Aggressive" and then upgrade - Install `1.37.x` open the cnn.com website and select the adblocking settings to "Aggressive" - Upgrade the profile to `1.38.105` - Enable v1 shield via brave://flags - Reload the cnn.com website - Ensure that the trackers and ads are blocked the same as in 1.37.x - Confirmed that the changed AdBlock setting "Allow" is retained after the upgrade - Confirmed that adblocking settings can be altered in an upgraded profile - Confirmed that changed settings are retained after the browser restartCase 2: Fingerprintblocking_Local site shiled settings_PASSED
Case1: Default settings upgrade - Install `1.37.x` open the cnn.com website and ensured the default Fingerprinting setting is selected - Upgrade the profile to `1.38.105` - Enable v1 shield via brave://flags - Reload the cnn.com website - Ensure that the trackers and ads are blocked the same as in 1.37.x - Confirmed that the default Fingerprinting setting "trackers and Adblock (standard)" is retained after the upgrade - Confirmed that Fingerprinting settings can be altered in an upgraded profile - Confirmed that changed settings are retained after the browser restart Case 2: Change Fingerprinting to "Allow" and then upgrade - Install `1.37.x` open the cnn.com website and select the Fingerprinting settings to "Allow" - Upgrade the profile to `1.38.105` - Enable v1 shield via brave://flags - Reload the cnn.com website - Ensure that the trackers and ads are blocked the same as in 1.37.x - Confirmed that the changed Fingerprinting setting "Allow" is retained after the upgrade - Confirmed that Fingerprinting settings can be altered in an upgraded profile - Confirmed that changed settings are retained after the browser restart Case 3: Change Fingerprinting to "Aggressive" and then upgrade - Install `1.37.x` open the cnn.com website and select the Fingerprinting settings to "Aggressive" - Upgrade the profile to `1.38.105` - Enable v1 shield via brave://flags - Reload the cnn.com website - Ensure that the trackers and ads are blocked the same as in 1.37.x - Confirmed that the changed Fingerprinting setting "Aggressive" is retained after the upgrade - Confirmed that Fingerprinting settings can be altered in an upgraded profile - Confirmed that changed settings are retained after the browser restartCase 3: Block cookies_Local site shiled settings_PASSED
Case1: Default settings upgrade - Install `1.37.x` open the cnn.com website and ensured the default Block cookies setting is selected - Upgrade the profile to `1.38.105` - Enable v1 shield via brave://flags - Reload the cnn.com website - Ensure that the trackers and ads are blocked the same as in 1.37.x - Confirmed that the default Block cookies setting "block cookies (standard)" is retained after the upgrade - Confirmed that Block cookies settings can be altered in an upgraded profile - Confirmed that changed settings are retained after the browser restart Case 2: Change block cookies to "Allow" and then upgrade - Install `1.37.x` open the cnn.com website and select the Block cookies settings to "Allow" - Upgrade the profile to `1.38.105` - Enable v1 shield via brave://flags - Reload the cnn.com website - Ensure that the trackers and ads are blocked the same as in 1.37.x - Confirmed that the changed Block cookies setting "Allow" is retained after the upgrade - Confirmed that Block cookies settings can be altered in an upgraded profile - Confirmed that changed settings are retained after the browser restart Case 3: Change block cookies to "Aggressive" and then upgrade - Install `1.37.x` open the cnn.com website and select the Block cookies settings to "Aggressive" - Upgrade the profile to `1.38.105` - Enable v1 shield via brave://flags - Reload the cnn.com website - Ensure that the trackers and ads are blocked the same as in 1.37.x - Confirmed that the changed Block cookies setting "Aggressive" is retained after the upgrade - Confirmed that Block cookies settings can be altered in an upgraded profile - Confirmed that changed settings are retained after the browser restartCase 4: Upgrade connection to HTTPS_Local site shiled settings_PASSED
Case 1: - Clean profile 1.37.x - Open any site, click on the shield and expand the advanced view and ensured the HTTPS upgrade switch is ON by default - Open http://https-everywhere.badssl.com/ and ensured the HTTPS upgrade works fine - Upgrade the profile 1.38.x - Go to brave://flags and enable the v1 shield - Make sure the HTTPS upgrade is working as expected and the HTTPS upgrade switch is enabled, encountered https://github.com/brave/brave-browser/issues/22503 Case 2: - Clean profile 1.37.x - Open any site, click on the shield and expand the advanced view and disable the HTTPS upgrade switch - Open http://https-everywhere.badssl.com/ and ensured the HTTPS upgrade doesn't work - Upgrade the profile 1.38.x - Go to brave://flags and enable the v1 shield - Confirmed HTTPS upgrade switch is disabled and HTTPS upgrade doesn't work as HTTPS upgrade switch is disabledCase 5: Block scripts_Local site shiled settings_PASSED
Case 1: - Clean install 1.37.x - Open any site and enable the block scripts - Open twitter.com and ensured scripts are blocked on the twitter.com and site doesn't load - Upgrade the profile to 1.38.x - Confirmed block scripts switch is retained and scripts are blocked on twitter.com - Confirmed block scripts switch state can be altered in an upgraded profile - Confirm block scripts switch state is retained after the browser restart Case 2: - Clean install 1.37.x - Open any site and disable the block scripts - Open twitter.com and ensured scripts are NOT blocked on the twitter.com and site loads correctly - Upgrade the profile to 1.38.x - Confirmed block scripts switch is retained and scripts are NOT blocked on twitter.com - Confirmed block scripts switch state can be altered in an upgraded profile - Confirm block scripts switch state is retained after the browser restartGlobal shield settings
MadhaviSeelam
|
|
|
|
|
|
|
| 
|
|
|
|
|
|
|
|
|<
|
|<
|
|
|
|
|
win1-https|win2-https|win_block_cookies|win2_block_cookies
---|---|---|---
|
|<
|
|
|
|<
|
|
|
stephendonner
| 
**Case 1:**
- Clean profile `1.38.x`
- Open `CNN.com` and click on the Shields icon; make note of trackers and ad-block count
- Go to `brave://flags` and enable the v1 shield
- Reload the already opened `CNN.com`
- Make sure the v1 and v2 Shields trackers count is the same on the Shields badges
- Click on each Shield and ensure the trackers' count is the same on the Shields panel
**`Trackers count on the v1 Shields panel`** | **`Trackers count on the v2 Shields panel`**
----|-----
| 
**Case 2:**
- Change the ad-blocking settings to "Aggressive"
- Make sure the v1 and v2 Shields trackers count is the same on the Shields badges
- Click on each Shield and ensure the trackers count is the same on the Shields panel
**`Trackers count on the v1 shield panel`** | **`Trackers count on the v2 shield panel`**
----|-----
| 
**Case 3:**
- Change the ad-blocking settings to "Allow"
- Make sure the v1 and v2 Shields trackers count is removed from the Shields badges
- Click on each Shield and ensure the trackers are allowed on both the Shields and the trackers count is `0` on both shields
**`Trackers count on the v1 shield panel`** | **`Trackers count on the v2 shield panel`**
----|-----
| 
| 
Case 2: `Allow fingerprinting`
- Clean profile `1.38.x`
- Enable v1 Shields via `brave://flags`
- Open the `CNN.com` website
- Click on the Shields icon in the URL bar
- Click on `Advanced controls`
- Select the `Allow fingerprinting` option
- Ensure that the tracker's count is refreshed in the Shield
- Confirmed that trackers count in v1 and v2 Shields is same
v1 | v2
-- | --
| 
| 
Case 2: `Allow all cookies`
- Clean profile `1.38.x`
- Enable v1 shield via `brave://flags`
- Open the `CNN.com` website
- Click on the shield v2, expand the advanced view
- Select the `All cookies` option
- Ensure that the count is refreshed in the shield
- Confirmed that blocked count in v1 and v2 shield is same
v1 | v2
-- | --
| 
| 
Case 2: `Upgrade connections to HTTPS` disabled - PASSED
- Clean profile `1.38.x`
- Enable v1 shield via `brave://flags`
- Load `http://https-everywhere.badssl.com/`
- Click on the shield v2, expand the advanced view
- Confirm red-background page, remained on `http://https-everywhere.badssl.com/` (non-SSL)
v1 | v2
--|--
| 
| 
Case 2: `Block scripts` enabled - PASSED
- Clean profile `1.38.x`
- Enable v1 shield via `brave://flags`
- Load `twitch.tv`
- Click on the shield v2, expand the advanced view
- Confirm you get a white page with no content
- Confirm the blocked-item counts on v1 and v2 of the Shields panels match
v1 | v2
--|--
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
btlechowski
s-palianskas
palianskas
BobT36
Description
Update to new designs and refactor Shields to use mojom api
Subtasks
Miscellaneous Information:
Figma link: https://www.figma.com/file/3A6F6VrxVahiZFxLr7j7FO/Desktop-Brave-Shields?node-id=689%3A24419
Launch Plan
This allows: