search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.67k stars 2.31k forks source link

Add support to delete all bookmarks under root folders like `Mobile bookmarks` folder (add a menu option) #18766

Open tathastu871 opened 2 years ago

tathastu871 commented 2 years ago

Description

Steps to Reproduce

  1. CLICK ON MENU
  2. CLICK ON Bookmarks
  3. Click on back arrow in upper left corner
  4. See there is no option to select mobile bookmark folder and delete it completely
  5. We have to select each bookmark individually and keep scrolling and selecting and then we can delete them.
  6. Scrolling and selecting 1000s of bookmark is nearly impossible manually
  7. Same issue is with pc version of brave too.
  8. There is no option in PC Version of brave to select all bookmark simultaneously and delete them.

20211014_153822 See in above pic there is no three dot menu to select entire mobile bookmark folder and delete it

20211014_153927 See in above pic that is inside mobile bookmark folder i have to select each bookmark individually and keep scrolling through 1080 bookmarks and select them to delete that is nearly imposiible to select that much bookmark individually there is no select all option.

What you have shown in :https://github.com/brave/brave-browser/issues/15336#issuecomment-942999128

Is actually a subfolder. If in mobile bookmark folder i select some bookmark and add them to new subfolder that subfolder can be deleted. But that is not case whenever user create bookmark in android brave it goes directly into root mobile bookmark folder and when user create bookmark in pc brave it goes to bookmark bar root folder. There is no option to delete the root folder and all bookmarks along with it.

Expected result:

Select All Bookmark to Delete Feature:

https://user-images.githubusercontent.com/65007212/138547425-a0667dc0-4c5e-42a6-a711-35c5663b2a33.mp4

Reproduces how often:

EASILY REPRODUCED ## Desktop Brave version: LATEST ## Android Device details: - Install type (ARM, x86):ARM - Device type (Phone, Tablet, Phablet):PHONE - Android version:10 PLEASE IF IT IS IMPOSSIBLE TO DELETE THE ROOT FOLDER ADD OPTION TO SELECT ALL BOOKMARKS AT ONCE AND THEN DELETE THEM.CURRENTLY WE HAVE TO SELECT EACH BOOKMARK INDIVIDUALLY. ON SCREEN MAX 10 BOOKMARK ARE SHOWN AND WE HAVE TO SELECT THEM THEN SCROLL DOWN AND SELECT ANOTHER 10. IN THIS WAY IF WE HAVE TO SELECT 1000s of BOOKMARKS IN ORDER TO DELETE THEM. ITS NEARLY IMPOSSIBLE. ON PC VERSION ALSO THERE IS NO OPTION TO SELECT ALL BOOKMARKS AT ONE IN ORDER TO DELETE. THIS ISSUE IS PREVALENT ON BOTH PC AND ANDROID VERSION. ON PC TOO WE HAVE TO SELECT INDIVIDUAL BOOKMARK TO DELETE THEM.
tathastu871 commented 2 years ago

Current workaround is export bookmarks from brave (that too is impossible from android version) edit the file remove unnecessary bookmark add new bookmark and then start a new sync chain and import the newly edited bookmark file Everytime creating new sync chain is not viable

tathastu871 commented 2 years ago

Plese do reply i have updated issue with proper details and expected results and implement these.

tathastu871 commented 2 years ago

Please do read entire issue along with pics and video that i have uploaded and implement neccesary code changes. Make this issues higher priority because: See above all features that i have mentioned are present in other android browsers which are also based on chromium engine which have ad and tracker blocking features like that of brave plus features that brave dont have like extension support and all necessary basic browser functionality. I just want brave to be ultimate browser on android platform replacing all other browsers but brave developers are not taking my issues/feature requests as high priority.

Just stopped using brave and switched to other browser because they have all privacy related features of brave plus the extreme ui Customization and functiona

rebron commented 2 years ago

Closing as invalid. Both mobile bookmarks and bookmarks bar are special folders that you can't delete as they're part of the ux.

tathastu871 commented 2 years ago

thats why its a feature request. already moved from brave not using it any more.

lazymonkey2 commented 2 years ago

@rebron I think that the original request was not to delete the special folders, but to delete all bookmarks into those folders, without the need to manually select all the bookmarks one by one. So I think it's an error to close this as invalid. It's a perfectly reasonable request, IMHO.

bsclifton commented 2 years ago

@tortino you're right - let me update the issue a bit. Original post is worded as deleting the folders themselves, which is just part of Chromium and Brave UX. But it's absolutely reasonable to provide a way to delete all the bookmarks in those folders

bsclifton commented 2 years ago

Updated issue title and reopened - thanks for the video @tathastu871

It would specifically be great to have a "delete all bookmarks in this folder" option here: image

tathastu871 commented 2 years ago

is there any progress

tathastu871 commented 2 years ago

Please wanting this feature for so long. It wont require much code to just add delete all option and function to delete all bookmarks

yashwanth2804 commented 5 months ago

@tathastu871 https://community.brave.com/t/replace-all-bookmarks/302923/3 check this if this helps

tathastu871 commented 4 months ago

KEYBOARD TRICKS DOESNT WORK ON ANDROID. WHY THE HELL ITS SO DIFFICULT TO ASD BASIC FEATURES LIKE THIS TO BROWSER