brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.74k stars 2.32k forks source link

Feature Request: Open external links in incognito/private mode #18788

Open zamoranos opened 3 years ago

zamoranos commented 3 years ago

Description

Add the option to force the opening of all external links in incognito mode. This is different from issue #7564 since I also want to use this browser in normal mode and only affect external links to use private mode.

Steps to reproduce

  1. Go to chrome://flags
  2. Enable both #cct-incognito & #cct-incognito-available-to-third-party
  3. Open an app and click a link that the Brave browser will open

Actual result

Opening links from other apps still shows in history

Expected result

External links doesn't show up in history when this option is enabled

Additional information

Bromite has already solved this: https://github.com/bromite/bromite/pull/1442 Hope it can be added here too

blogmangit commented 2 years ago

if this is enabled then open links in external apps will not work in that case. Are you OK with this ? if yes give bromite a try or else use Firefox nightly android.

pixincreate commented 1 year ago

open links in external apps will not work

I've been using Bromite for about 2 years now and haven't faced such issues.

It basically gives a prompt asking the user whether to stay on same page or to switch to the app. Clicking on switch ("Leave") will redirect user to the specific targeted app.

It would be really helpful if you could implement this. Necessary patches are already available with Bromite which is also based on Chromium

Also, I found out that, even Mulch browser (a browser by DivestOS based on Chromium) has implemented this feature but toggling that on, restricts users to open apps directly from supported links as you said in the above comment. So, direct implementation of the same would have negative impact on the working while adding additional patches taken from Bromite would make it functional and intuitive

pixincreate commented 1 year ago

Any updates on this?

kjozwiak commented 1 year ago

Removing the closed/by-author label and adding it into the Android project board so the above can be triaged/considered by the product team. CCing @timchilds @anthonypkeane.

pixincreate commented 1 year ago

Thank you for the consideration.

Edit:

Since Bromite project seems to be abandoned, I would suggest checking with Bromite Dev versions instead:
https://github.com/uazo/bromite-buildtools https://github.com/uazo/bromite

aldopareja commented 1 year ago

+1

MaryckBuilds commented 1 year ago

Bump. It's pretty much available in all other browsers

PebbleThrower commented 1 year ago

+1 Shifting to Brave on android here from Bromite and this feature would be one of the last steps for me. It's easy to click a link by mistake and it opens in regular browser and suddenly quite a few trackers and cookies are saved. By opening external links in incognito the trackers and cookies and removed as soon as incognito is closed. I know there is an option to clear all cookies on browser exit but that would also log the user out of their most frequently used websites.

pixincreate commented 1 year ago

Would this feature be implemented? I'm just re-iterating over this since it is the only feature that is holding me from switching over to Brave.

Also, I wanted to let you know that, by default, Chromium has got flags to open custom / external links in incognito which you can find by just typing incognito on chrome://flags. The problem is that it just does not work straight out of the box!

Cc: @timchilds @kjozwiak @deeppandya @anthonypkeane

PebbleThrower commented 12 months ago

Bumping this one again, hoping this feature gets implemented.

renanmav commented 3 months ago

Gentle bump

deeppandya commented 3 months ago

I am adding this issue for internal discussion. We will set the priority based on it.