search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.92k stars 2.35k forks source link

Adaptive captcha `Brave Ads paused` modal is shown when browser window is minimized #18857

Open btlechowski opened 3 years ago

btlechowski commented 3 years ago

Follow up to https://github.com/brave/brave-browser/issues/15600

Steps to Reproduce

  1. Clean profile
  2. Run Brave
  3. Enable Rewards and Ads
  4. Schedule a captcha for your payment ID
  5. Trigger unblinded tokens refill
  6. Minimize Brave

Actual result:

Adaptive captcha Brave Ads paused modal stays visible image

Expected result:

Adaptive captcha Brave Ads paused modal is hidden along with the browser window.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.31.85 Chromium: 95.0.4638.50 (Official Build) (64-bit)
Revision 3e9db37693d0cf8e31a89fbcf50401ae91125cef-refs/branch-heads/4638@{#816}
OS Ubuntu 18.04 LTS

cc @emerick @tmancey @jsecretan @brave/legacy_qa @rebron

emerick commented 3 years ago

You could have multiple browser windows open, so this might get a little bit complicated. Do we implement something similar with ads notifications?

tmancey commented 3 years ago

Multiple profiles should not show multiple ads. However, the solution would not work in this case. @jsecretan we should consider limiting rewards/ads to the users main profile. Your thoughts?